Commit Graph

3706 Commits

Author SHA1 Message Date
Logan Ramos
0a8ca638f1 Resolve Terminal arguments (#76895)
* Resolved terminal argds

* Move location of resolution

* Fix routing of resolver in extHost

* Remove unnecessary comma

* Compilation errors

* some async stuff

* Undo changes

* Variable resolver in constructor

* Load resolver upon construction of extHostTerminalService

* Utilize last active workspace root

* Reevaluate variableReoslver whenever the workspace gets new folder

* Fix types for string shellArgs

* Use async one level higher

* Fix compile issue

* Initialize resolver when exthost is created

* Fix ext host in remote case with no folder open

* Resolve args that an ecxctension passes in

* Remove TODO

* Resolve extension arguments
2019-07-16 09:23:38 -07:00
Matt Bierner
7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Matt Bierner
20d2018d18 Convert to async 2019-07-15 15:44:16 -07:00
Matt Bierner
be5a4fa940 💄 2019-07-15 15:42:48 -07:00
Matt Bierner
4eb2bf393b Use DisposableStore 2019-07-15 15:03:54 -07:00
Matt Bierner
618da58752 Use map instead of object literals in mainThreadTerminalService
Replaces a few uses of object literals with regular maps, which  better enforce type correctness
2019-07-15 12:00:37 -07:00
Matt Bierner
f729a996c6 Use map to track registrations 2019-07-15 11:47:29 -07:00
Matt Bierner
7ed88bd70c Use set to track synced values instead of object literal 2019-07-15 11:47:29 -07:00
Matt Bierner
afe2da7ed6 Use a map instead of a object to store editors 2019-07-15 11:47:29 -07:00
Howard Hung
1d4dc5dcf9 Fix typos 2019-07-15 23:31:48 +08:00
Daniel Imms
2443cf5037 Merge pull request #77298 from microsoft/tyriar/77228_dimensionss
Improve terminal grid dimensions caching
2019-07-13 13:14:47 -07:00
Matt Bierner
5106b556bd Support loading webviews from wildcard endpoints
Fixes #77132

Add support for loading webviews from and endpoint that looks like:

```
https://{{uuid}}.contoso.com/path/to/some/commit/index.html
```

This lets us serve each webview from a seperate origin
2019-07-12 15:38:12 -07:00
Daniel Imms
c9cfc7c5ed Merge remote-tracking branch 'origin/master' into tyriar/77228_dimensionss 2019-07-12 10:42:34 -07:00
Daniel Imms
fd48fa0d3b Fix dimenisons test and clean up 2019-07-12 10:37:29 -07:00
Sandeep Somavarapu
b3422b98b7 Merge pull request #76377 from microsoft/sandy081/fix74859
trigger workspace contains activation event on new folders
2019-07-12 16:42:56 +02:00
Alex Dima
498f158475 Small style tweaks 2019-07-12 16:13:27 +02:00
Daniel Imms
3092a1023c Remember dimensions from other terminals
Part of #77228
2019-07-11 21:18:06 -07:00
Daniel Imms
5701770f87 Ensure negative exit codes are not used
Fixes #77250
2019-07-11 15:47:15 -07:00
Johannes Rieken
3a47abace1 create instantiation service in api.impl and create extHostDebug with it, #76570
also tweak some names and types
2019-07-11 17:02:01 +02:00
Martin Aeschlimann
4ffdeee2c2 Merge branch 'master' into aeschli/isEqualCaseSensitiveForNonFIle 2019-07-11 14:59:03 +02:00
Johannes Rieken
e9d8aaafcb improve image source extraction for remote cases, https://github.com/kisstkondoros/gutter-preview/issues/57 2019-07-11 11:25:49 +02:00
SteVen Batten
305d5be119 implement browser clipboard service (#75293)
* implement browser clipboard service

* actually register the clipboard service

* update all refs to newly async funcs

* addressing comments

* small fixes

* all asyncs as a result of readText

* fix unit test

* cleanup for writeText refs

* cleanup and reduce diff noise

* qfix

* address feedback
2019-07-11 09:49:28 +02:00
Matt Bierner
ca7605f339 Use a uuid as our webview handles
Avoid having duplicated ids/handles
2019-07-10 11:55:37 -07:00
Matt Bierner
f57ff0b25c Remove webview _onBeforeShutdown
This should no longer be required
2019-07-10 11:55:37 -07:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00
Johannes Rieken
046b66fb8f move workspace.fs to stable, #48034 2019-07-10 16:20:36 +02:00
Alex Ross
e84fc7021b Adopt TerminalVirtualProcess for Custom task execution (#76852)
* Adopt TerminalVirtualProcess for Custom task execution

* Update Custom task execution API to return TerminalVirtualProcess in callback

This also required the addtion of a start on the virtual terminal process

* Clarify start API

Fixes #76492
2019-07-10 09:31:40 +02:00
Matt Bierner
c01a3a718d Use clearer name for csp webview element
#76489
2019-07-09 11:45:20 -07:00
Matt Bierner
f963c9a2a8 Adding tests and changing how toWebviewResource works
- Allow placeholders in the webviewEndpoint. This is required to support serving each webview from its own origin
- Add tests for toWebviewResource
2019-07-09 11:45:10 -07:00
Johannes Rieken
d0fcf07040 debt - better check for reserved schemes 2019-07-09 17:03:39 +02:00
Johannes Rieken
bc00e886a9 make it easier to use options, #48034 2019-07-09 16:27:53 +02:00
Johannes Rieken
65270230af tweak options for delete and write, #48034 2019-07-09 16:23:48 +02:00
Johannes Rieken
a4fc9bb8c4 improved error propagation, #48034 2019-07-09 16:17:02 +02:00
Johannes Rieken
51123cd133 wrap error into FileSystemError, #48034 2019-07-09 15:20:10 +02:00
Sandeep Somavarapu
3b9d26ded9 #76442 fix implicit any 2019-07-09 12:28:52 +02:00
Matt Bierner
a558a9504a Adding toWebviewResource api
For #76489
2019-07-08 18:38:47 -07:00
Matt Bierner
f928d0eb36 Add log message to help catch leaked disposables in ext host 2019-07-08 17:53:32 -07:00
Daniel Imms
8ec3a1b39e Rename input to handleInput
Part of #70978
2019-07-08 12:32:27 -07:00
Alex Ross
a70ca602bc Adopt new tree in custom views (#76407)
Auto expand initial state of tree nodes is not yet implemented.
Part of #63566
2019-07-08 18:07:16 +02:00
Daniel Imms
dbe1ae7596 Merge pull request #76807 from microsoft/tyriar/shell_stable
Make vscode.env.shell stable API
2019-07-08 07:52:35 -07:00
Johannes Rieken
c5cdf50e17 prep-work for #76847 2019-07-08 11:39:01 +02:00
Johannes Rieken
4259b43f70 Revert "fix double encoding issue, https://github.com/microsoft/vscode-azure-account/issues/142"
This reverts commit 781e61bf56.
2019-07-08 09:56:49 +02:00
Johannes Rieken
441da58f1e debt 2019-07-08 09:55:02 +02:00
Daniel Imms
931b27d834 Move env.shell to stable 2019-07-07 09:57:43 -07:00
Daniel Imms
6dabbf2963 Merge pull request #76736 from microsoft/alexr00/terminalVPChanges
Changes to terminal to enable Tasks use of TerminalVirtualProcess
2019-07-05 09:49:02 -07:00
Daniel Imms
8bd0e79c73 Fix ext host terminals
Fixes #76670
2019-07-05 09:06:11 -07:00
Alex Ross
8aed46f950 Revert unneeded export 2019-07-05 18:01:08 +02:00
Alex Ross
6f40ddeee2 Revert whitespace change 2019-07-05 17:59:05 +02:00
Alex Ross
65f53d53b1 Changes to terminal to enable Tasks use of TerminalVirtualProcess 2019-07-05 17:57:03 +02:00
Daniel Imms
ed54d9a483 Allow tasks to attach virtual process to a terminal created on renderer 2019-07-05 08:03:39 -07:00