Commit Graph

2817 Commits

Author SHA1 Message Date
Matt Bierner
9061cad570 Removing preview.html command
Fixes #62630
2019-03-01 16:06:51 -08:00
Peng Lyu
15d782f4a4 Update comment range 2019-03-01 10:06:54 -08:00
Gabriel DeBacker
ca923da1d4 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-02-27 10:17:22 -08:00
Alex Dima
e2049cdca3 Remove public facing usages of indentSize (#10339) 2019-02-27 17:24:32 +01:00
Joao Moreno
dafd1aab8f missing semi 2019-02-23 08:09:00 +01:00
Peng Lyu
e5dbd34dd3 Merge pull request #69253 from Microsoft/rebornix/commentscontrol
Comments API refactor
2019-02-22 16:54:39 -08:00
Peng Lyu
bb62f5036d Support new comment thread creation. 2019-02-22 16:46:49 -08:00
Andre Weinand
e5da9b8d55 rescan debugger extensions; fixes #69100 2019-02-22 23:37:44 +01:00
Peng Lyu
4f249529e8 Commenting Ranges API 2019-02-22 12:05:08 -08:00
Peng Lyu
39218635a5 Dispose commentcontrol properly. 2019-02-22 11:29:58 -08:00
Peng Lyu
bcc48091d3 Make sure CommentControl & CommentsProvider handles are unique. 2019-02-22 11:02:23 -08:00
Martin Aeschlimann
eee10d2c7f Stop restarting extension host when root folders change. 2019-02-22 16:47:34 +01:00
Martin Aeschlimann
14f25a6102 "--extensionTestsPath" does not accept uris 2019-02-22 16:22:10 +01:00
Benjamin Pasero
1aee0c194c debt - scaffold a service for package.json/product.json access 2019-02-21 12:55:46 +01:00
Alex Dima
9f11bfb31f Small rename 2019-02-21 12:20:19 +01:00
Alexandru Dima
de3ec3dd34 Merge pull request #69131 from Microsoft/sandy081/fixDeadlock
fix dead lock
2019-02-21 12:19:11 +01:00
Alex Dima
26d204adc9 Introduce a second barrier 2019-02-21 12:17:39 +01:00
Sandeep Somavarapu
4c7870316d fix dead lock - wait for workspace initialization while starting exthost 2019-02-21 12:00:39 +01:00
Andre Weinand
4215ed797c protect against undefined session; fixes #69128 2019-02-21 11:56:54 +01:00
Sandeep Somavarapu
564b7120ab clean up 2019-02-21 11:34:03 +01:00
isidor
835458245d labelService: register formatters via API. Also expose getSeperator 2019-02-21 10:01:52 +01:00
Peng Lyu
de52daea94 edit/delete command 2019-02-20 16:45:50 -08:00
Peng Lyu
38e0c3f2c2 accept input commands. 2019-02-20 16:45:14 -08:00
Matt Bierner
a3e98d6c9b Take a code action kind instead of a string for _executeCodeActionProvider 2019-02-20 13:36:44 -08:00
Gabriel DeBacker
d728d3dca8 Merge with master 2019-02-20 09:59:44 -08:00
Alex Dima
3199f1fd3b Introduce and adopt IExtHostWorkspaceProvider 2019-02-20 17:11:51 +01:00
Alex Dima
43f6bf8ff7 Address some null errors (#60565) 2019-02-20 12:05:33 +01:00
Matt Bierner
5c5d64e601 Remove cast that was causing type error 2019-02-19 16:41:24 -08:00
Matt Bierner
7e759cf3c8 Annotate more usage before assign strict null errors 2019-02-19 16:29:01 -08:00
Matt Bierner
e9a1cea1fd Strict null fixes in extHost 2019-02-19 16:29:01 -08:00
Gabriel DeBacker
5d1720321d Code review updates 2019-02-19 14:33:25 -08:00
Gabriel DeBacker
f8f8f519d9 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-02-19 10:11:23 -08:00
Sandeep Somavarapu
ef2a3e89fb #68927 use path.join 2019-02-19 12:48:00 +01:00
Sandeep Somavarapu
e2b1f24253 #68658 Strict null check - ExtHostConfiguration test 2019-02-19 12:06:08 +01:00
Sandeep Somavarapu
36e3c88fa4 #68658 Strict null check - ExtHostConfiguration 2019-02-19 12:06:08 +01:00
Alexandru Dima
f095776d67 Merge pull request #62079 from dlech/issue10339
add editor.indentSize option
2019-02-18 16:44:36 +01:00
Alex Dima
b164459bf8 Tweaks for #62079 2019-02-18 16:41:01 +01:00
Benjamin Pasero
39566fa5e3 Reduce usages of extpath.normalizeWithSlashes() (#68928)
* adopt in tests

* adopt more join() that are straight forward

* more safe usages

* more adoption
2019-02-18 16:31:02 +01:00
David Lechner
5f70fddbfa Add editor.indentSize option
This is an attempt to address issue #10339.

Background:

Currently, the `editor.tabSize` option does two things - it specifies the width of the tab character and it specifies how many columns to advance when the tab key is pressed. However, there is code in the wild that has a mix of spaces and tabs that expects these two values to be different.

These generally use and indent size of 2 or 4 and spaces are used for indentation until the indent becomes >= 8. The tab character size is excpected to be 8 and groups of 8 spaces are replaced with a tab character. Indent levels end up looking like 2 spaces, 4 spaces, 6 spaces, 1 tab, 1 tab + 2 spaces, and so on.

Implementation:

In the editor options, a new option, `editor.indentSize` is added. This, in conjunction with `editor.tabSize` has the same semantics as `indent_size` and `tab_width` in the well known [EditorConfig specification][1].

> indent_size: a whole number defining the number of columns used for each indentation level and the width of soft tabs (when supported). When set to "tab", the value of tab_width (if specified) will be used.
>
> tab_width: a whole number defining the number of columns used to represent a tab character. This defaults to the value of indent_size and doesn't usually need to be specified.

[1]: editorconfig.org

The new `indentSize` option takes a numeric value or "tab" just as EditorConfig's `indent_size`. The default value is set to "tab" so that current default behavior of VS Code does not change and existing user settings will not break.

When getting the new `indentSize` option programatically, it always returns a numeric value (just as `tabSize` does when set to the deprecated "auto" value).

In the text editor model, a new property is added for `indentSize`. Unlike the configuration options where the value of one property influences the other, In this code `tabSize` now should only mean "the width of the tab character" and `indentSize` should only mean "how may columns is one indent".

The cursor operations and shift command are updated to reflect these new semantics.
2019-02-18 12:17:13 +01:00
Martin Aeschlimann
73a912ce9e rename pathext.join to joinWithSlashes 2019-02-18 10:36:09 +01:00
Benjamin Pasero
67494c9dcb paths - drop pathToRelative workaround 2019-02-18 10:19:39 +01:00
Gabriel DeBacker
a7565721ba Clean up comments, fix some code review issues, and make the exit code optional throughout to make it clear that it isn't always a number 2019-02-17 09:18:41 -08:00
Gabriel DeBacker
fc6f637899 Remove C/CPP tools from built-in extensions 2019-02-17 08:39:00 -08:00
Matt Bierner
597e6dc470 Take optional kind for vscode.executeCodeActionProvider command
This is required as some code actions providers will not return results unless code actions of a specific kind are requested
2019-02-15 20:17:21 -08:00
Peng Lyu
67ad526371 comment control. active thread, comment, input update. 2019-02-15 17:48:03 -08:00
Martin Aeschlimann
98953dd91a rename resources.fsPath to resources.originalFSPath 2019-02-15 16:40:23 +01:00
Martin Aeschlimann
833fc7aa99 test fix 2019-02-15 16:40:23 +01:00
Martin Aeschlimann
a06dbfc3f2 rename extpath.normalize to extpath.normalizeWithSlash 2019-02-15 16:40:23 +01:00
Martin Aeschlimann
92a61b8d16 use path.normalize for extpath.normalize(.., true) 2019-02-15 16:40:23 +01:00
Matt Bierner
f558087bfd Converting some instances of Promise.resolve(null) to Promise.resolve()
In `Action.run` methods, we don't need an explicit null return value but can use undefined instead
2019-02-14 14:45:46 -08:00