Commit Graph

3588 Commits

Author SHA1 Message Date
Daniel Imms
0aab08edf2 Add getDefaultShellAndArgs
Also differentiate default from system shell
2019-06-19 15:25:44 -07:00
Daniel Imms
87e16500d2 Call getDefaultShell via ext host on web
Part of #75795
2019-06-19 12:57:26 -07:00
Johannes Rieken
781e61bf56 fix double encoding issue, https://github.com/microsoft/vscode-azure-account/issues/142 2019-06-19 11:53:12 +02:00
Johannes Rieken
300e4bdf2a fix #75746 2019-06-19 11:18:32 +02:00
Johannes Rieken
c8843e3b0d final touch at heap service removal, #74846 2019-06-19 10:58:24 +02:00
Rob DeLine
b0a49817dc z-order bug fix 2019-06-18 16:22:21 -07:00
Rob DeLine
9b5e03b1f6 Merge branch 'master' of https://github.com/Microsoft/vscode into code-inset-fix 2019-06-18 14:49:23 -07:00
Daniel Imms
331da82ad5 Enable shell selector outside Windows
Fixes #75718
2019-06-18 11:28:36 -07:00
Daniel Imms
b3bba0c939 Merge branch 'master' into tyriar/75456_windows_term 2019-06-18 11:00:04 -07:00
Benjamin Pasero
998a65e2ca web - best lifecycle support we can do currently 2019-06-18 15:12:46 +02:00
Daniel Imms
d0820c2e06 Disable old shell detection mechanism 2019-06-17 11:55:43 -07:00
Daniel Imms
c287c3cfc7 Get default shell selector working 2019-06-17 11:53:58 -07:00
Daniel Imms
7dfbccb8e2 Disable conpty on remote 2019-06-17 10:48:03 -07:00
Daniel Imms
fbd7b4920b Merge pull request #75290 from microsoft/75278_finalize_runInBackground
Finalize TerminalOptions.runInBackground API
2019-06-17 09:34:59 -07:00
Daniel Imms
a7412fbb2b Pass cwd through to main 2019-06-17 09:32:07 -07:00
Benjamin Pasero
bb0603c573 adopt more DisposableStore/MutableDisposable (#74922) 2019-06-17 09:31:13 +02:00
Peng Lyu
8ef603062f #74846. no CommandsConverter#toInternal 2019-06-14 13:03:41 -07:00
Daniel Imms
97dfc68f39 Merge remote-tracking branch 'origin/master' into alexr00/terminalExitRace 2019-06-14 12:14:40 -07:00
Daniel Imms
10d4256ff5 Remove process usage from terminalEnvironment
Fixes #75509
2019-06-14 11:33:37 -07:00
Johannes Rieken
fa71df46e6 remove ExtHostHeapService 2019-06-14 19:19:44 +02:00
Daniel Imms
e08e8b025f Move window.shell to env.shell
Part of #75091
2019-06-14 09:15:39 -07:00
Daniel Imms
52a351f8ff Merge pull request #75455 from microsoft/tyriar/75091_default_shell_api
Implement API to get default shell
2019-06-14 09:13:28 -07:00
Sandeep Somavarapu
3ccd965ddb Fix #74833 2019-06-14 15:08:45 +02:00
Johannes Rieken
cb865f934a remove extHostHeapService, use normal cache in commands converter, #74846 2019-06-14 13:02:18 +02:00
Johannes Rieken
8e91c0db03 Merge pull request #75461 from microsoft/dev/mjbvz/remote-heap-for-sig-help
Don't use heap service for signature help
2019-06-14 12:46:24 +02:00
Benjamin Pasero
c6d9e8ea64 status - push proposed API for statusbar id/name and adopt 2019-06-14 11:52:39 +02:00
Matt Bierner
580bd304c9 Don't use heap service for signature help
For #74846

Migrates from using the heap service to have an explicit lifecycle
2019-06-13 17:49:00 -07:00
Matt Bierner
592b91b5cb Use readonly for cache
This type never modifies the input arrays
2019-06-13 16:43:09 -07:00
Daniel Imms
976320ddd2 Pass workspace shell permissions to ext host 2019-06-13 15:41:00 -07:00
Daniel Imms
83ba7099ff Default shell API
Part of #75091
2019-06-13 15:13:31 -07:00
Matt Bierner
3bb736272e Mark readonly on insertSnippet
This function does not modify the input array
2019-06-13 14:11:46 -07:00
Daniel Imms
e3609a9576 Hook up new method 2019-06-12 16:35:29 -07:00
Daniel Imms
86aa7aef36 Allow terminals to launch using clean env on Mac and Linux
Fixes #70248
2019-06-12 16:29:02 -07:00
Matt Bierner
a6a376e933 Merge pull request #75092 from microsoft/dev/mjbvz/readonly-diagnostics-api
Use readonly arrays for the vscode.DiagnosticCollection api
2019-06-12 14:46:17 -07:00
Rob DeLine
b799118b39 fix 2019-06-12 12:49:58 -07:00
Matt Bierner
e7a5f9a5e2 Remove the vscode-core-resource scheme
This is no longer required and complicates loading of resources. Use the standard `vscode-resource` scheme instead
2019-06-12 11:17:59 -07:00
Johannes Rieken
1ad12b24a6 allow extension resources in editor insets 2019-06-12 18:09:34 +02:00
Sandeep Somavarapu
92fed79878 #74846 Dispose internal commands 2019-06-12 16:49:10 +02:00
Johannes Rieken
34c1f859cf remove gc-signals, heapservice, and mainThreadHeapService, #74846 2019-06-12 16:20:49 +02:00
Joao Moreno
08bb5a13c0 use toInternal2
related to #74846
2019-06-12 15:19:44 +02:00
Daniel Imms
a004864bda Finalize TerminalOptions.runInBackground API
Fixes #75278
2019-06-11 11:21:02 -07:00
Benjamin Pasero
7bc29bf67c debt - fix command alias (#75242) 2019-06-11 10:02:50 +02:00
Benjamin Pasero
eabd2c51a4 fix #69334 2019-06-11 09:54:48 +02:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions
Comment Reaction API
2019-06-10 10:36:21 -07:00
Matt Bierner
1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
2019-06-07 18:26:19 -07:00
Matt Bierner
8448512143 Use readonly arrays for the vscode.DiagnosticCollection api
## Problem
The diagnostic collection object is set up so that it does not mutate the arrays of diagnostics you pass to it. It also does not expect or allow mutation of diagnostics that it returns.

However it it currently typed using normal arrays. This means that if an extension (such as JS/TS) wishes to use readonly diagnostics intnernally, it cannot do so without casting.

## Proposed Fix
Use `ReadonlyArray` in diagnostic collection. This should be a safe change for the `set` type methods. The changes to `get` and `forEach` have the risk of breaking the typing of some extensions, but `get` already returned a frozen array of diagnostic so trying to mutate the array itself would have resulted in runtime error.
2019-06-07 11:41:33 -07:00
Matt Bierner
f8c8531e78 Merge pull request #75048 from mjbvz/add-lifecyle-for-code-actions
Replace heapservice with lifecycle for code actions
2019-06-07 10:28:05 -07:00
Johannes Rieken
5f91328fb1 fix layer breaker with credentials service, #74997 2019-06-07 12:02:42 +02:00
Matt Bierner
b4a00ca33f Replacing heapservice with lifecycle for code actions
Part of #74846

Code Actions can use commands internally, which must be disposed of. We were previously using the heap service for this but this will not work for the web. Add a custom lifecycle instead
2019-06-06 22:12:56 -07:00
Benjamin Pasero
eddc3f4a23 status - fix empty extension 2019-06-06 18:38:42 +02:00