Commit Graph

8830 Commits

Author SHA1 Message Date
Benjamin Pasero 6a8b201c8a smoke - restore skip-release-notes CLI arg (#96459) 2020-04-29 12:40:04 +02:00
Rachel Macfarlane 11ec8269ed Pass correct host for VSO token 2020-04-28 15:17:22 -07:00
Rachel Macfarlane a1a98d07da Fix github authentication in the web, fixes #96406 2020-04-28 14:00:41 -07:00
Rachel Macfarlane 4b7882a2d2 Remove unused variable 2020-04-28 10:26:28 -07:00
Rachel Macfarlane ed9be86c6a Remove auth provider extension contributed sign in/out commands, fixes #96346 2020-04-28 09:00:11 -07:00
Alex Ross 27a97b9534 Allow quick suggestions in strings in dockerfiles
Part of #95924
2020-04-28 15:46:05 +02:00
João Moreno 0209826b56 fixes #96399 2020-04-28 15:09:38 +02:00
Andrew Casey 13d3a9358b Update npm script compile-extension:typescript-language-features (#96320) 2020-04-27 18:38:08 -07:00
Andrew Casey 3ecefe6d7a Make char position optional in TS stack (#96321) 2020-04-27 18:37:50 -07:00
kieferrm 3aa931c67d fix GDPR annotation 2020-04-28 00:49:18 +00:00
Matt Bierner 686ad17217 Clean up onTypesInstallerInitializationFailed
- Convert to async
- don't require using inline type with id
2020-04-27 16:42:45 -07:00
Martin Aeschlimann 919c46deab [html] update dependencies 2020-04-27 23:15:37 +02:00
Martin Aeschlimann 0cb91f61bd [css] update dependencies 2020-04-27 23:07:25 +02:00
Martin Aeschlimann 4a3bd05497 [json] Go to definition for $ref. Fixes #69411 2020-04-27 22:30:58 +02:00
Andrew Casey 27e2e92a54 Clean up CallstackOrException telemetry in typescript-language-features (#96108)
One was actually SystemMetaData, all others were either dropped or
replaced with sanitized versions classifiable as SystemMetaData.
2020-04-27 12:13:00 -07:00
Rachel Macfarlane b05b32bfd8 Use github auth server for provider 2020-04-27 08:10:46 -07:00
Daniel Imms eb64e93b17 Add ref to why test is disabled 2020-04-27 07:34:59 -07:00
Daniel Imms aebfe022af Disable tasks tests in web
Part of #90528
2020-04-27 07:30:06 -07:00
João Moreno 75877c8185 Merge pull request #96080 from johnbillion/fix/gitignore_global
Treat `.gitignore_global` as an Ignore file by default.
2020-04-27 15:58:23 +02:00
João Moreno 15e159a713 💄 2020-04-27 15:00:06 +02:00
João Moreno 8ff93b98c5 git: config.githubAuthentication 2020-04-27 14:57:47 +02:00
João Moreno 54d8261f93 git: config.terminalAuthentication 2020-04-27 14:57:47 +02:00
João Moreno bc9854b494 git: use environmentVariableCollection 2020-04-27 14:57:47 +02:00
João Moreno c7fec92849 Merge pull request #96069 from microsoft/joao/github-auth
Provide automatic git authentication to GitHub
2020-04-27 12:23:16 +02:00
João Moreno bce93beff7 move github credential provider to git 2020-04-27 12:14:23 +02:00
Daniel Imms 7f5bada046 Move EnvironmentVariableCollection API into ExtensionContext (#96061)
* Move env var collection to ext context

* Remove dispose, fix persistent passing

* Fire collection change on persistence change

* Fix tests by forcing activation and getting ctx

* chore: bump js-debug

Co-authored-by: Connor Peet <connor@peet.io>
2020-04-24 16:45:30 -07:00
Rob Lourens 9b995534bc Add tests for metadata 2020-04-24 17:49:49 -05:00
Matt Bierner 4862602c4c Align custom editor API proposal with notebook API
Fixes #95854
Fixes #95849
For #77131

- Move all editing functionality back onto the provider. This better matches the notebook API.

- Rename `CustomEditorProvider` to `CustomReadonlyEditorProvider`.  `CustomEditorProvider` is now how editable custom editors are implemented

- Give extension a full suggested backup path instead of just a folder
2020-04-24 14:47:08 -07:00
rebornix cea1d2f91f fix notebook integration test 2020-04-24 13:04:14 -07:00
Liying ec5c1264bc Update compilerOptions returned by host for javascript.implicitProjectConfig.experimentalDecorators. (#95923)
Co-authored-by: liyche <liyche@umich.edu>
2020-04-24 11:34:03 -07:00
Rob Lourens 12e92983ad Update notebook test command IDs 2020-04-24 12:59:06 -05:00
John Blackbourn 4281e933d3 Treat .gitignore_global as an Ignore file by default. Fixes #96079. 2020-04-24 18:44:18 +01:00
Andre Weinand 795050f81b serverReady fix for #95108 2020-04-24 18:37:32 +02:00
João Moreno 065bb1b5d6 wip: use registerCredentialsProvider in github-authentication extension 2020-04-24 18:04:47 +02:00
João Moreno cab6f958a2 git extension api: registerCredentialsProvider 2020-04-24 18:04:36 +02:00
João Moreno 77d7351226 add log to askpass ipc 2020-04-24 15:40:03 +02:00
Daniel Imms ae1670d4ea Disable terminal tests in remote
Too flaky they're not useful.

See #96057
2020-04-24 06:27:59 -07:00
Daniel Imms aa91f911f9 Suppress exit code notification in terminal test 2020-04-24 06:08:58 -07:00
Matt Bierner a4597e1905 Enable JS/TS workspace symbol search for all projects
Fixes #11026

Adds a new `typescript.workspaceSymbols.scope` setting that enables searching all known projects when using TS 3.9+
2020-04-24 00:42:55 -07:00
Matt Bierner f35758ab21 Rename supportsMultipleEditorsPerResource -> supportsMultipleEditorsPerDocument
For #77131
2020-04-23 17:33:06 -07:00
rebornix 9b11e5d500 avoid conflict with jupyter in OSS 2020-04-23 14:30:54 -07:00
Matt Bierner 7d238f4281 Add 'open with' to the explorer context menu (#95805)
This change primarly adds a new `Open with...` entry to the explorer context menu. To do this however, I had to make a few other changes:

- Add a new explorer context key for availible editors
- Moved the editor select prompt into a new function called `openEditorWith`
- Use `openEditorWith` for the new `open with` explorer command as well as for the `reopen with` command
2020-04-23 14:16:36 -07:00
rebornix 600528da86 Fix #96007. 2020-04-23 13:53:58 -07:00
Peng Lyu 582ced0089 Merge pull request #96001 from microsoft/rebornix/integration-test
Notebook integration test and undo/redo
2020-04-23 13:06:21 -07:00
Rachel Macfarlane badd41f04a Better error handling in github auth provider 2020-04-23 12:16:33 -07:00
Peng Lyu dc6f64a0d0 Merge branch 'master' into rebornix/integration-test 2020-04-23 11:59:59 -07:00
rebornix b9eafe5f66 intergration tests. 2020-04-23 11:55:23 -07:00
Daniel Imms 87c0080c3a Merge pull request #95969 from microsoft/tyriar/95945
Make terminal echo integration test more reliable
2020-04-23 11:04:01 -07:00
Connor Peet 66744e3b25 debug: enable js-debug to auto attach (#95807)
* debug: enable js-debug to auto attach

This modifies the debug-auto-launch extension to trigger js-debug as
outlined in https://github.com/microsoft/vscode/issues/88599#issuecomment-617242405

Since we now have four states, I moved the previous combinational logic
to a `transitions` map, which is more clear and reliable. The state
changes are also now a queue (in the form of a promise chain) which
should avoid race conditions.

There's some subtlety around how we cached the "ipcAddress" and know
that environment variables are set. The core desire is being able to
send a command to js-debug to set the environment variables only if they
haven't previously been set--otherwise, reused
the cached ones and the address.

This process (in `getIpcAddress`) would be vastly simpler if extensions
could read the environment variables that others provide, though there
may be security considerations since secrets are sometimes stashed
(though I could technically implement this today by manually creating
and terminal and running the appropriate `echo $FOO` command).

This seems to work fairly well in my testing. Fixes #88599.

* fix typo

* clear js-debug environment variables when disabling auto attach
2020-04-23 09:49:29 -07:00
Daniel Imms 3d7745d6fc Dispose data listener before disposing terminal
Fixes #95945
2020-04-23 07:29:47 -07:00