Commit Graph

1068 Commits

Author SHA1 Message Date
Aiday Marlen Kyzy
fa548237be Adding acceptance condition to dispatchKeybinding in smoketests (#242570)
* adding code for smoke tests

* adding awaits

* changing wait code

* renaming dispatch to send

* moving comment

* update to send
2025-03-05 11:38:48 +01:00
Alex Ross
cf46a56bd4 Disable changes "workbench.action.toggleSidebarPosition" command key binding and verifies it (#239820) 2025-02-06 09:18:24 -08:00
Benjamin Pasero
5e667f741b smoke tests - run with snapshots: true for tests that install extensions (#238855) 2025-01-27 17:30:59 +01:00
Benjamin Pasero
789c320a1c Replace mkdirp with fs.mkdirSync(path, { recursive: true }) (#228017)
* Replace mkdirp with fs.mkdirSync(path, { recursive: true })
(fix #227931)

* compile
2024-09-09 22:43:29 -07:00
Robo
b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Robo
00427fda20 chore: update electron@30.3.1 (#225106)
* chore: update electron@30.3.1

* temp: update distro

* chore: update node.js builds

* temp: update distro

* temp: revert node-pty

* Revert "temp: revert node-pty"

This reverts commit e834f75959ffd0078708db764457e05ec0f3b6b6.

* temp: test with oss electron

* chore: update node.js checksums

* Revert "temp: test with oss electron"

This reverts commit 18506aaa82b2cf44e4b5780eac1b929bbf98ac11.

* temp: disable sandbox for smoke tests

* Revert "temp: disable sandbox for smoke tests"

This reverts commit 8596ef5fcc776cc9a14b4546f9e448ccba2acbad.

* test: skip icon validation task smoke tests

* chore: bump distro
2024-08-09 23:44:42 +00:00
Peng Lyu
3b0671e73a Enable notebook smoke test for electron only (#224968) 2024-08-06 10:38:22 -07:00
Alex Ross
c23e35103f BUILD: skip "check object leaks" test (#224923) 2024-08-06 01:55:35 -07:00
Peng Lyu
df447e7ad4 Merge pull request #224547 from microsoft/rebornix/net-boa
Enable notebook smoke test and capture memory leaks
2024-08-05 15:44:22 -07:00
Peng Lyu
30330d22a2 release object group 2024-08-05 13:24:53 -07:00
Peng Lyu
af98c564c2 accurate heap leak checks 2024-08-02 14:32:46 -07:00
Peng Lyu
d6349df968 fix false negative test 2024-08-02 13:43:33 -07:00
Peng Lyu
317a4589c2 Support tracking multiple leaks 2024-08-02 12:28:02 -07:00
Peng Lyu
8355790709 Enable notebook smoke test and capture memory leaks 2024-08-01 23:41:08 -07:00
Alex Ross
eb1f210220 Skip "should persist buffer content"
Part of #216464
2024-08-02 07:51:53 +02:00
Megan Rogge
3cf2a00cef rm carriage returns from terminal buffer string in smoke test (#224525) 2024-08-01 14:40:21 -07:00
Megan Rogge
14253f3cd9 fix flaky terminal persistence smoke test (#224414)
fix #216464
2024-07-31 11:25:36 -07:00
Daniel Imms
249b7c2c78 Skip all terminal smoke tests on Linux
These can flake due to the pty host crashing. Disabling for now, they require
more investigation. Tracked in #216564
2024-07-31 08:04:09 -07:00
Alex Ross
5410988877 Skip terminal editor tests (#224375)
Part of #224269
2024-07-31 01:29:03 -07:00
Matt Bierner
84607a2fe2 Fix some always true/false errors in codebase (#223359)
* Fix some always true/false errors in codebase

Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase

Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases

* Bump TS version

* Fix unreachable in build scripts

* Bump versions

* restore intent

* Revert package.json change

* Fixing a few new layer checker errors

These are global in node now

* Skip lib check in integration project

* One more skiplibcheck

* More skip lib

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2024-07-30 15:37:27 -07:00
Alex Ross
447e8dcee6 Disable failing terminal tests (#224273) 2024-07-30 02:24:36 -07:00
Ulugbek Abdullaev
1940f14ec6 disable a windows smoke test to enable insiders release 2024-07-15 14:32:40 +02:00
Daniel Imms
6864b950ef Skip flaky terminal tabs test
Part of #216564
2024-07-04 08:40:48 -07:00
Francisca Carneiro
f93c5bc0c5 Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. (#213067)
Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
2024-06-04 15:13:40 -07:00
Robo
5216c04428 chore: update to electron 29 (#209818)
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs a0f9e09f64

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs eacec5f490

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Daniel Imms
3e49f239c9 Enable terminal smoke tests on desktop
Fixes #146811
2024-04-02 09:08:45 -07:00
Daniel Imms
511929fc52 Remove other icon smoke tests 2024-04-01 04:35:44 -07:00
Daniel Imms
a00e2b9455 Remove terminal change icon tests as they required quick pick 2024-03-29 11:59:04 -07:00
Benjamin Christopher Simmonds
a8f73340be Fix for smoketest extension installation timeout (#205444)
hover smoke test fix #204771
2024-02-17 17:58:12 +01:00
Logan Ramos
233fd797c0 Skip flaky extension smoke tests (#205309) 2024-02-15 22:05:54 +01:00
Benjamin Christopher Simmonds
5b8fe0ed3e Fix smoke test (#204836)
fix smoke test
2024-02-09 16:47:22 +01:00
Logan Ramos
bcf9b4ff0f Skip extension smoketest (#204775) 2024-02-08 22:14:55 +01:00
Raymond Zhao
fb84f3bcfb test: skip flaky Settings editor smoke test (#202097) 2024-01-09 18:16:42 +01:00
Martin Aeschlimann
56b0088dce update vscode-test-web (#201187)
* update vscode-test-web

* add @playwright/browser-chromium

* add skipLibCheck

* add skipLibCheck

* use esnext

* cleanup
2023-12-19 16:03:03 +01:00
Josh Soref
69ddb3f3c6 Write out Cannot (#198377)
spelling: cannot

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-20 17:22:21 +00:00
Daniel Imms
0fa8f868a5 Correct setting name in smoke test 2023-11-11 05:15:09 -08:00
Daniel Imms
d9520bd5dc Add smoke test for multi-line prompt sticky scroll 2023-11-09 08:28:19 -08:00
Daniel Imms
4b2ed32ec3 Clean up, simplify smoke test 2023-11-08 11:15:18 -08:00
Daniel Imms
3794d74d3c Fix polling error compile 2023-11-08 09:49:39 -08:00
Daniel Imms
29ddbd371e Simplify polling 2023-11-08 09:39:40 -08:00
Daniel Imms
35ae6b1925 Use a polling approach for writing and asserting 2023-11-08 09:20:44 -08:00
Daniel Imms
9ad04e81aa Combine write data calls 2023-11-08 07:42:25 -08:00
Daniel Imms
bff9161987 Make empty terminal smoke test technique reusable 2023-11-08 07:16:24 -08:00
Daniel Imms
bd2d20551d Make sticky scroll smoketest even more consistent 2023-11-08 07:11:14 -08:00
Daniel Imms
90d1e81ce9 Make sticky scroll smoketest more consistent 2023-11-08 06:30:51 -08:00
Daniel Imms
26db70d00a Fix sticky scroll smoketest on linux 2023-11-08 05:58:03 -08:00
Daniel Imms
64ac05a2e9 Add simple terminal sticky scroll smoke test 2023-11-08 05:23:01 -08:00
Raymond Zhao
e9e1f8a132 Revert "Separate Settings editor open and search steps" (#196997)
Revert "Separate Settings editor open and search steps (#196866)"

This reverts commit 932e49579b.
2023-10-30 09:53:19 -07:00
Raymond Zhao
932e49579b Separate Settings editor open and search steps (#196866) 2023-10-30 07:50:27 -07:00
Connor Peet
c2a6932e9e eng: onboard to the extension test runner (#195570)
* eng: onboard to the extension test runner

Adds a `.vscode-test.js` file that uses the new extension test CLI to
run tests. Also, onboards the markdown-language-features as the first
built-in extension to use it.

With the `ms-vscode.extension-test-runner` extension installed, the
markdown-language-features' tests can be run and debugged easily in
the UI :)

* fixup
2023-10-13 13:11:05 -07:00