Commit Graph

1886 Commits

Author SHA1 Message Date
Gabriela Araujo Britto
0f9abf3c35 [typescript-language-features] Expandable hover (#228255)
* add verbosity level to hover provider

* cleanup

* update minimum ts version

* get `canIncreaseVerbosityLevel` from server response

* add expandable hover experimental setting
2024-09-24 09:22:09 -07:00
Matt Bierner
4840eb096d Enable semantic features for untitled files on web (#229426)
Fixes #229424

Also removes an old scheme that is no longer used
2024-09-23 11:55:37 -07:00
Daniel Rosenwasser
75c0fc210a Provide project/file name in TypeScript loading indicator (#225643)
* Specify which project is loading at any given time. Provide an indicator for file opens.

* Just use `vscode.workspace.asRelativePath`.

* Remove unused import.
2024-09-18 10:56:50 -07:00
Benjamin Pasero
b218243b76 ts - detect more patterns of disabled node_modules watching 2024-09-18 10:07:16 +02:00
Benjamin Pasero
1fb9bc85a4 ts - refine log when canUseWatchEvents is not used 2024-09-18 10:07:16 +02:00
Benjamin Pasero
e36b6d7d54 ts - log when canUseWatchEvents is not used 2024-09-18 10:07:16 +02:00
Matt Bierner
bd324432e0 Bump default target to es2022 (#228744)
From #227409
2024-09-16 18:07:04 +02:00
Benjamin Pasero
88b706b2bb watcher - support suspend/resume for non-correlated requests (#228703) 2024-09-16 12:24:34 +02:00
Matt Bierner
94d5b2a31e Remove ts-expect-error 2024-09-11 14:49:06 -07:00
hj
88d7b97c93 chore: rm unreached ignore items when build extensions. (#227906)
chore: rm unreached ignore items when compiling extensions.
2024-09-09 10:32:51 +00:00
Benjamin Pasero
6f1101d812 Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS (#227788)
* Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS

* update deps

---------

Co-authored-by: Aman Karmani <aman@tmm1.net>
2024-09-06 16:25:54 +02:00
Robo
b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Benjamin Pasero
7f5d714e41 Revert "Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS" 2024-09-05 12:43:29 +02:00
Aman Karmani
39c063bcc7 Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS 2024-09-04 18:42:01 -07:00
Matt Bierner
3e0761cc9f Fix setting 2024-08-28 14:11:30 -07:00
Matt Bierner
913b9b9a2c Tweak organize imports setting descriptions
For #225814

- Removes link to presets which haven't yet been finalized
- Adds periods at end of descriptions
2024-08-28 13:48:57 -07:00
Matt Bierner
e81aceaa07 Merge pull request #226541 from mjbvz/involved-gopher
Remove allowImportingTsExtensions from created tsconfigs
2024-08-24 14:18:44 -07:00
Matt Bierner
e348be6b66 Remove allowImportingTsExtensions from created tsconfigs
Fixes #226108
2024-08-24 14:00:35 -07:00
Matt Bierner
89f2077c35 Merge pull request #226485 from mjbvz/informal-echidna
Enable ATA on web by default again
2024-08-23 13:30:54 -07:00
Matt Bierner
a8a33390df Merge pull request #226202 from andrewbranch/autoImportSpecifierExcludeRegexes
[typescript-language-features] Add autoImportSpecifierExcludeRegexes preference
2024-08-23 13:23:49 -07:00
Matt Bierner
47fb559c6d Reorder go to source definition (#226212)
Fixes #225419
2024-08-23 13:15:37 -07:00
Matt Bierner
bedf9f4ab7 Enable ATA on web by default again
For #182791

Enabling for further testing
2024-08-23 13:14:54 -07:00
Andrew Branch
7b357dd3a5 [typescript-language-features] Add autoImportSpecifierExcludeRegexes preference 2024-08-21 12:10:36 -07:00
Matt Bierner
2baacda638 Remove presets keys
Fixes #226031
2024-08-20 15:08:00 -07:00
Matt Bierner
aeb66cd959 Merge pull request #209293 from iisaduan/organize-imports-settings
add settings for typescript's organizeImports to the settings interface
2024-08-16 14:38:53 -07:00
Matt Bierner
ddbe321368 Remove presets for now
https://github.com/microsoft/typescript/issues/59579
2024-08-16 13:01:03 -07:00
Matt Bierner
2360f3d014 Merge branch 'main' into organize-imports-settings 2024-08-16 12:55:08 -07:00
Kat Marchán
d751e4324d stop AutoInstallerFs from thrashing forevermore and fix typings installer (#225648)
stop AutoInstallerFs from thrashing forevermore
2024-08-15 18:48:29 -07:00
Matt Bierner
c3fdd34df5 Fix commit character list
We were modifying the default commit character array, which ended up making it thousands of elements long
2024-08-13 14:36:56 -07:00
Matt Bierner
4a4c36209f Remove old jsdoc link handling (#225529)
This code was used when TS Server didn't have support for `@link`. I think we can remove it now
2024-08-13 14:23:40 -07:00
Matt Bierner
a116536a91 Remove TS 3.x feature gates
We see very, very low usage of these old TS versions. We also don't actively test them or fix bugs for them
2024-08-13 11:12:10 -07:00
Matt Bierner
aefef1e336 Add more telemetry for global TS plugins (#225143)
* Add more telemetry for global TS plugins

Log the hashed name of the global TS plugins so we can correlate issues to them

* Remove trailing comma
2024-08-08 19:18:46 -07:00
Matt Bierner
2a045a1bc1 Merge branch 'main' into organize-imports-settings 2024-08-08 11:57:09 -07:00
Gabriela Araujo Britto
6cbbd1012a [typescript-language-features] fix diagnostics telemetry property name (#225079)
fix diagnostics telemetry property name
2024-08-08 11:52:15 -07:00
Matt Bierner
b7e421b734 Fix arguments for create tsconfig/jsconfig (#224990)
Fix arguments for create tsconfig/jsconfig

Fixes #224989

Adds typings too to prevent this again
2024-08-06 16:04:21 -07:00
Matt Bierner
4a532e3376 Use trace logger for ATA file systems (#224892)
Makes enabling logging easier and more consistent
2024-08-05 15:59:10 -07:00
Matt Bierner
a1572d3b7a Try to fix typings perf issues on web (#224640)
Try to fix ata perf issues on web

For #182791

With this change, we now make a single call to the package manager per root instead of per package. This simplifies the code and should be better for perf

Still seeing a bunch of errors in the console but TS typing is working ok. Needs more exploration for ATA
2024-08-02 14:21:22 -07:00
Matt Bierner
fd5f15a2b3 Don't watch in-memory resources (#224535)
Fixes #221583
2024-08-01 17:22:31 -07:00
Anees Ahee
7d0a6b8a0a Fix missing "Restart TS Server" command in Command Palette (#223433)
Update TypeScript context keys when tab groups changed

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-07-30 14:33:33 -07:00
Gabriela Araujo Britto
6a33b7a382 [typescript-language-features] Use commit characters from tsserver when available (#223541)
use commit characters from tsserver when available
2024-07-29 13:57:03 -07:00
Matt Bierner
a105ce80a3 Bump web TS version (#223552) 2024-07-24 15:21:17 -07:00
Matt Bierner
7d59bab235 Add telemetry on how often server crashes are potentially due to TS service plugins (#223551)
Add telemetry on how often server crashes are potentially due to TS server plugins

Simple flag which tracks if plugins are enabled/disabled
2024-07-24 15:20:38 -07:00
Matt Bierner
3202fa61ce Handle bad directory watch on web (#223542)
Fix #221299

toResource throws here because we're tyring to watch directories outside of the workspace root. Should be fixed on TS side. Until them, adding a `catch`
2024-07-24 14:16:29 -07:00
Matt Bierner
ea0d7033cf Properly gate type acquisition on web (#223403)
For #221299

Make sure we don't register the file system at all in these cases
2024-07-23 15:12:34 -07:00
Matt Bierner
febad5e489 Handle empty edits for TS paste (#222109)
Should use default paste in this case. Talking with TS if this should be handled differently from the server but worth adding the workaround for now
2024-07-18 12:34:03 -07:00
Matt Bierner
6eb023ca6f Fix version for web TS (#221992) 2024-07-17 14:41:02 -07:00
Matt Bierner
f4dabd7898 Fix path mapping call on web (#221859)
Fixes #221299

Seems like a TS bug that realpath is called here. This is a workaround for that
2024-07-16 16:30:05 -07:00
Gabriela Araujo Britto
14cf5001ec [typescript-language-features] Add diagnostics performance telemetry (#220127)
* WIP

* invalidate diagnostics in range

* check whether should use region based diagnostics

* add ts-expect-errors

* make region opt off by default

* bump to expected 5.6

* update comments to refer to 5.6

* make region diagnostics on by default for insiders

* add telemetry for diagnostics performance

* add file line count

* remove comment

* use block on case

* add ts-expect-error

* declare interface earlier in file

* address review comments
2024-07-12 17:03:45 +00:00
Martin Aeschlimann
8d13b31708 Remove package.json schema descriptions (#221454) 2024-07-11 02:40:45 -07:00
Matt Bierner
9469c82f9f Don't allow insiders users to report issues with TS plugins enabled (#219902)
Seeing far too many users not reading the warning/issue text before reporting issues. These reports are rarely actionable
2024-07-04 01:12:04 +02:00