Commit Graph

117229 Commits

Author SHA1 Message Date
Aiday Marlen Kyzy
40e68b7fde refactoring hover.ts file 2023-12-06 12:22:42 +01:00
Johannes Rieken
3056f52f92 add failing/skipped test for https://github.com/microsoft/vscode/issues/191070 (#200125)
* fix --dev option of unit tests fyi @joaomoreno

* fix timing issue when getting line, add failing/skipped test for https://github.com/microsoft/vscode/issues/191070
2023-12-06 12:16:49 +01:00
Benjamin Pasero
5455d20ce1 debt - adopt ensureNoDisposablesAreLeakedInTestSuite in more tests (#200116)
* debt - adopt `ensureNoDisposablesAreLeakedInTestSuite` in more tests

* .

* .

* .
2023-12-06 12:09:11 +01:00
Benjamin Simmonds
52ca689ee7 ensureNoDisposablesAreLeakedInTestSuite (#200115)
* ensureNoDisposablesAreLeakedInTestSuite

* 💄
2023-12-06 11:51:56 +01:00
Benjamin Pasero
7ef3fef402 debt - relax product.json type (#200122) 2023-12-06 11:35:51 +01:00
Justin Chen
4693a093c7 Revert: Allow non-AI actions on empty lines (#200097)
reverting ai only code actions on empty lines
2023-12-06 11:13:08 +01:00
Benjamin Pasero
38267ff797 Add the option to skip the prompt to save the workspace config (fix #187794) (#200114)
* wip

* .

* .
2023-12-06 10:08:16 +00:00
Aiday Marlen Kyzy
aec249e46b Merge pull request #200042 from microsoft/aiday/keepHoverOpenWhenAltKeyPressed
Keep the hover open when the alt key is pressed
2023-12-06 10:33:51 +01:00
Tyler James Leonhardt
5196dddde0 Low hanging fruit of onboarding to ensureNoDisposablesAreLeakedInTestSuite (#200100)
ref https://github.com/microsoft/vscode/issues/200091
2023-12-05 21:53:40 -08:00
Chapman Pendery
dc097a8354 refactor: xterm suggestion addon into terminalContrib
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 20:06:52 -08:00
Chapman Pendery
f6994ee8d9 Merge branch 'main' into fix/terminal-suggestion-positioning__accept-completions 2023-12-05 19:40:02 -08:00
Chapman Pendery
ff08ba7712 fix: unused import
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 19:26:58 -08:00
Flanker-MSFT
37b7701535 Simplify the list of libraries for java workspace tagging 2023-12-06 10:15:29 +08:00
Tyler James Leonhardt
42b9e86467 Add quick-chat to grooming notebook (#200094) 2023-12-06 00:34:58 +01:00
Connor Peet
2ee5518dec debug: fix incomplete range in disassembly goToInstructionAndOffset (#200093)
Fixes #197770
2023-12-05 15:21:08 -08:00
Connor Peet
6605df0f11 debug: fix toolbar min y position (#200090)
This was inverted a couple iterations ago during a refactor it looks like.

Fixes #200005
2023-12-05 23:54:52 +01:00
Chapman Pendery
c9079bf7b6 Merge branch 'main' into fix/terminal-suggestion-positioning__accept-completions 2023-12-05 14:49:31 -08:00
Chapman Pendery
69f334db0f fix: feedback by disabling suggestions during accepted completion
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-05 14:48:48 -08:00
Chapman Pendery
4da18252cd fix: feedback
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2023-12-05 14:45:19 -08:00
Connor Peet
16c469a671 eng: add a lint rule for ensureNoDisposablesAreLeakedInTestSuite (#200089)
Adds a lint rule that ensures ensureNoDisposablesAreLeakedInTestSuite
is called in suites. It grandfathers in existing files that were lacking
the call entirely.

This PR also includes manual fixes to files that used the function
already but were missing it in one or more suites, which the lint rule
detects.
2023-12-05 14:35:27 -08:00
Henning Dieterichs
4728954baa Fixes #178245 2023-12-05 23:14:19 +01:00
Benjamin Pasero
56fda3234c Windows: "Reopen" after crash does not work with 1 window opened (fix #199960) (#200075) 2023-12-05 14:13:44 -08:00
Connor Peet
0d42a76e2f debug: fix call resolveDebugConfigurationWithSubstitutedVariables with redirected type (#200080)
* cli: allow reading exec server token from env variable

* debug: fix call resolveDebugConfigurationWithSubstitutedVariables with redirected type

Fixes #188979
2023-12-05 14:05:26 -08:00
Megan Rogge
0ca618d59d Merge pull request #200086 from microsoft/merogge/activity-bar-left
update focus on left/right arrow
2023-12-05 15:25:25 -06:00
netcon
703e21214e fix: workbench.editorAssociations not work in workbench configurationDefaults (#194087) 2023-12-05 22:21:18 +01:00
meganrogge
4a7480c147 update focus on left/right arrow 2023-12-05 15:10:00 -06:00
Connor Peet
cc62bd1ddd cli: allow reading exec server token from env variable (#200079) 2023-12-05 21:38:10 +01:00
Daniel Imms
88defdf993 Merge pull request #200076 from microsoft/tyriar/179483
Respect early returns from pre-existing bash debug traps
2023-12-05 12:08:09 -08:00
Daniel Imms
f055b9b8b2 Respect early returns from pre-existing bash debug traps
Fixes #179483
2023-12-05 11:52:29 -08:00
Henning Dieterichs
58a122e39b Fixes https://github.com/microsoft/monaco-editor/issues/2556 2023-12-05 20:47:01 +01:00
Joyce Er
d70a46b6bd chore: update grooming notebook labels (#200070) 2023-12-05 20:01:33 +01:00
Megan Rogge
8b45297716 Merge pull request #200067 from microsoft/merogge/arrow-keys
get hover to show when navigating between ActionBar sections with arrow keys
2023-12-05 12:50:19 -06:00
meganrogge
42720590a9 Fix hover showing when navigating between ActionBar sections 2023-12-05 12:32:58 -06:00
Henning Dieterichs
8407e97b5b Fixes #193640 2023-12-05 18:59:53 +01:00
Johannes Rieken
f746843c72 update diff when document changes but don't auto-accept change regions (#200061)
https://github.com/microsoft/vscode-copilot/issues/3206
2023-12-05 18:59:17 +01:00
Benjamin Pasero
455ca664b9 working copy - enable file limits when resolving (#172129) (#200009)
* working copy - enable file limits when resolving (#172129)

* .
2023-12-05 18:56:59 +01:00
Johannes Rieken
7cd710eefe make sure vscode.executeDocumentHighlights return an array (#200062)
re https://github.com/microsoft/vscode/issues/200056
2023-12-05 09:45:49 -08:00
Andrea Mah
4b6c84ef9c add css.format.spaceAroundSelectorSeparator: true to the workspace and add spacing around > (#199993) 2023-12-05 09:35:36 -08:00
Johannes Rieken
cafbf86532 add failing/skipped test for https://github.com/microsoft/vscode/issues/187055 (#200055) 2023-12-05 18:00:28 +01:00
Henning Dieterichs
ea0e5cda39 Fixes #192440 2023-12-05 17:57:38 +01:00
Aiday Marlen Kyzy
059167ccc7 commiting the changed monaco.d.ts file 2023-12-05 17:12:26 +01:00
Aiday Marlen Kyzy
1bd5250a1d doing the checks inside of the onKeyDown and onKeyUp listeners 2023-12-05 17:08:20 +01:00
Aiday Marlen Kyzy
0f4f9da9d4 added the property toggle locked and added an outline when the alt key is pressed 2023-12-05 16:57:25 +01:00
Daniel Imms
85b1ab9a53 Merge pull request #200052 from microsoft/tyriar/200050
Warn on opaque needsTransparency colors, expose to workbench
2023-12-05 07:35:59 -08:00
Daniel Imms
c733e05d94 Adopt needsTransparency in terminal 2023-12-05 07:20:39 -08:00
Daniel Imms
93c589cfc6 Use a generic error message 2023-12-05 07:17:25 -08:00
Aiday Marlen Kyzy
712137c205 checking the effective line count is valid before accessing the line content 2023-12-05 16:15:00 +01:00
Daniel Imms
5202e7bd7b Warn on opaque needsTransparency colors, expose to workbench
fixes #200050
2023-12-05 07:14:01 -08:00
Alex Ross
b0d60e8e2e Add the new Less grammar back in (#200043)
This reverts commit 95c05bf57b.
2023-12-05 15:17:02 +01:00
Joyce Gu
af8451a41e add JS Vector DB libraries (#199980)
add Vector DB libraries
2023-12-05 14:11:06 +00:00