Commit Graph

289 Commits

Author SHA1 Message Date
Daniel Imms
5db496f7cf Fix strictFunctionTypes in terminal proc
Part of #81574
2019-10-22 09:30:00 -07:00
Johannes Rieken
9f474febfe implement API proposal 2019-10-22 16:48:12 +02:00
Matt Bierner
d6ab43118d Create WebviewExtensionDescription in extHostProtocol 2019-10-17 10:50:34 -07:00
Matt Bierner
721886ce10 Allow registerWebviewEditorProvider to pass in a set of initial webview options
Fixes #82128
2019-10-17 10:50:34 -07:00
Matt Bierner
48195455a1 Remove the setExtension helper
Instead pass over the extension when resolving the extension itself
2019-10-15 11:31:24 -07:00
Joao Moreno
d9e93a7067 Merge branch 'joao/fix-82264' 2019-10-15 13:03:24 +02:00
Daniel Imms
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
This reverts commit 7f5a4a3f5b.
2019-10-13 10:55:54 -07:00
Joao Moreno
4a81920398 Revert "scm: make tree rendering opt-in via proposed API"
This reverts commit afa911d942.
2019-10-11 19:10:27 +02:00
Joao Moreno
afa911d942 scm: make tree rendering opt-in via proposed API
fix #82203
2019-10-10 18:37:38 +02:00
Johannes Rieken
50c2639b86 Merge branch 'joh/strict' 2019-10-07 08:30:19 +02:00
Daniel Imms
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Johannes Rieken
c06c223ee9 more strict init work 2019-10-04 11:52:05 +02:00
Matt Bierner
8079ff0001 Rename resolveExternalUri to asExternalUri
#81131
2019-09-30 14:22:47 -07:00
Johannes Rieken
111c29c085 Merge pull request #80895 from mjbvz/use-const-enums-for-suggest-dto
Use const enums for minimized ISuggestDataDto field names
2019-09-30 15:34:48 +02:00
Alexandru Dima
45a92a4937 wip 2019-09-30 15:19:07 +02:00
Matt Bierner
e0762af258 Move webview content state into webviewPanel instead of webviewEditor
Split out from #77131

The current webview editor api is very procedural. This model has some problems when it comes to supporting editing resources, but actually does make a lot of sense for webviews that aren't backed by real file system resources. For example, if you have a webview that edits some document in the cloud, you should not be required to implement a custom file system provider just to enable basic saving.

This change moves the `onWillSave` and `webviewEditorState` properties back onto `WebviewPanel` instead of keeping them specific to `WebviewEditor`. The save implementation does not fully work yet, as the will require #81521
2019-09-26 18:05:37 -07:00
Benjamin Pasero
64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00
Matt Bierner
0506f7f736 Make sure image views (and custom editors) work properly on the web
This fixes an issue where webviews for custom editors did not have any associated extension information, which caused them try reading `file:` uri resources instead of remote uri resources
2019-09-25 16:25:39 -07:00
Alexandru Dima
7e4991aa33 WIP 2019-09-25 17:49:27 +02:00
Matt Bierner
a62b7dabe7 Make resolveExternalUri return just a plain uri instead of a disposable result
For #81131

We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
2019-09-23 10:58:21 -07:00
Matt Bierner
a817a588c7 Moving resolve uri logic into openerService
- Add a resolveExternalUri function to the opener service. This service already has to know how to resolve external uris so it makes sense that the function lives there

- Move the tunneling logic for desktop into window.ts

- Make result of resolve disposable
2019-09-20 17:17:42 -07:00
isidor
a9c67d8b82 extHost startDebugging minor polish 2019-09-19 16:08:52 +02:00
Isidor Nikolic
c4a6fc1078 Merge pull request #80673 from dgozman/fix-62419
Allow debug session to share repl with its parent; fixes #62419
2019-09-19 16:05:08 +02:00
Christof Marti
715b6c5792 Add extension id that triggered the activation event 2019-09-19 09:42:17 +02:00
Matt Bierner
27bac598cc Basic implementation of resolveExternalUri 2019-09-18 18:20:26 -07:00
Dmitry Gozman
e4d4b43f35 Allow debug session to share repl with its parent; fixes #62419
Introduced DebugSessionOptions passed to debug.startDebugging which
encapsulated DebugConsoleMode to control this behavior.
2019-09-18 11:45:39 -07:00
Sandeep Somavarapu
7ccfc2dcc5 remove user data api implementation 2019-09-18 12:21:34 +02:00
Sandeep Somavarapu
b44a8ca309 move user data sync store to workbench 2019-09-17 16:56:44 +02:00
Sandeep Somavarapu
5cc29271b5 Introduce id and user data sync store registry 2019-09-17 16:25:06 +02:00
Sandeep Somavarapu
8fbdeb724b move user data sync services to platform 2019-09-16 17:30:47 +02:00
Alex Ross
1c01ce84b5 Refactor extHostTask (#80970)
so that most of it is in common
2019-09-16 12:09:14 +02:00
Sandeep Somavarapu
317ed7e1a5 Merge branch 'master' into sandy081/userDataProvider 2019-09-15 19:52:27 +02:00
Matt Bierner
4546a07196 Working on basic save for custom editors 2019-09-13 22:24:35 -07:00
Matt Bierner
14ae1247f8 Use const enums for minimized ISuggestDataDto types
From #71060

**Problem**
ISuggestDataDto currently uses opaque property names in order to keep the size of the json object down. This makes the code difficult to read

**Proposed Fix**
Use a const enum to map human readable property name to the short names actually used for the json
2019-09-13 16:14:08 -07:00
Benjamin Pasero
f8effd5fad api - introduce env.uiKind (web, desktop) 2019-09-13 17:58:30 +02:00
Johannes Rieken
cf88c7f310 retry command exec when having arguments, when contributes, and not yet activated, #80338 2019-09-13 08:50:12 +02:00
Daniel Imms
678abfe8b2 Remove Terminal.onDidWriteData
Replaced by vscode.window.onDidWriteTerminalData

Fixes #78574
2019-09-12 19:09:12 -07:00
Matt Bierner
7a219ab632 Adding concept of a state for webview editors
#77131

This information will be used to show the dirty indicator and also enable/disable save
2019-09-12 14:04:54 -07:00
Sandeep Somavarapu
88e5a183ae Use ref instead of version 2019-09-12 16:17:05 +02:00
jrieken
6fc8778fdc calls - add CallHierarchyItem to type converter 2019-09-12 13:34:45 +00:00
jrieken
4aa06c2611 calls - remove resolve-function, use document,position tuple when making requests 2019-09-12 10:13:20 +00:00
Johannes Rieken
a97b843f27 Merge pull request #80713 from microsoft/joh/api/callHierarchy2
Call hierarchy API proposal
2019-09-11 15:37:16 +02:00
jrieken
8e5edc0eda use Outgoing/Incoming terminology 2019-09-11 13:25:53 +00:00
Sandeep Somavarapu
65f14490b7 Merge branch 'master' into sandy081/userDataProvider 2019-09-11 13:42:07 +02:00
Alex Ross
462a8be7d4 Add title API for tree views (#80623)
* First pass at set view title

* Change to get/set instead of setTitle

and get the name of the view from the extension contributions
2019-09-11 10:56:45 +02:00
jrieken
e6df99aed8 implement CallsFrom/CallsTo proposal 2019-09-11 08:01:13 +00:00
Matt Bierner
011836a150 Prototyping custom editors (#77789)
* Custom Editor exploration

For #77131

Adds a prototype of custom editors contributed by extensions. This change does the following:

- Introduces a new contribution point for the declarative parts of a custom editor
- Adds API for registering a webview editor provider. This lets VS Code decided when to create a webview editor
- Adds an `openWith` command that lets you select which editor to use to open a resource from the file explorer
- Adds a setting that lets you say that you always want to use a custom editor for a given file extension
- Hooks up auto opening of a custom editor when opening a file from quick open or explorer
- Adds a new extension that contributes a custom image preview for png and jpg files

Still needs a lot of UX work and testing. We are also going to explore a more generic "open handler" based approach for supporting custom editors

Revert

* Re-use existing custom editor if one is already open

* Don't re-create custom editor webview when clicking on already visible custom editor

* Move customEditorInput to own file

* First draft of serializing custom editor inputs

* Use glob patterns instead of simple file extensions for matching custom resoruces for custom editors

* Add descriptions

* Try opening standard editor while prompting for custom editor

* Make sure we hide image status on dispose

* Make sure we restore editor group too

* Use glob patterns for workbench.editor.custom

* Allow users to configure custom editors for additional file types

* Use filename glob instead of glob on full resource path

* Adding placeholder for prompt open with

* Add enableByDefault setting for editor contributions

* Enable custom editors by default and add `discretion` enum

Changes `enableByDefault` boolean to a `discretion` enum. This should give more flexibility if we want other options (such as forcing a given custom editor to always be used even if there are other default ones)

* Allow custom editors to specify both a scheme and filenamePattern they are active for

* Rework custom editor setting

* Don't allow custom editors to be enabled for all resources by a config mistake

* Replace built-in image editor with one from extension

* Adding reopen with command

* Improve comment

* Remove commented code

* Localize package.json and remove image

* Remove extra lib setting from tsconfig
2019-09-10 17:56:57 -07:00
Sandeep Somavarapu
cae7f1c4b9 Merge branch 'master' into sandy081/userDataProvider 2019-09-10 15:17:32 +02:00
Sandeep Somavarapu
c26e198c9c settings sync using remote user data service 2019-09-10 15:16:57 +02:00
Alex Ross
ca4c1bf7a0 Go to ext host for system default shell and args for tasks
Fixes https://github.com/microsoft/vscode-remote-release/issues/1203
2019-09-05 14:59:08 +02:00