Commit Graph

19 Commits

Author SHA1 Message Date
Copilot
6ec82f00c8 Fix GitHub workflows to check file changes before user permissions (#250083)
* Initial plan for issue

* Fix workflow to check file changes before user permissions

Reorder workflow steps to first check if package-lock.json/Cargo.lock files
are modified, then only check user permissions if lockfiles were changed.
This prevents the workflow from failing when Copilot opens PRs that don't
modify lockfiles.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Fix yarn.lock workflow to check file changes before user permissions

Apply the same fix to the yarn.lock workflow that was applied to the
package-lock workflow. This prevents failures when Copilot opens PRs
that don't modify yarn.lock files.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Add explicit Copilot check to prevent lockfile modifications

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
2025-05-30 00:39:27 +00:00
Raymond Zhao
15807c660e chore: start locking down workflows (#248544) 2025-05-09 20:22:00 +02:00
Robo
b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Robo
85ca721d8f ci: temporarily prevent lock file changes for npm transition (#227570) 2024-09-05 10:05:51 +09:00
Connor Peet
44d1d6a39c build: check for cargo.lock changes in pr too (#187481)
* build: check for cargo.lock changes in pr too

* keep old name
2023-07-10 10:19:55 -07:00
Ladislau Szomoru
ea2307487e Engineering - fix yarn.lock github action (#184332) 2023-06-05 15:48:40 +02:00
Jongwoo Han
e4b995061d Replace deprecated set-output command with environment file (#172691)
Replace deprecated command with environment file

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
2023-01-31 11:23:08 +00:00
João Moreno
6bb9322977 Allow dependabot to make yarn.lock changes (#153240)
allow dependabot to make yarn.lock changes
2022-06-26 11:52:40 -07:00
João Moreno
269025c30b hmm 2021-04-07 09:07:48 +02:00
João Moreno
219509dc2d fix yarn lock check 2021-04-07 09:04:14 +02:00
João Moreno
baeae37965 correctly use outputs 2021-04-06 17:42:57 +02:00
João Moreno
c123695312 fix syntax error 2021-04-06 17:41:22 +02:00
João Moreno
4790696ccc bring back task output 2021-04-06 17:40:17 +02:00
João Moreno
07dab53ae1 more yarn lock changes 2021-04-06 17:31:06 +02:00
João Moreno
dfafa70dce add debug to yarn lock task 2021-04-06 17:28:00 +02:00
João Moreno
639a32f909 Make sure yarn.lock changes are allowed for committer PRs (#120642)
* hmm

* get perms

* hmm

* oops

* hmm

* cleanup
2021-04-06 08:23:01 -07:00
João Moreno
fb46801cf2 lock file-changes-action 2021-03-04 16:08:57 +01:00
João Moreno
70cd3b36ba fix yarn lock changes names 2021-02-05 10:03:30 +01:00
João Moreno
76e6174c90 validate yarn.lock changes in PRs 2021-02-02 16:50:58 +01:00