Commit Graph

1534 Commits

Author SHA1 Message Date
Daniel Rosenwasser
182beb6ee4 Merge pull request #163498 from DanielRosenwasser/iconsForWalkthroughs
Allow walkthroughs to specify icons.
2022-10-19 11:26:51 -07:00
Matt Bierner
7f99b7c655 Remove references to finalized proposals in js/ts (#164040) 2022-10-19 13:23:48 -04:00
Matt Bierner
33378c2ec0 Fix organize imports (#164035)
Fixes #163994

This fixes the organize imports command (it was using the wrong id) and also cleans up the implementation
2022-10-19 09:27:41 -07:00
Andrew Branch
1fb956d2f5 [typescript-language-features] Add removeUnusedImports command (#161654)
* Add `removeUnusedImports` command

* Continue to send `skipDestructiveCodeActions` for older TS versions

* Expose Sort Imports and Remove Unused Imports commands

* Update localization keys

* Update for 4.9 protocol

* Proto must be type only import?
2022-10-18 09:00:16 -07:00
Matt Bierner
186d3415a3 Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Jake Bailey
65a9097aa2 Remove forgoten reference to typescript/lib/protocol (#163585) 2022-10-13 13:15:13 -07:00
Daniel Rosenwasser
a053a4d505 Allow walkthroughs to specify icons.
Useful for specifying icons *other* than those of the contributing extension.
2022-10-12 17:14:42 -07:00
Jake Bailey
07b87405e7 Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Suven-p
22ff985c19 Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Tyler James Leonhardt
4322170fd8 comment is an array (#163348) 2022-10-11 13:39:12 -07:00
Matt Bierner
3ee9749b35 Remove extra enums (#162686)
`showMessage` returns the selected item, so we don't need to create an enum here and can instead used the returned items directly
2022-10-04 10:46:53 -07:00
Tyler James Leonhardt
29e985eca0 rev vscode-nls to version that doesn't ask for vscode-nls-web-data (#161819)
ref #161297
2022-09-26 11:10:54 -07:00
Gerrit Birkeland
cace09d0eb Add schema for typedoc.json to default jsonValidation (#157592)
Add schema for typedoc.json to default 
jsonValidation
2022-09-26 15:51:42 +02:00
Daniel Rosenwasser
da506e9b8d Tag existing events with experimentation info in typescript-language-features (#161463)
* Associate experiment info with existing telemetry.

* Move the ExperimentTelemetryReporter to its own file.

* Roughly copied the 'getPackageInfo' function from other extensions.

* Addressed code review feedback.
2022-09-23 15:18:57 -07:00
Matt Bierner
f25d47121b Pick up newer vscode-tas-client version (#161344) 2022-09-20 13:52:29 -07:00
Daniel Rosenwasser
5cde74b767 Fix accidental case fallthroughs in experimentation services. (#161339) 2022-09-20 12:00:32 -07:00
Johannes Rieken
77309b33d4 add WorkspaceEditMetadata and use it for applyEdit, (#160996)
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
2022-09-16 09:44:19 +02:00
Matt Bierner
3c37a5a8d7 Reapply JavaScript and Node.js walkthrough (#161003)
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
2022-09-15 13:02:43 -07:00
Daniel Rosenwasser
9dfd49db63 Ensure ExperimentationService gets disposed. (#161004) 2022-09-15 11:06:53 -07:00
Benjamin Pasero
cfc0119755 Revert "JavaScript and Node.js walkthrough" (#160959)
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
2022-09-15 08:26:22 +02:00
Daniel Rosenwasser
0cbcb1b1ab JavaScript and Node.js walkthrough (#157965)
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:53:37 -07:00
Daniel Rosenwasser
00902daee1 Instantiate ExperimentationService in typescript-language-features. (#160877)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-14 09:34:04 -07:00
Matt Bierner
1d500fb4de Add CodeActionKind.RefactorMove (#160730)
Fixes #160728
2022-09-12 15:14:06 -07:00
Matt Bierner
c4722f1bb2 Write markdown link setting change to correct scope (#159816)
Fixes #159084

Also fixes the same issue for JS/TS
2022-09-02 13:38:41 +10:00
Matt Bierner
c9a97b5581 Pick up TS 4.8 final (#159238)
Fixes #157527
2022-08-26 01:30:07 +02:00
Matt Bierner
129f5bc976 Use own calls to localize (#158372)
Fixes #156684
2022-08-17 10:27:29 -04:00
Tyler James Leonhardt
d8453c0440 Rev built-in versions of vscode-nls to 5.1.0 (#157530)
* rev version of vscode-nls to 5.1.0

* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt
49394cc44d Enable translations for extension code for the web (#155355)
* Initial attempt

* alex feedback
2022-08-08 09:11:16 -07:00
Matt Bierner
0c78644c6e Use tabs to figure out when to report JS/TS diagnostics (#157117)
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
2022-08-04 10:46:56 -07:00
Matt Bierner
424fe151f1 Add patch for enabling new TS plugins on web approach (#149186)
* Add patch for enabling new TS plugins on web approach

https://github.com/microsoft/TypeScript/pull/47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR

* Update for new files names
2022-08-02 20:00:22 +02:00
Matt Bierner
f0434c0960 Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Matt Bierner
97c8a97261 Include globally enabled TS Server plugins when reporting issues (#156510)
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
2022-08-01 10:44:46 -07:00
Matt Bierner
4eef7a94e1 Tell users about enabled TS plugins on crash (#156514)
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
2022-08-01 10:44:33 -07:00
Matt Bierner
06f8d52e37 Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Matt Bierner
00bb9bdefc Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
ryuurock
42e79ca270 Update typescriptServiceClient.ts, fix naming errors (#155946)
Update typescriptServiceClient.ts

fix naming errors
2022-07-22 17:46:48 +00:00
Logan Ramos
a20329d291 Switch extensions to 1DS (#154299)
* Move extensions to 1DS

* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Andrew Branch
1d16e313d6 [typescript-language-features] Add setting for autoImportFileExcludePatterns (#153160)
* Add setting for autoImportFileExcludePatterns

* Add TS 4.8 to message
2022-06-28 16:43:24 -07:00
Matt Bierner
c16036705e Initial contents for experimentation in typescript-language-features. (#153358)
Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
2022-06-27 12:53:24 -07:00
Matt Bierner
9051021473 Clarify label on source action (#153356)
Clairify label on source action

For https://github.com/microsoft/vscode-eslint/issues/1428
2022-06-27 19:01:41 +00:00
Logan Ramos
4a7a6a597a Update extension telemetry modules (#153057) 2022-06-24 00:53:23 +00:00
Daniel Imms
f0cf1ea129 Fix initial compilation problem matching in tsc-watch
Fixes #152966
2022-06-23 04:48:25 -07:00
Matt Bierner
8559324b09 Use more optional chaining in TS extension (#152271)
Use optional chaining in TS extension

Also removes `prefer-const` since this is now enabled globally
2022-06-16 05:33:58 +02:00
Matt Bierner
a289e64e09 Switch to finalized TS protocol types (#152259) 2022-06-15 15:37:21 -07:00
Matt Bierner
8fb977f2c1 Make jsx: react the default for implicit js/ts projects (#152256)
Make jsx: react the default

Fixes #152150

This fixes imports of `react` getting removed with TS 4.7 in implicit projects
2022-06-15 21:41:52 +00:00
Andrew Branch
5a32c3ff17 [typescript-language-features] Pass through all typescript.unstable.* settings (#151472)
Pass through all `typescript.unstable.*` settings
2022-06-08 11:53:06 -07:00
Matt Bierner
e44f4ba886 Add experimental tag to experimental extension settings (#151031)
This makes a few more extension settings with the `experimental` tag so that show up if you search `@tag:experimental`
2022-06-01 16:32:58 -07:00
Matt Bierner
6428d0fc7d Support TS's includeInlayVariableTypeHintsWhenTypeMatchesName setting (#150489)
From https://github.com/microsoft/TypeScript/pull/48529

Let users control is variable type inlay hints are suppresed if the variable name matches the type name, such as:

```ts
const range = new Range();
```
2022-05-26 16:00:04 -07:00
Logan Ramos
3a8b1fe03e More telemetry comments (#150303)
* Add owners to all telemetry events

* More comments

* Add comments to non typescript GDPR annotation

* Another comment
2022-05-24 16:00:55 -07:00
Matt Bierner
6bd7605ae1 Enable strictNullChecks for implicit projects (#149844)
Mistakenly enabled checkJS instead of strictNullChecks
2022-05-18 10:47:37 -07:00