Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity
115,182 Commits 3,682 Branches 359 Tags
1986bdaa0e3bfc58ff4e73289ca9dec7d9f4ac51
Commit Graph

57 Commits

Author SHA1 Message Date
Aiday Marlen Kyzy
f7f8fea209 Merge pull request #187698 from microsoft/aiday/limitingWidthOfHover 
Limiting the width of the content hover to the content inside
 2023-08-14 14:28:14 +02:00
meganrogge
081ebb4f8d fix #190261 2023-08-11 11:52:49 -07:00
Alex Dima
684270ac2e Use consistent names for variables, fall back to defaults when wrapping is on 2023-08-11 17:39:24 +02:00
Alexandru Dima
6e7ea55068 Merge branch 'main' into aiday/limitingWidthOfHover 2023-08-11 17:17:07 +02:00
meganrogge
11d72d9f1b only apply hint if enabled 2023-08-10 14:53:29 -07:00
meganrogge
bc1404e5db fix issues, describe disable action when the view is opened not on the prior element 2023-08-04 14:35:09 -07:00
meganrogge
deb3011d37 move it elsewhere, add other code 2023-08-04 13:59:24 -07:00
Aiday Marlen Kyzy
398e46ca68 Make content hover text use full possible width (#187597) 
* combinging the setting of max dimensions on the container and on the contents dom node

* adding the css variable in order to be able to specify the max width of the content inside

* cleaning the code

* changing the name of the variable

* cleaning the code

* placing the hover max width variable into the others category of vscode-known-variables json file

* defining a fall back value of 500 pixels

* inlinging the code

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
 2023-07-26 08:54:48 +02:00
Aiday Marlen Kyzy
e1becd2eb8 cleaning the code, it works now 2023-07-12 12:49:48 +02:00
Aiday Marlen Kyzy
2c43a89349 remove the extra 2023-06-21 11:41:07 +02:00
Aiday Marlen Kyzy
977962b3c6 removing the additional semi-colon 2023-06-21 11:39:47 +02:00
Aiday Marlen Kyzy
6e34da57e7 keeping the size the same for the hover widget 2023-06-21 10:52:08 +02:00
Aiday Marlen Kyzy
8755ad6c02 removing the css changes that have been previously done and setting the z-index to 50 on the hover widget 2023-06-20 11:51:39 +02:00
Aiday Marlen Kyzy
5a927a75b2 adding review chanegs 2023-06-19 13:47:04 +02:00
Aiday Marlen Kyzy
2b65bd25e7 adding .monaco-hover inside of the CSS 2023-06-19 13:23:42 +02:00
Aiday Marlen Kyzy
c49aa40ebf cleaning the code 2023-06-12 11:48:11 +02:00
Aiday Marlen Kyzy
e7b44978da changing pixel sizes, need to further improve pixel sizes 2023-04-04 13:54:05 +02:00
Aiday Marlen Kyzy
cb0687b0c9 adding code for enabling the correct sashes 2023-04-03 16:28:31 +02:00
Aiday Marlen Kyzy
f6fc0742ac creating a generic resizable content widget type which can be used to implement the resizable hover and the resizable suggest widget 2023-03-31 15:57:45 +02:00
Daniel Imms
4dfdf2adf0 Improve hover behavior when not enough space 
This changes the hover's position fallback logic from:

If not enough room on right
  Position left
If not enough room on left
  Position right

To:

If not enough room on right
  If enough room on left
    Position left
  Else
    Position below
If not enough room on left
   If enough room on right
     Position right
   Else
     Position below

A new option showHoverHint is also added as part of this which will show a hint
to the user to hold alt/option in order to mouse over the hover (only when the
evaluated hover is true). This is an explicit setting such that it doesn't show
up on hovers such as the activity bar which looks awkward.

Fixes #176704
 2023-03-28 15:04:27 -07:00
Henning Dieterichs
2352e26dd0 Fixes #172150 (#172382) 2023-01-25 14:25:43 +01:00
Daniel Imms
9994a1786a Polish hover header line-height and margin 
Fixes #143883
 2022-12-16 14:31:40 -08:00
Raymond Zhao
959c8b024c Improve hover accessibility (#167749) 
- Search entire hover container when adding focus trap
- Change keyup to keydown event to activate hover action links properly
 2022-11-30 17:50:54 +00:00
Johannes Rieken
b3523bc5ca joh/external marlin (#165336) 
* move typeHierarchyPeek onto CSS variables

* move symbolIcons onto CSS variables

* move markerHoverParticipant onto CSS variables
 2022-11-03 13:35:34 +01:00
Matt Bierner
66f4467936 We no longer support old versions of edge that use these (#159723) 2022-09-14 22:43:36 +02:00
Henning Dieterichs
07447e8191 Improves keyboard accessibility in hovers. 2022-02-23 19:33:17 +01:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Dima
be5b4fc06b Fixes #69391: Reserve extra bottom padding when the hover has a horizontal scrollbar 2022-01-27 13:58:01 +01:00
Daniel Imms
c2b59954cb Add cursor pointer style to hover 
Not sure what caused this regression but this seems like a safe fix

Fixes #139535
 2021-12-20 11:15:08 -08:00
Henning Dieterichs
d477eb1ee3 Fixes #137512 by removing the href to #. 
Because the handler uses MOUSE_DOWN rather than CLICK, prevent default does not have the desired effect. The navigation causes a zoom reset.
 2021-11-30 17:27:04 +01:00
Henning Dieterichs
d917029918 Uses EventType.MOUSE_DOWN instead of EventType.CLICK so that high frequent clicks work properly. Fixes #133517. 2021-09-21 13:03:47 +02:00
Johannes Rieken
61e2a76157 render text and details, only detail supports mini-md 2021-08-20 16:48:17 +02:00
Johannes Rieken
d6a31ab3b0 no hover padding when showing html element contents, fyi @Tyriar 2021-08-19 17:11:52 +02:00
Matt Bierner
494cbbd02d Organize imports in vs/base 2021-08-04 12:28:27 -07:00
Sandeep Somavarapu
ef55a57968 Fix #127903 2021-07-21 11:31:15 +02:00
Henning Dieterichs
7cd9352928 Only enable next/previous actions when there are multiple suggestions. Fixes #125296. 2021-06-10 15:26:54 +02:00
Henning Dieterichs
1bab611b73 Sets user-select: none to the hover actions so they cannot be selected anymore. 2021-06-01 17:58:39 +02:00
Sandeep Somavarapu
61364b0492 introduce hover position and align hover and pointer 2021-04-22 01:03:26 +02:00
Daniel Imms
dfc8f1fd03 Move back to min-width for hover hr 
Fixes #119374
Caused by #96795
 2021-04-14 13:02:16 -07:00
Alexandru Dima
1e0f94f900 Fixes #114468 2021-01-22 15:07:58 +01:00
jeanp413
3ed456050c Fixes #111572 2021-01-19 15:30:03 -05:00
Alexandru Dima
61c6334a3f Fixes #112373: The hover should always consume mouse wheel events 2021-01-11 17:42:13 +01:00
Zuckjet
a2963771d1 hover info should not be broken within word (#106885) 
Fix #105630
 2020-11-07 15:01:44 -08:00
Alex Ross
60f19d5939 Fix code hover span margin 
Fixes #107849
 2020-10-01 14:55:35 +02:00
Alex Ross
b7d2879695 Add bottom margin to spans in hovers (#107442) 
Fixes #101496
 2020-09-28 11:35:23 +02:00
Dirk Baeumer
164e7ed900 Fixes #98982: Horizontal rule in hover renders slightly off 2020-06-04 20:45:21 +02:00
Alex Dima
6c49bbf9e8 Move out layer breaking class names 2020-05-14 21:41:09 +02:00
Alex Dima
88bcf236cf Rename .monaco-editor-hover to .monaco-hover 2020-05-14 21:37:23 +02:00
Alex Dima
12628f1e2b Rename base file 2020-05-14 21:34:59 +02:00
Alex Dima
0bdb7009d8 Rename HoverWidget.domNode to HoverWidget.contentsDomNode 2020-05-14 21:33:26 +02:00