Commit Graph

782 Commits

Author SHA1 Message Date
Johannes Rieken
1994ebabef tweak inline chat hint (#234821)
* make editor readonly and disable squiggle while inline chat shows reply

https://github.com/microsoft/vscode/issues/226160

* tweak inline chat hint

only show on intented empty lines, hide when command run

* fix tests (only disable squiggle, not readonlyness)
2024-11-28 12:58:47 +01:00
Johannes Rieken
180a8271e1 fixes https://github.com/microsoft/vscode/issues/234541 (#234826)
make sure to hide the widget before model is disposed, make sure chat widget cleans up the tree (disposed model) despite being hidden
2024-11-28 12:46:11 +01:00
Johannes Rieken
5555f6604d inline hint for empty lines, right-click to hide, differentiate between empty line and suffix hint (#234773) 2024-11-27 09:08:40 -08:00
Johannes Rieken
0401bcef46 render rerun message for detected commands with actions (#234747)
https://github.com/microsoft/vscode-copilot/issues/10751

fyi @joyceerhl this fixes an issue where detected commands weren't advertised as such
2024-11-27 12:12:16 +01:00
Johannes Rieken
87c9dd0bc2 don't apply edits from error'ed result when returning to a file (#234736) 2024-11-27 10:48:36 +01:00
Johannes
f4bc95ae4f fix https://github.com/microsoft/vscode-copilot/issues/10096 2024-11-26 11:31:43 +01:00
Johannes Rieken
ebe6e7f4f2 hide squiggles when showing inline chat hint for a line (#234599) 2024-11-25 18:57:47 +01:00
Johannes Rieken
deda781591 add missing tooltip (#234551) 2024-11-25 11:40:53 +01:00
Johannes Rieken
a43f284857 tweak inline chat hint (#234544) 2024-11-25 11:15:03 +01:00
Johannes Rieken
eddef09fa7 renderer side inline hint and cmd to show/hide (#234421) 2024-11-22 15:36:09 +01:00
Rob Lourens
eeec4c35ab Persist selected chat model globally, not per-workspace (#234335)
* Persist selected chat model globally, not per-workspace

* Cleanup
2024-11-21 12:05:23 +01:00
Johannes Rieken
94b3d8ec53 fix https://github.com/microsoft/vscode/issues/234077 (#234093) 2024-11-18 13:09:39 +01:00
Johannes Rieken
7acb009143 set upper bounds for chat exec toolbar when space is narrow (#234092)
re https://github.com/microsoft/vscode/issues/233004
2024-11-18 04:05:13 -08:00
Benjamin Pasero
8a50c5f429 chat - cleanup global chat menu 2024-11-15 08:36:33 +01:00
Johannes Rieken
5261d038a7 don't use controller's viewstate management but use storage service directly, (#233589)
fixes https://github.com/microsoft/vscode-copilot/issues/10315 and other bugs
2024-11-11 16:29:39 +01:00
Johannes Rieken
3d0a897d29 chore - small clean-up (#233571) 2024-11-11 03:16:00 -08:00
Johannes Rieken
f9a75f1418 inline chat fixes (#233566)
* take decorationWidth into account when layouting chat zone

https://github.com/microsoft/vscode/issues/233561

* chat - fix input height computation when resizing editor
2024-11-11 11:42:18 +01:00
Joyce Er
137b2a6c17 fix: don't roll back edits if response hit length limit (#233378)
fix: don't roll back to snapshot if response hit length limit
2024-11-07 17:46:21 -08:00
Johannes Rieken
c0029b6c06 remove some dead code (#233334) 2024-11-07 16:05:06 +01:00
Johannes Rieken
d5bdaaa0c0 full width inline zone (#233215)
fixes https://github.com/microsoft/vscode/issues/233201#issuecomment-2460048937
2024-11-06 17:04:12 +01:00
Matt Bierner
c0d93f1e55 Only sync chat code blocks with extensions once complete (#232536)
Fixes #230326
2024-11-06 01:17:05 +01:00
Joyce Er
8327a80a6c fix: Send and Dispatch should be Send in chat editing view (#233117) 2024-11-05 10:36:37 -08:00
Johannes Rieken
3ee667af42 allow wider width, fix an issue with dropped resized height (#232814)
* remove dead code

* allow wider width, fix an issue with dropped resized height
2024-11-01 05:20:23 -07:00
Johannes Rieken
702e6b8155 inline chat should not bleed into scroll bar (#232812) 2024-11-01 13:19:38 +01:00
Johannes Rieken
08dbf783fc allow to resize inline chat zone (#232795)
* * make inline chat filter empty in-progress items
* show ellipses progress on request
* make inline zone animate its frame during request

* allow to resize inline chat zone

fixes https://github.com/microsoft/vscode/issues/230784
2024-11-01 02:01:56 -07:00
Rob Lourens
50a2adc65b Cleanup chat context keys (#232515)
* Start renaming context keys

* vote

* detected agent

* More

* More

* chatEditApplied

* More

* More

* More

* Cleanup

* Cleanup
2024-10-29 11:55:16 -07:00
Henning Dieterichs
4d312be7e6 Implements inline edit rejection command support (#232472)
* Implements inline edit rejection command support

* updates monaco.d.ts
2024-10-29 12:11:31 +01:00
Johannes Rieken
65dc3932c4 replace tail-util with Array.at(-1) (#232412) 2024-10-28 06:06:46 -07:00
Johannes Rieken
a2a9cb3c19 inline chat should react to widget clearing (#232390)
* For the clear command, use `lastFocusedWidget` over `openView`

re https://github.com/microsoft/vscode-copilot/issues/9865

* inline chat should react to widget clearing
2024-10-28 02:05:41 -07:00
Martin Aeschlimann
a77b2c285d Merge pull request #232140 from microsoft/joh/residential-ermine
let review cancel the session when no or no real edits happened
2024-10-24 18:26:25 +02:00
Johannes
0c89e7c53f more tweaks 2024-10-24 17:28:25 +02:00
Johannes
308b9dcd6e capture and restore partial view state
fixes https://github.com/microsoft/vscode-copilot/issues/9617
2024-10-24 17:09:43 +02:00
Johannes
26f713df59 let review cancel the session when no or no real edits happened
https://github.com/microsoft/vscode-copilot-release/issues/1872
2024-10-24 15:25:43 +02:00
Ulugbek Abdullaev
1a85a0881e fix a typo (#232132) 2024-10-24 13:51:48 +02:00
Rob Lourens
9e5c728530 Use selected model in 'rerun' inline (#232097)
Fix microsoft/vscode-copilot#9618
2024-10-23 15:05:33 -07:00
Johannes Rieken
1097df99c7 remove unused and falsly flagged setting (#232044) 2024-10-23 15:34:11 +02:00
Johannes Rieken
45677a2558 fix https://github.com/microsoft/vscode-copilot/issues/9382 (#232039) 2024-10-23 04:18:23 -07:00
Johannes Rieken
444f41634a align save confirm flows and reuse setting (#231510) 2024-10-16 18:17:02 +02:00
Rob Lourens
8d8f0cd9d4 Improve chat scrolling (#231370)
* Don't auto-scroll while chat response loads
Fix microsoft/vscode-copilot-release#138

* Show button all the time

* Fixes, don't auto-scroll for edit session view

* Keep autoscroll in inline and quick chat
2024-10-14 21:04:35 -07:00
Johannes Rieken
ad047e27d5 tweak editor inline chat visuals (#230521)
...to be more aligned with other peek experiences, like peek ref or edit breakpoint
2024-10-04 10:47:00 -07:00
Rob Lourens
7ed2d964ff De-contribify the chat attachments (#230451)
* De-contribify the chat attachments
It was done this way originally to match "dynamic variables" and fit the flow of how extra metadata is attached to chat history. But it didn't really make sense for attachments to be considered a contribution given how they're rendered and used now. And I might change this for dynamic variables too anyway. So now we can add some input state that comes directly from the input part and not a contrib.
Fix microsoft/vscode-copilot#8678

* Simplify
2024-10-04 04:34:16 +02:00
Johannes Rieken
7e50bfa7dc debt - remove InlineChatWidget#updateChatMessage because it is effectively unused (#230213)
fyi @meganrogge @Tyriar this update the terminal chat controller. It use of `updateChatMessage` would be a noop since terminal chat uses a real chat model
2024-10-01 11:36:38 +02:00
Johannes Rieken
ec1125c2d1 inline chat fixes (#229973)
* disposing the editor view should remove overflowing overlay widgets node

* use a suitable overflow widget dom node for the inline chat widget

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4298

fixes (doesn't re-introduce) https://github.com/microsoft/vscode-copilot/issues/8701

* * make sure `ESC` first closes suggest before closing inline chat
* also remove duplicated action
2024-09-27 17:09:21 +02:00
Johannes Rieken
ded5e0d79e counter revealLines-logic with sticky scroll max lines (#229939)
fixes https://github.com/microsoft/vscode/issues/229934
2024-09-27 11:48:08 +02:00
Johannes Rieken
d445ba063e workaround for https://github.com/microsoft/vscode-copilot/issues/8676 (#229876)
reopens https://github.com/microsoft/vscode-copilot/issues/8127
2024-09-26 21:19:34 +02:00
Johannes Rieken
fec02a71d4 don't bother normalizing ranges from (funky) hunks as they get normalized later anyways. (#229830)
fixes https://github.com/microsoft/vscode-copilot/issues/8643
2024-09-26 17:05:25 +02:00
Johannes Rieken
178c125fe2 reveal chat zone should always reveal position in editor (#229838)
fixes https://github.com/microsoft/vscode-copilot/issues/8509
2024-09-26 16:58:27 +02:00
Johannes Rieken
be760b0915 fix how context key is updated (#229818) 2024-09-26 13:18:45 +02:00
Johannes Rieken
67a93b0e45 Revert "Revert "chat command center polish (#229674)" (#229755)" (#229802)
This reverts commit 11fb5bbfdb.

Add another context key `inlineChatPossible` which truely checks code editors so that a global command works
2024-09-26 11:11:36 +02:00
Connor Peet
11fb5bbfdb Revert "chat command center polish (#229674)" (#229755)
This reverts commit b80272842e.

This broke sanity tests for copilot-chat, probably in preconditions
for `inlineChat.start`. It's not clear to me what the right fix is,
so I am backing it out in order to unblock copilot-chat.
2024-09-25 22:55:46 +02:00