Commit Graph

23 Commits

Author SHA1 Message Date
Connor Peet
fef3e22ca7 fix: refresh env vars when auto attach settings change
Fixes https://github.com/microsoft/vscode-js-debug/issues/731
2020-09-01 08:54:50 -07:00
Connor Peet
8817251691 debug: provide positive ack to js-debug bootloader on auto attach 2020-08-25 09:44:18 -07:00
Connor Peet
ad40702857 debug: bump js-debug and use its auto attach by default once more 2020-08-21 18:47:20 -07:00
Connor Peet
dc0150c61a debug: make auto attach apply state transition in new workspaces
Previous there was a case:

1. Auto attach was enabled in user settings and workspace A was open
2. Switch to workspace B, and then turn auto attach off in user settings
3. Switching back to workspace A, environment variables were not cleared

Now, the last state is stored in the workspace settings so that
we can tear down the previous state if necessary.
2020-08-20 16:06:18 -07:00
Connor Peet
bb284a4943 debug: enable opt-in js-debug auto attach 2020-08-18 12:31:31 -07:00
Connor Peet
add05e385e debug: always clear out any js-debug state 2020-07-13 11:34:32 -07:00
Connor Peet
24cff71f25 debug: use previous node debug for the July release 2020-07-13 11:34:24 -07:00
Connor Peet
66744e3b25 debug: enable js-debug to auto attach (#95807)
* debug: enable js-debug to auto attach

This modifies the debug-auto-launch extension to trigger js-debug as
outlined in https://github.com/microsoft/vscode/issues/88599#issuecomment-617242405

Since we now have four states, I moved the previous combinational logic
to a `transitions` map, which is more clear and reliable. The state
changes are also now a queue (in the form of a promise chain) which
should avoid race conditions.

There's some subtlety around how we cached the "ipcAddress" and know
that environment variables are set. The core desire is being able to
send a command to js-debug to set the environment variables only if they
haven't previously been set--otherwise, reused
the cached ones and the address.

This process (in `getIpcAddress`) would be vastly simpler if extensions
could read the environment variables that others provide, though there
may be security considerations since secrets are sometimes stashed
(though I could technically implement this today by manually creating
and terminal and running the appropriate `echo $FOO` command).

This seems to work fairly well in my testing. Fixes #88599.

* fix typo

* clear js-debug environment variables when disabling auto attach
2020-04-23 09:49:29 -07:00
Benjamin Pasero
ca22de4b17 debt - bump node.d.ts dependency in extensions to 12.x (part of #82514) 2019-10-28 08:11:47 +01:00
Aurélien Pupier
7a5bca9faf Add License field to package.jsons #68423 (#68771)
it should avoid to have "warning XXX: No license field" during yarn
build

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
2019-06-06 11:44:50 +02:00
Benjamin Pasero
d78a75973c update @types/node (#74881) 2019-06-05 10:20:01 +02:00
Benjamin Pasero
d7977c880f debt - use @types/node: 10 for all extensions 2019-06-05 09:32:36 +02:00
Matt Bierner
dd3e2d94f8 Remove use strict directives in extension code
We compile with alwaysStrict so these directives are not needed
2018-10-02 16:02:44 -07:00
Matt Bierner
52d3961c2b Update more extensions to use shared config 2018-10-02 10:24:19 -07:00
Joao Moreno
707787c5b8 update yarn.lock files to use integrity 2018-09-30 16:34:43 +02:00
Alex Dima
5bae3f69d9 Use webpack also for small built-in extensions 2018-09-20 14:17:45 +02:00
Alex Dima
34e7a220c8 Avoid shipping unnecessary files 2018-09-19 19:53:46 +02:00
Johannes Rieken
fc2b0a8ec1 add missing vscode-nls updates 2018-09-06 15:12:28 +02:00
Andre Weinand
1ae8d0168e auto-attach cleanup 2018-08-25 00:21:24 +02:00
Andre Weinand
14595011f1 move some auto-attach code back to node-debug 2018-08-22 01:08:52 +02:00
Andre Weinand
edfda964e0 use terminal.processId for auto-attach; fixes #55918 2018-08-07 12:28:30 +02:00
Andre Weinand
47cf06001c detect 'winpty-agent.exe'; fixes #55672 2018-08-02 17:37:02 +02:00
Andre Weinand
bf7ac9201e move auto-attach into new built-in extension; fixes #53586 2018-07-12 16:41:03 +02:00