5ee455116f
Add codeql comments and small fix ( #185931 )
2023-06-23 02:40:39 +02:00
67cc0965b3
allow images in markdown preview editor to be copied ( #184432 )
...
* allow images in markdown preview editor to be copied
* resolved feedback
* added findPreview method
* removed copy image command from showPreview
* clean up
---------
Co-authored-by: Meghan Kulkarni <t-mekulkarni@microsoft.com >
2023-06-07 18:08:22 +00:00
87a6bda310
Fix opening encoded markdown fragment in preview ( #178465 )
...
Fixes #178340
2023-03-28 08:59:30 +02:00
1379bf3f15
Fix markdown webview state updates ( #178153 )
...
Fixes #164071
Also fixes the webview not scrolling when the resources changes
2023-03-23 17:51:09 +00:00
924ee8b4d8
Don't scroll sync to elements inside collapsed details sections ( #176541 )
...
Fixes #176538
Turns out that `getClientBoundingRect` returns weird bounds for elements inside of a collapsed details section
2023-03-08 21:06:26 +01:00
3ca5284e44
Clean up markdown preview messaging ( #176458 )
...
- Add properties directly to message
- Add `ImageInfo` type
- Don't use state to pass around imageInfo
2023-03-07 17:28:13 -08:00
6a44101bb1
Type markdown preview webview message ( #176444 )
...
Simply types messages. Will clean up types in next pass
2023-03-07 14:23:17 -08:00
83c4e0f5c4
Reset markdown scroll progress on resource change ( #176437 )
...
Reset scroll progress on resource change
Fixes #164071
2023-03-07 23:12:46 +01:00
d0ad7c09bb
Fix details blocks being auto closed on markdown preview changes ( #176330 )
...
Fixes #175353
2023-03-07 02:36:38 +01:00
5b79b91838
Fix #173869 marking active line for code elements too in markdown pre… ( #173870 )
...
Fix #173869 marking active line for code elements too in markdown preview
2023-02-08 20:25:54 +00:00
9894ae8700
fix#171379 ( #172175 )
...
Co-authored-by: VTX0 <VTX0>
2023-02-01 00:35:02 +00:00
ac88f33e2c
Revert "Fix: New md file scrolls to Top. ( #164999 )" ( #168224 )
...
This reverts commit 54543cf5bf
2022-12-06 22:50:30 +01:00
107d3ab28c
Fix markdown scrolling between elements being too jumpy ( #166746 )
...
Fixes #165055
We need to consider the distance between the end of the previous element and start of the next element. Previously we were taking distance from start of the previous to start of the next
2022-11-18 13:02:56 -08:00
54543cf5bf
Fix: New md file scrolls to Top. ( #164999 )
...
Fixes #164071 .
2022-11-09 13:48:39 -08:00
4991cf2112
Remove console.log ( #162784 )
2022-10-05 15:25:52 -07:00
f4bf1f30a2
Skip ul and ol when highlighting selected markdown element ( #161139 )
...
Fixes #155552
For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line
This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
f17b33faf2
Use .?method() in more places ( #152112 )
...
Switches simple patterns like:
```ts
if (some.thing) {
some.thing.method();
}
```
to:
```ts
some.thing?.method()
```
This is more concise and avoids having to repeat the `some.thing` part
2022-06-15 16:28:31 +00:00
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
e7b3724e0c
Enable no-case-declarations in codebase ( #139243 )
...
Fixes #139236
This can catch tricky programming mistakes that cause a runtime error. See 7e266b2c42
2021-12-15 17:15:35 -08:00
913639f42a
Strip meta http-equiv tags from webview content updates
2021-12-14 11:53:49 -08:00
71f615b105
Also compare other attributes for md preview updates
...
Fixes #136816
2021-11-10 14:13:41 -08:00
c11a9ce097
Better update of line numbers
2021-11-04 14:34:49 -07:00
4d50e586ec
Improve morphing for vscode-docs
2021-11-03 20:54:20 -07:00
fbc1f7df91
Fire event when md content is updated
...
For #136255
2021-11-01 17:41:39 -07:00
8f672cac62
Use morphdom to reduce number of full page updates to md preview
...
This should help improve scroll sync and also reduce the number of times we go out to the network if images are in the preview
2021-11-01 15:33:00 -07:00
92418e0ea0
Remove usage of non-standard setImmediate
...
This was broken after upgrading to webpack5
2021-07-06 12:42:27 -07:00
b8f11107f7
Use @types/vscode-webview
2021-05-27 13:41:38 -07:00
119581fc2a
Use more standard name for shared extension tsconfig
...
This enables Intellisense in the `tsconfig.base` file
2021-04-12 15:58:38 -07:00
d5f4e119e0
Use Array.from's map directly instead of a second call to map
2021-04-12 14:42:39 -07:00
a34e751b01
Fix scrolling of markdown preview. Close #65504 ( #111094 )
...
* Fix scrolling of markdown preview.
* Use scrollDisabledCount.
* Stop initializing scrollDisabledCount.
* Make scrollTo enough large to occur scroll events.
* Should resolve when the error event occurs.
2021-01-14 17:24:08 -08:00
731f9c2563
Prefer using data-href if it exists on a markdown preview link
...
Fixes #101203
2020-07-23 21:51:18 -07:00
7099dc0708
Add extra check to markdown state
...
Possibly for #102733
Tries to get users out of a potential bad state where the state was being stored as a string. Only insiders users should have hit this
2020-07-16 16:27:42 -07:00
9cfd597153
Rework markdown preview code to better support markdown preview editors
...
Splits the preview part of the markdown preview from the dynamic preview management part of things. Static preview swap to preview the active markdown file and don't scroll sync with any other markdown files
2020-04-11 17:30:12 -07:00
b1c5e2f19b
Don't include dom typings in extensions ( #89942 )
...
**Problem**
All of our extensions currently are built using the dom typings. This can lead to runtime errors if you mistakenly use `window` or similar
**Fix**
Exclude the dom typings from compile. Then explicitly import the node types for `URL` and `TextEncoder`
2020-02-04 11:08:22 -08:00
856d085279
run "eslint --fix" to get some changes for free
2020-01-02 20:14:09 +01:00
b10335675f
Improve scroll sync for nested markdown lists
...
Fixes #83735
2019-11-08 18:13:01 -08:00
45a64e2bdd
Improve markdown scroll sync on fenced code blocks in md files
2019-11-02 15:28:01 -07:00
78559bf9e6
Normalize vscode links in markdown files to target current vscode version
...
Fixes #71622
This allows you to use generic `vscode` links inside the markdown preview and still have them work if the preview is viewed in insiders
2019-10-23 20:27:52 -07:00
36aa903d5a
Rewrite how we handle links in the md preview
...
Try to simplify how we resolve links:
- Move most logic out of the preview itself.
- Simplify the amount of rewriting we do in the markdown engine
2019-10-04 17:57:33 -07:00
ef698fa6cd
Make markdown refresh more stable
...
Fixes #80680
- Always sync the current preview line number with the editor, even when `scrollEditorWithPreview` is false
- If the md file is focused and refresh is called, do not try resetting the current line to match the editor file. This mainly effects the case where `scrollEditorWithPreview` is false
2019-10-03 13:46:31 -07:00
2235ebf5db
Handle new vscode-resource format for md linkes
...
Fixes #81849
This is a safer scoped fix, not the best one. Will look into removing most of this uri munging for october
2019-10-02 14:09:38 -07:00
7226e32d1b
Use shared tsconfig for markdown preview
...
Fixes #80121
2019-09-09 10:20:56 -07:00
34339f92c4
Fix: Markdown Preview scroll remains same after clicking on some other link #78465
...
Improves the behavior on how markdown preview behaves when clicking a link
2019-08-19 09:35:06 -05:00
7f3d3d835f
Add vscode.env.webviewResourceRoot api
...
Fixes #72155
Adds a constant to the api that tracks the root path for resources inside of webviews. This is required because we will not be able to use `vscode-resource:` uris on the web. Our current approach is to rewrite the html we are given but there are almost certainly going to be cases where we don't get this quite right.
Adopts the new api for the markdown preview
2019-06-18 22:29:37 -07:00
003521e715
Fix markdown preview restoring to wrong position on restart
2019-02-14 18:24:01 -08:00
5cc00861fc
Enable no-var-keyword tslint rule
2019-01-03 18:02:48 -08:00
cba84fba5e
Take progress within element into account for markdown scroll sync
...
Fixes #65504
2019-01-02 14:36:16 -08:00
907924abc0
Reveal absolute top of markdown preview when scrolling to line 0
...
Fixes #61816
2018-10-25 11:57:50 -07:00
fe63c7e2f2
Reveal line 0 in editor when markdown preview scrolls to top
...
Fixes #61815
2018-10-25 11:57:50 -07:00
a101ececf4
Remove onCommand from markdown preview
2018-09-21 15:08:41 -07:00
Matt Bierner
MeghanKulkarni
Ely Ronnen
ibuky
Debayan Ganguly
Johannes Rieken
Takashi Tamura
Salvador Cabrera