Isha Singh
a243dd1e64
Merge pull request #281302 from Ishiezz/fix/251898-implicit-activation-warning
...
Fix: Do not suggest implicit activation message when engine does not support it
2026-01-16 14:26:16 +00:00
Dave Nicolson
3ca2d59c38
Update activation event linter message ( #269156 )
2025-10-15 09:44:24 +00:00
Matt Bierner
98b069c041
Work towards getting isolated built-in extension compiles
...
For #271167
This makes it so our built-in extensions can mostly be built using `tsc` on the command line. Previously the extensions were picking up a lot of typing info from the root `node_modules` that meant they weren't truly independent
2025-10-13 11:03:20 -07:00
Matt Bierner
ed71020bfc
Convert extension webpack scripts to modules
2025-08-07 17:20:22 -07:00
Robo
12326f9906
chore: update to Electron 35 ( #245423 )
...
* chore: bump electron@35.0.1
* chore: update types/node@22.x
* chore: update web types for node v22.x
* chore: bump electron@35.1.2
* chore: update node.js build
* chore: update app.dock usage
Refs 71f3ff6bf2
* chore: bump electron@35.1.4
* chore: bump electron@35.1.5
* ci: bump sysroot to glibc 2.28 and gcc 10.5.0
* ci: enable timeout for smoketests
* chore: bump min glibcxx to 3.4.26 for server
* Revert "ci: enable timeout for smoketests"
This reverts commit afb637e85d .
* chore: update debian dependencies
* fix: workaround npm.ps1 argument parsing with powershell
* chore: update rpm dependencies
* test: partially revert changes from 242535
* test: remove redudant keybinding dispatch for selectTab
* test: fix test failure from running configured tasks
* test: focus settings editor for preferences.test.ts
* node - adopt compile cache (#246835 )
* node - adopt compile cache
* adopt for utility process
* tweaks
* log state of compilation cache
* Revert "log state of compilation cache"
This reverts commit f3840387a583013834762e2c44f6e8424929297f.
* Revert "node - adopt compile cache (#246835 )"
This reverts commit 673a00cab66c9bac87f3cd27b80efa41c80150f1.
* chore: update builds
* chore: bump electron@35.2.0
* chore: bump electron@35.2.1
* chore: bump electron@35.2.2
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2025-05-09 19:03:36 +09:00
Johannes
e6f315d2fc
eng - use esModuleInterop for extensions
2024-10-01 21:57:30 +02:00
Robo
9494a89080
chore: add npmrc to extensions folder ( #230214 )
2024-10-01 12:43:01 +02:00
hj
88d7b97c93
chore: rm unreached ignore items when build extensions. ( #227906 )
...
chore: rm unreached ignore items when compiling extensions.
2024-09-09 10:32:51 +00:00
Robo
b5a6aa14a8
feat: switch to npm as default package manager ( #226927 )
...
* feat: move from yarn to npm
* chore: skip yarn.lock files
* fix: playwright download
* chore: fix compile and hygiene
* chore: bump vsce@2.17 .0
Refs 8b49e9dfdf
* test: update results for bat and sh colorizer tests
* fix: add missing lock files for windows
* fix: switch to legacy-peer-deps
* chore: update markdown-it@14.1.0
Refs 737c95a129
esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.
* ci: increase pr timeout for windows integration tests
* chore: fix product build
* build: ignore extension dev dependency for rcedit
* build: fix working directory inside container
* build: fix dependency generation
* npm: update dependencies
* ci: use global npmrc
* ci: update cache
* ci: setup global npmrc for private npm auth
* build: fix extension bundling
* chore: sync npm dependencies
* ci: debug env variables for container
* ci: fix win32 cli pipeline
* build: fix npmrc config usage for build/ and remote/ dirs
* fix: windows build
* fix: container builds
* fix: markdown-language-features tests and bundling
```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"
extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
14 │ var punycode = require('punycode');
╵ ~~~~~~~~~~
The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
Adds userland package based on beed9aee2c
* fix: container builds for distro
* chore: update yarn occurrences
* fixup! chore: bump vsce@2.17 .0
Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf
* chore: sync npm dependencies
* chore: sync npm dependencies
* chore: sync npm dependencies
* chore: throw error when yarn is used for installation
* chore: add review feedback
* chore: switch exec => run where needed
* chore: npm sync dependencies
* fix: markdown-language-features bundling
```
✘ [ERROR] Could not resolve "punycode"
extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
14 │ var punycode = require('punycode');
╵ ~~~~~~~~~~
The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
Adds missing userland package based on markdown-it/markdown-it@beed9ae ,
can be removed once we update markdown-it >= 14.1.0
* ci: rename no-yarn-lock-changes.yml
* chore: sync npm dependencies
* ci: restore no-yarn-lock-changes.yml
We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.
* chore: sync npm dependencies
* ci: rebuild cache
* ci: fix no-package-lock-changes.yml
* chore: bump distro
* chore: rm yarn.lock files
* chore: rm yarn.lock files without dependencies
* chore: add vscode-selfhost-import-aid to postinstall dirs
* chore: bump distro
2024-09-06 22:18:02 +09:00
Sandeep Somavarapu
a764c2ac80
Support version for proposed APIs ( #216608 )
...
Support version for proposed APIs
2024-06-19 18:01:46 +02:00
Robo
5216c04428
chore: update to electron 29 ( #209818 )
...
* chore: update electron@29.1.0
* chore: update typings to 20.x
* chore: bump electron@29.1.5
* ci: fix crash in compiling extensions-ci
* chore: disable .d.ts check for build/
$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref
8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
~~~~~~~~~
Found 2 errors in 2 files.
Errors Files
1 node_modules/@types/chokidar/index.d.ts:21
1 node_modules/chokidar/types/index.d.ts:8
Refs a0f9e09f64
* chore: update core types
* temp: fix layer validation
* chore: update nodejs checksums
* ci: use latest v20 LTS for missing node-gyp
Refs eacec5f490
* ci: define LIBCPP_HARDENING_MODE
* ci: fix crash in vscode-web-min-ci
* chore: update rpm deps-list
* chore: bump tree-sitter-typescript@0.20 .5
* chore: bump electron@29.3.0
* chore: bump electron@29.3.1
* chore: update rpm deps-list for x86_64
* ci: disable io_uring UV backend on linux
* ci: disable io_uring backend for oss as well
* chore: update typings to 20.x
* ci: add TODO for io_uring workaround
* chore: bump distro
* chore: update preinstall node version checks
* chore: update @types/gulp
Refs https://github.com/microsoft/vscode/issues/212442
* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Martin Aeschlimann
07fcfc80c3
update to latest jsonc-parser ( #192872 )
2023-09-12 14:58:01 +02:00
Joyce Er
0795888f65
fix: avoid fs dependency in web ( #192565 )
...
* feat: quick fix for redundant activation events
* fix: avoid `fs` dependency in web
2023-09-08 14:23:04 +02:00
Christof Marti
e073d674f3
Revert "feat: quick fix for redundant activation events ( #192495 )"
...
This reverts commit 0b4fd719e3 .
2023-09-08 10:31:35 +02:00
Joyce Er
0b4fd719e3
feat: quick fix for redundant activation events ( #192495 )
2023-09-07 15:12:23 -07:00
Robo
ea490e5545
chore: update to Electron 25 ( #188268 )
...
* chore: update electron@25.3.0
* ci: update NodeTool version
* chore: update @types/node
* add more common types to layers checker
* chore: update debian dependencies
* chore: update rpm dependencies
* fix: use legacy dns result order of Node.js
* ci: remove deprecated always-auth npm config
Refs npm/cli@72a7eeb
* chore: update deb and rpm dependencies
* chore: update armhf rpm dependencies
* chore: update x64 debian dependencies
* chore: update x64 rpm dependencies
* chore: update electron@25.3.1
* chore: update electron@25.4.0
* chore: bump distro
* chore: bump distro
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2023-08-07 21:46:27 +09:00
Christof Marti
fb8bf97485
Remove obsolete warning ( #170049 )
2023-05-16 11:31:46 +02:00
Joyce Er
413f98e499
Implicitly activate only main language contribs ( #179287 )
2023-04-06 10:12:17 +02:00
Ulugbek Abdullaev
612b6d7f11
extension linter: lint readme: don't return on closed doc
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
da34f7d462
extension linter: remove unused import
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
500f3f30ec
extension linter: context keys: improve error message
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
5a8b485d82
extension linter: context keys: move the internal command to access parser to extension host code
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
7e9f63f4ae
extension linter: add linting for when-clauses (context keys) - "when" and "enablement" fields in extension manifest files - package.json
...
(no linting for keybindings.json yet)
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
4c4639b888
extension linter: run parser with no regex error recovery
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
2add9e8ceb
extension linter: make sure we don't fail on array access
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
efffb789ff
extension linter: add linting for when and enablement clauses in package.json's
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
e4fe3740b9
extension linter: add a warning todo
2023-02-28 14:00:30 +01:00
Ulugbek Abdullaev
da6b280570
extension linter: refactor: rewrite package.json linting with a for-loop
2023-02-28 14:00:30 +01:00
Joyce Er
5148e0bde9
Use Buffer.toString in node-only context ( #175592 )
2023-02-27 23:31:16 +01:00
Joyce Er
d7fec23a8a
Use fs.readFile instead of openTextDocument ( #175077 )
2023-02-22 07:35:34 +01:00
Joyce Er
3ab0fb3aa9
Lint redundant activation events if extension is targeting ^1.75 ( #173345 )
2023-02-03 09:53:00 -08:00
Joyce Er
ddd71a222d
Lint redundant onTaskType activation events ( #173205 )
2023-02-02 14:31:13 -08:00
Tyler James Leonhardt
262ab0e7bf
Warn about star activation ( #173112 )
...
* star activation bad
* better message
* info level
2023-02-02 15:59:09 -05:00
Joyce Er
b42443093a
Lint more redundant activation events ( #173186 )
...
* `onWalkthrough`
* `onTerminalQuickFixRequest`
* `onTerminalProfile`
* `onRenderer`
2023-02-02 11:18:11 -08:00
Joyce Er
05e1981145
Lint redundant package.json activation events ( #171297 )
2023-01-16 09:28:19 +01:00
Joyce Er
d799b6c18f
Fix diagnostics for implicit activation events not appearing ( #167081 )
...
* Fix diagnostics for implicit activation events not appearing
* Fix line endings
2022-11-23 10:33:32 -08:00
Joyce Er
009d74e8f5
Lint redundant implicit activation events ( #166485 )
...
* Emit error for `onNotebookSerializer` usage
2022-11-22 08:28:24 -08:00
Matt Bierner
8a37410ce2
Adopt l10n for extension-editing ( #165523 )
...
For #164438
2022-11-04 12:04:47 -07:00
Tyler James Leonhardt
29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data ( #161819 )
...
ref #161297
2022-09-26 11:10:54 -07:00
Tyler James Leonhardt
d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 ( #157530 )
...
* rev version of vscode-nls to 5.1.0
* and yarn lock
2022-08-08 18:43:45 +02:00
Martin Aeschlimann
375681e51e
json: use default word pattern ( #151754 )
2022-06-13 14:36:42 +02:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450 .
* chore: bump electron@17.1.0
* Revert "ci: fix build with latest node-gyp"
This reverts commit c3e948aa30 .
* chore: revert ci changes for node v16
* chore: update yarn.lock
* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c18 .
This reverts commit 46301339b7
* ci: fix remote compiler for sdl-scan
* chore: fix remote/.yarnrc
* chore: fix build/npm/postinstall.js
* chore: rm crash reporter from shared process
* chore: rm crash reporter from ext host
* chore: fix build/lib/layersChecker.ts
* :chore: preserve some more changes
* fix tests
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
2022-02-24 17:49:49 +01:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f .
* Revert "watcher - enable crash reports on linux (#136264 )"
This reverts commit af261488f8 .
* chore: enable crashpad on linux
* chore: bump electron@15.3.1
* chore: update api changes
* chore: bump @vscode/sqlite3@5.0.3
* spec: skip non-context aware module unittests
* chore: fix perf hook integration with node environment
* fix: adopt fs api changes
* chore: fix integration tests
* chore: bump electron@15.3.2
* chore: bump electron@16.0.0
* temp(macOS): kill test instances in OSS
* Revert "temp(macOS): kill test instances in OSS"
This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.
* chore: update chromium version for clang downloader
* some 💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83
* ci: fix linux build
* ci: update github ci cache
* ci: fix remote build in github ci
* ci: better fix for remote build
* chore: bump azure cache
* chore: fix merge conflict
* :chore: update to electron@16.0.2
* chore: bump @vscode/sqlite3@5.0.7
* ci: update to gcc-4.9 for remote
Refs https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37c .
* Revert "Revert "chore: bump electron@16.0.7""
This reverts commit a7f1b73951 .
* chore: fix github linux workflow
* chore: address review feedback
* chore: bump electron@16.0.8
* ci: revert to stretch distro for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732 .
* ci: fix remote folder build
* chore: fix github linux ci
* 🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com >
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com >
2022-02-08 20:09:00 +01:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
dependabot[bot]
f8af3fba2d
Bump markdown-it from 12.0.4 to 12.3.2 in /extensions/extension-editing ( #140597 )
...
Bumps [markdown-it](https://github.com/markdown-it/markdown-it ) from 12.0.4 to 12.3.2.
- [Release notes](https://github.com/markdown-it/markdown-it/releases )
- [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md )
- [Commits](https://github.com/markdown-it/markdown-it/compare/12.0.4...12.3.2 )
---
updated-dependencies:
- dependency-name: markdown-it
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-13 17:05:10 -08:00
Johannes Rieken
ffdb8427ed
💄 use native endsWith, fyi @chrmarti
2022-01-05 11:46:29 +01:00
Johannes Rieken
986f163f9f
use extension linter to warn about usage of impossible proposals, https://github.com/microsoft/vscode-internalbacklog/issues/2461
2022-01-05 11:46:29 +01:00
Johannes Rieken
68e819043c
use tsconfig.json#include for vscode.d.ts and vscode.proposed.d.ts, enables to remove most ref.d.ts-files
2021-11-09 15:53:35 +01:00