* feat: move from yarn to npm
* chore: skip yarn.lock files
* fix: playwright download
* chore: fix compile and hygiene
* chore: bump vsce@2.17.0
Refs 8b49e9dfdf
* test: update results for bat and sh colorizer tests
* fix: add missing lock files for windows
* fix: switch to legacy-peer-deps
* chore: update markdown-it@14.1.0
Refs 737c95a129
esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.
* ci: increase pr timeout for windows integration tests
* chore: fix product build
* build: ignore extension dev dependency for rcedit
* build: fix working directory inside container
* build: fix dependency generation
* npm: update dependencies
* ci: use global npmrc
* ci: update cache
* ci: setup global npmrc for private npm auth
* build: fix extension bundling
* chore: sync npm dependencies
* ci: debug env variables for container
* ci: fix win32 cli pipeline
* build: fix npmrc config usage for build/ and remote/ dirs
* fix: windows build
* fix: container builds
* fix: markdown-language-features tests and bundling
```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"
extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
14 │ var punycode = require('punycode');
╵ ~~~~~~~~~~
The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
Adds userland package based on beed9aee2c
* fix: container builds for distro
* chore: update yarn occurrences
* fixup! chore: bump vsce@2.17.0
Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf
* chore: sync npm dependencies
* chore: sync npm dependencies
* chore: sync npm dependencies
* chore: throw error when yarn is used for installation
* chore: add review feedback
* chore: switch exec => run where needed
* chore: npm sync dependencies
* fix: markdown-language-features bundling
```
✘ [ERROR] Could not resolve "punycode"
extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
14 │ var punycode = require('punycode');
╵ ~~~~~~~~~~
The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```
Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0
* ci: rename no-yarn-lock-changes.yml
* chore: sync npm dependencies
* ci: restore no-yarn-lock-changes.yml
We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.
* chore: sync npm dependencies
* ci: rebuild cache
* ci: fix no-package-lock-changes.yml
* chore: bump distro
* chore: rm yarn.lock files
* chore: rm yarn.lock files without dependencies
* chore: add vscode-selfhost-import-aid to postinstall dirs
* chore: bump distro
* monokai-color-theme.json: treat Python comment string blocks
...as comments too
* Update *all* themes to consider Python block string comments as comments
modified: extensions/theme-abyss/themes/abyss-color-theme.json
modified: extensions/theme-defaults/themes/dark_vs.json
modified: extensions/theme-defaults/themes/hc_black.json
modified: extensions/theme-defaults/themes/hc_light.json
modified: extensions/theme-defaults/themes/light_vs.json
modified: extensions/theme-kimbie-dark/themes/kimbie-dark-color-theme.json
modified: extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json
modified: extensions/theme-monokai/themes/monokai-color-theme.json
modified: extensions/theme-quietlight/themes/quietlight-color-theme.json
modified: extensions/theme-red/themes/Red-color-theme.json
modified: extensions/theme-solarized-dark/themes/solarized-dark-color-theme.json
modified: extensions/theme-solarized-light/themes/solarized-light-color-theme.json
modified: extensions/theme-tomorrow-night-blue/themes/tomorrow-night-blue-color-theme.json
* Update all changes to use "string.quoted.docstring"
...instead of "string.quoted.docstring.multi.python", per
@aeschli's request here:
https://github.com/microsoft/vscode/pull/182162#issuecomment-1545296640
This way the comment formatting applies to *all* language quoted
docstrings, instead of just to Python.
* bring back python colorize tests
---------
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
This PR contains a few more fixes for both Solarized themes:
1. The token color definitions have diverged a bit, unify them.
Specifically, this makes both themes use the same colors for the same
tokens (only affects diff headers and class names) and harmonizes a
few scopes.
2. `#D30102` is not a Solarized color, replace with `#DC322F` (red).
3. `#219186` is not a Solarized color, replace with `#859900` (green).
This PR contains a few fixes for both Solarized themes:
1. According to #105418, the empty scope's foreground color is supposed to
be used for normal text. For some reason, this does not seem to work,
therefore set `editor.foreground` explicitly.
2. Some of the ANSI colors have been set to values differing from the
official theme at https://ethanschoonover.com/solarized/ due to
contrast issues. Nowadays, this can instead be fixed with
`terminal.integrated.minimumContrastRatio` (see #121107).
3. Solarized Dark uses `#93A1A1` for normal text in a few places where
`#839496` should be used instead.
4. Solarized Dark uses `#657B83` in a few places, which is not part of
the official theme, use the correct `#586E75` instead.
5. Solarized Light uses `#073642` in one place, which is not part of the
official theme, use the correct `#586E75` instead.
* Theming for dirty tabs
* Improve border for dirty tabs
1. Make it thinner
2. Add a setting to disable it
3. Use 4 colors (activeFocused, activeUnfocused, inactiveFocused, inactiveUnfocused)
4. Move part of logic
* Hot apply of setting `dirtyTabBorder`
* Rename the setting
* Add default dirty border for all themes
* 3 of the 4 colors should be derived from the one main color
* Rename `dirty` to `modified`
* Rename `modifiedActiveFocusedBorder` to `modifiedBorder`
* Add modified border color for built-in themes
* More contrast
* Applying style directly on element
* Changing only color
* Using full border
* Using existing div for border styling
* Add setting to telemetry
* Uncomment cleanup code
* tweak colors and descriptions
* 💄
