Commit Graph

324 Commits

Author SHA1 Message Date
Daniel Imms
34cd689874 Speculative fix for terminal tabs flaky smoke test
Wait briefly between backspace and enter.

Fixes #216460
2024-06-18 05:53:44 -07:00
Francisca Carneiro
f93c5bc0c5 Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. (#213067)
Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
2024-06-04 15:13:40 -07:00
Robo
5216c04428 chore: update to electron 29 (#209818)
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs a0f9e09f64

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs eacec5f490

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
2024-05-11 01:20:28 +09:00
Benjamin Christopher Simmonds
cff275ae64 Adopt custom hover in settings and keybindings editor (#206440)
* adopt custom hover in settings and keybindings editor

* fiy smoketests
2024-02-28 16:37:07 +01:00
Benjamin Christopher Simmonds
a8f73340be Fix for smoketest extension installation timeout (#205444)
hover smoke test fix #204771
2024-02-17 17:58:12 +01:00
Benjamin Christopher Simmonds
5b8fe0ed3e Fix smoke test (#204836)
fix smoke test
2024-02-09 16:47:22 +01:00
Benjamin Christopher Simmonds
fcaef74d2e Fix smoke tests (#204764)
fix smoke tests
2024-02-08 20:43:28 +01:00
Martin Aeschlimann
56b0088dce update vscode-test-web (#201187)
* update vscode-test-web

* add @playwright/browser-chromium

* add skipLibCheck

* add skipLibCheck

* use esnext

* cleanup
2023-12-19 16:03:03 +01:00
Sandeep Somavarapu
5a7b7be28a throw error (#199653) 2023-11-30 12:58:41 +01:00
Daniel Imms
35ae6b1925 Use a polling approach for writing and asserting 2023-11-08 09:20:44 -08:00
Daniel Imms
d2432a3545 Prevent shell data from leaking into empty term 2023-11-08 08:02:01 -08:00
Daniel Imms
bff9161987 Make empty terminal smoke test technique reusable 2023-11-08 07:16:24 -08:00
Sandeep Somavarapu
f8f9f06401 whenWorkbenchRestored was not implemented in the driver in previous releases (#197068) 2023-10-31 13:43:02 +01:00
Sandeep Somavarapu
519c8072f3 poll to wait for workbench to be restored (#197059) 2023-10-31 11:23:50 +01:00
Sandeep Somavarapu
bee0ea18bd Move wait for workbench restoration to Application (#197053)
#195850: Move wait for workbench restoration to
Application#checkWindowReady
2023-10-31 09:00:40 +01:00
Raymond Zhao
e9e1f8a132 Revert "Separate Settings editor open and search steps" (#196997)
Revert "Separate Settings editor open and search steps (#196866)"

This reverts commit 932e49579b.
2023-10-30 09:53:19 -07:00
Raymond Zhao
932e49579b Separate Settings editor open and search steps (#196866) 2023-10-30 07:50:27 -07:00
Raymond Zhao
e20515c62e Bump dependencies for debug sub-dependency (#195513) 2023-10-13 09:01:12 -07:00
Sandeep Somavarapu
9a611bbe20 retry after waiting for workbench restore (#195300) 2023-10-10 16:05:45 -07:00
Sandeep Somavarapu
2f51809ca3 Fix extensions smoke test (#195264)
#193046
- add waitForWorkbenchRestored method to driver
- move driver to workbench
- wait for workbench to restore if command is not found
2023-10-10 20:11:30 +02:00
Tyler James Leonhardt
bd41b74fd1 Dedupe strings in tf-idf index & include exactLabelMatch in runCommand in smoke tests (#195085) 2023-10-08 16:47:51 -07:00
Tyler James Leonhardt
a4a2d8f0f4 Rename --disable-keytar to --use-inmemory-secretstorage (#192312)
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.

Fixes https://github.com/microsoft/vscode/issues/191498
2023-09-08 17:58:32 +02:00
Sandeep Somavarapu
2aa8453e35 Merge pull request #192270 from microsoft/sandy081/dreadful-ferret
#191860 - retry if command is not found
2023-09-06 11:59:04 +02:00
Sandeep Somavarapu
9ed384ffe7 fix while check 2023-09-06 11:10:35 +02:00
Sandeep Somavarapu
7b15902db0 only check for No matching commands text 2023-09-06 10:58:27 +02:00
Sandeep Somavarapu
6e93ce037b feedback 2023-09-06 10:30:13 +02:00
Robo
ab2afd626f chore: disable hardware acceleration support for linux smoke tests (#192265) 2023-09-06 16:58:16 +09:00
Sandeep Somavarapu
7a0fecc0a7 #191860 - retry if command is not found 2023-09-06 09:36:50 +02:00
Sandeep Somavarapu
63d4fe776b fix #191860 (#192121) 2023-09-04 13:30:46 +02:00
Raymond Zhao
a08322ae0a Add delay to Settings editor search for smoke tests (#190903)
Ref #190896
2023-08-21 20:54:48 +01:00
Raymond Zhao
42b4bf0670 Add Settings editor smoke tests (take 2) (#189867) 2023-08-08 13:01:53 -07:00
Raymond Zhao
39e5dafcd6 Revert "Add Settings editor smoke tests" (#189848)
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a559.
2023-08-07 18:40:37 +01:00
Raymond Zhao
e1dfb2a559 Add Settings editor smoke tests (#189687)
Fixes #141054
2023-08-07 08:22:07 -07:00
Robo
ea490e5545 chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Benjamin Pasero
cbdfe4e0b4 Removal of feedback control (fix #188960) (#189027) 2023-07-28 10:12:52 +02:00
Raymond Zhao
5be539a588 Bump semver (#187654) 2023-07-12 01:49:45 +02:00
Benjamin Pasero
1894181c08 logs - make sure to attach all logs in browser tests (#181578)
* logs - make sure to attach all logs in browser tests

* separate server logs into `server` folder
2023-05-05 07:02:40 +02:00
Benjamin Pasero
5eba2f631f Expose client (browser) logs for smoke tests running in browser (fix #180102) (#181491) 2023-05-04 12:05:03 +02:00
Tyler James Leonhardt
9af6054416 Hide details if there are none (#181384)
* try this again

* use display to follow separator and make smoke tests only grab label not description or detail
2023-05-03 09:34:14 +02:00
Benjamin Pasero
bc9b50e2d7 smoke - fix timeouts waiting for window (#177984) 2023-03-22 10:15:52 +01:00
Benjamin Pasero
2c3a648d88 smoke - remove timeout from launches (#177204) 2023-03-15 13:35:17 +01:00
Benjamin Pasero
8bd4a421c0 smoke - fix electron window timeout (#176012) 2023-03-03 08:28:18 +01:00
Benjamin Pasero
6dfe534cca smoke - bring back better solution for waiting that target has loaded (#175415) 2023-02-25 17:41:18 +01:00
Benjamin Pasero
aa07f07339 smoke - update didFinishLoad solution (#175409) 2023-02-24 21:17:19 -08:00
Benjamin Pasero
def1c0dc47 smoke test - try to unblock CI (#175382)
* smoke test - try to fix runs

* comment
2023-02-24 21:35:41 +01:00
Martin Aeschlimann
dc619de8d9 Icons in problems view show black when not focused (#174487)
* Icons in problems view show black when not focused

* update smoke test
2023-02-15 22:34:14 +01:00
Ladislau Szomoru
96d05578ac Test - update minimatch (#167101) 2022-11-23 21:33:27 +00:00
Matt Bierner
4efa993b13 Bump targets for test/automation and test/integration (#165298)
Also enables strict mode for test/integration since it only had strict null checks previously
2022-11-02 17:10:12 -07:00
Matt Bierner
3a8b7e4276 Highlight label should not create extra span nodes (#164657)
* Highlight label should not create extra empty dom nodes

I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document

I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor

* Update tests

* Update smoke test selector

* Update css
2022-11-01 08:00:38 -07:00
Matt Bierner
d1c401cbde Pick up latest TS for building VS Code (#165104)
* Pick up latest TS for building VS Code

* Pick up latest node typings

* Bump node types
2022-11-01 02:43:09 -07:00