Commit Graph

122482 Commits

Author SHA1 Message Date
Joyce Er
150a9ff40b fix: attach listener to element (#214360) 2024-06-05 19:48:37 +02:00
Peng Lyu
d323b88923 📓 re #200091. (#214357) 2024-06-05 10:26:01 -07:00
Connor Peet
4eb1515a2d debug: dispose of event subscriptions (#214358)
Refs #214234
2024-06-05 19:18:13 +02:00
Johannes Rieken
7cc8d36ec4 pass through the right options (#214355) 2024-06-05 19:00:16 +02:00
Sandeep Somavarapu
88e3cecadc debt: remove scanning added extension and just convert it (#214354) 2024-06-05 18:59:18 +02:00
Henning Dieterichs
46488eb08b renames, test improvement (#214323)
* renames, test improvement

* code improvements
2024-06-05 18:38:51 +02:00
Sandeep Somavarapu
3f6190e030 fix #213984 (#214350) 2024-06-05 18:15:46 +02:00
Martin Aeschlimann
2fe839fd1d colorUtils: fixing compile error caused by merging (#214347)
colorUtils: fixing typing error caused by merging
2024-06-05 17:57:16 +02:00
Johannes Rieken
675f0a03d6 fix LanguageModelChatMessage#User (#214342) 2024-06-05 17:10:47 +02:00
Francesco Virga
757820ae1a Add recursive toggle (#212218) 2024-06-05 17:03:20 +02:00
Simon Siefke
cb66768ae2 When completing color keys in settings, fill in current value (#213451)
* register theme service

* set color theme

* set default snippet

* remove log

* use type import

* fix formatting

* undo change

* remove log

* fix formatting

* rename interface

* rename function

* update listener

* remove unused code

* inline event listener

* polish

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2024-06-05 16:59:43 +02:00
Simon Siefke
28cbfce5e6 feature: allow unsetting color theme values in settings (#213512)
* allow null value

* allow unsetting color

* undo change

* delete color

* undo changes

* remove unused code

* unset right map

* add function to create nullable color schema

* use nullable schema

* undo change

* fix nullable object

* use default value

* update both schemas on timeout

* simplifications & polish

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2024-06-05 16:46:26 +02:00
Daniel Imms
d7eb0f15bd Merge pull request #214338 from microsoft/tyriar/214234_2
Register more terminal listeners
2024-06-05 07:39:52 -07:00
Ladislau Szomoru
af675232d0 SCM - consistent fallback for count calculation (#214337) 2024-06-05 16:35:59 +02:00
Johannes Rieken
ab9a1286f2 sketch up lm-extention that allows for function calling (#214334) 2024-06-05 16:32:08 +02:00
Daniel Imms
e446161790 Register more terminal listeners
Part of #214234
2024-06-05 07:20:55 -07:00
Benjamin Pasero
dee8eaf526 Make sure event subscriptions are stored and disposed (#214234) (#214312)
* Make sure event subscriptions are stored and disposed (#214234)

* fix tests
2024-06-05 14:11:06 +02:00
Alexandru Dima
3024b31031 Better track disposables (#214234) (#214322) 2024-06-05 14:00:29 +02:00
Benjamin Pasero
c992076695 Make sure event subscriptions are stored and disposed (#214234) (#214318) 2024-06-05 13:31:55 +02:00
Aiday Marlen Kyzy
2f9fdb5ce7 Extract code from ContentHoverController constructor into separate methods (#214316)
extracting code from ContentHoverController into separate methods
2024-06-05 13:15:52 +02:00
yutotnh
3ab7948e14 Add the ability to specify a list of candidate encodings when guessing encoding (#36951) (#208550)
* Allow to configure a list of encodings to use when guessing #36951

* Bump up the jschardet version into 3.1.2 #36951

* missing merge

* some polish

* renames

* some polish

* some polish

* cleanup

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-06-05 10:23:20 +00:00
Henning Dieterichs
eb7359d330 Enables CodeEditorWidget test suite again (#214309) 2024-06-05 12:03:56 +02:00
Aiday Marlen Kyzy
d2020d8e00 Avoid auto-reindentation when pasting text with only whitespace characters (#213921)
* adding draft code for checking for empty strings

* polishing code
2024-06-05 11:33:38 +02:00
Henning Dieterichs
1ed0758b5f Fixes CI failure (#214307)
* Fixes CI failure

* Fixes CI
2024-06-05 02:15:10 -07:00
Johannes Rieken
ef168a8537 fix leaking listener (#214305)
* polish GC listener warning workflow

re https://github.com/microsoft/vscode/issues/214234

* fix leaking listener

https://github.com/microsoft/vscode/issues/214234
2024-06-05 09:40:03 +02:00
Sandeep Somavarapu
a9a4ef8a71 update-distro (#214302) 2024-06-05 09:02:59 +02:00
Johannes Rieken
1c967bb7c6 fix leaking listeners, track dispoable workbench contributions (#214301)
* fix leaking listener

https://github.com/microsoft/vscode/issues/214234

* track disposable workbench contribution and dispose them on shutdown fyi @bpasero

https://github.com/microsoft/vscode/issues/214234

* fix leaking listener

https://github.com/microsoft/vscode/issues/214234
2024-06-05 08:38:34 +02:00
Sandeep Somavarapu
539e22e69a adopt to new vsce-sign (#214300) 2024-06-05 08:27:14 +02:00
Connor Peet
337a8f18da userActivity: maintain user activity while there's progress in the window (#214264)
Fixes #211064
2024-06-05 07:08:11 +02:00
Joyce Er
ee56498a56 refactor: remove includeSymbols from quick access (#214288) 2024-06-04 17:39:23 -07:00
Alexandru Dima
f5f105b0d8 Fixes #207802 (#214284) 2024-06-04 17:34:36 -07:00
Alexandru Dima
0d833112df Reduce casts (#211878) (#214282) 2024-06-04 16:59:38 -07:00
Peng Lyu
0ec39fa2d0 Re #212879. track child instantiation service for notebooks (#214281) 2024-06-05 00:42:42 +02:00
Peng Lyu
90a47ca3d8 Re #211878. Fix unsafe type assertions for notebooks (#214280) 2024-06-05 00:37:20 +02:00
Alexandru Dima
f8558ae979 Fixes #207445 (#214266)
* Fixes #207445

* Fix problem with disposing
2024-06-05 00:31:05 +02:00
Connor Peet
9e5acb365e eng: dispose child instantiation service instances in debug and testing (#214279)
Refs #212879
2024-06-05 00:29:20 +02:00
Remco Haszing
a131a88231 Replace removeChild with remove (#213465)
* Replace removeChild with remove

This replaces most uses of `parent.removeChild(child)` with
`child.remove()`.

The two are almost equivalent. The only difference is that
`parent.removeChild(child)` throws if the given node is not a child of
the parent, whereas `child.remove()` never throws. There is no noticable
performance difference. The only reason to use `removeChild` is to
support Internet Explorer, but that’s no longer supported by Monaco
editor.

* Fix broken CSP hash

The script content changed, so the sha256 hash changed too.

* Update src/vs/editor/browser/config/charWidthReader.ts

Co-authored-by: Logan Ramos <lramos15@gmail.com>

---------

Co-authored-by: Logan Ramos <lramos15@gmail.com>
2024-06-05 00:21:08 +02:00
Connor Peet
5ca72043a3 debug: support 'source' in group output events (#214278)
Fixes #212304
2024-06-04 15:20:52 -07:00
Francisca Carneiro
f93c5bc0c5 Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. (#213067)
Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
2024-06-04 15:13:40 -07:00
Connor Peet
4af0c6a8f4 testing: fix confusing line decorations when hovering over line numbers (#214275)
Fixes #212585
2024-06-04 23:18:21 +02:00
Henning Dieterichs
ad4f719bd5 Inline completions refactoring (#214272) 2024-06-04 14:02:31 -07:00
Megan Rogge
d9148b110e mute terminal hint color (#214173)
fix #213647
2024-06-04 13:55:17 -07:00
Megan Rogge
55fdf62594 dispose terminal hint decoration on config change (#214178) 2024-06-04 13:54:56 -07:00
Connor Peet
8d662c804b testing: fix new test runs are not collapsible (#214271)
Fixes #212875
2024-06-04 13:36:21 -07:00
Connor Peet
42fe841df7 testing: ensure run all runs everything, use consistent profile for re-runs (#214260)
* testing: ensure run all runs everything, use consistent profile for re-runs

Fixes #212628

* fixup

* fix compile
2024-06-04 22:10:41 +02:00
Alexandru Dima
4d465ecade Avoid leaking disposables (#214234) (#214268) 2024-06-04 12:26:07 -07:00
Alexandru Dima
ef849e41ee Fixes #207457 (#214267) 2024-06-04 21:18:19 +02:00
Daniel Imms
cba48d8efe Merge pull request #214263 from microsoft/tyriar/api_fix
Fix typo in shell integration api docs
2024-06-04 11:53:20 -07:00
Daniel Imms
63f7354682 Merge pull request #214259 from microsoft/tyriar/213694
Remove CommandDetectionCapability.hasInput
2024-06-04 11:50:59 -07:00
Connor Peet
447099bc5e testing: fix "Run Tests" explorer option does not discover tests before trying to run (#214261)
Fixes #212342
2024-06-04 20:49:48 +02:00