Commit Graph

558 Commits

Author SHA1 Message Date
Robo
32d40cf44e chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Matt Bierner
becce316b2 Avoid re-parsing uri 2022-03-08 14:48:13 -08:00
Matt Bierner
fa6ee6ce91 Only allow webviews protocol in top level editor windows 2022-03-08 11:17:01 -08:00
Benjamin Pasero
e9f5380d4f Telemetry: annotate my telemetry events (fix microsoft/vscode-internalbacklog#2768) 2022-03-02 13:35:25 +01:00
Benjamin Pasero
bb1045cde2 lifecycle - dispose main process IPC when being killed 2022-02-25 10:15:50 +01:00
Robo
df645f1450 chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
SteVen Batten
5612d0124a fix layer breakage 2022-02-23 11:15:18 -08:00
SteVen Batten
d3d1be0131 fix layer breakage 2022-02-23 09:53:40 -08:00
SteVen Batten
b43fff4d34 improve pii path logic 2022-02-23 09:32:16 -08:00
Benjamin Pasero
ef70f99af7 tangle - extract common window (#141154) 2022-02-14 08:30:18 +01:00
Benjamin Pasero
60b8611fb1 add logging for url handling (#142685) 2022-02-10 14:13:08 +01:00
Robo
01df559c18 chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Benjamin Pasero
62dc317056 debt - untangle platform/environment (#141154) 2022-02-08 08:33:37 +01:00
Benjamin Pasero
bf1c9e9391 debt - untangle workspace <=> workspaces (part 1, #141154) 2022-02-07 17:30:09 +01:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler James Leonhardt
33040b9696 refactor credentialsmainservice and ensure the right one is used (#141100) 2022-01-20 13:22:03 -08:00
Benjamin Pasero
0e44e127e3 Consider moving ILaunchMainService.getRemoteDiagnostics to IDiagnosticsService (fix #141025) 2022-01-20 09:46:17 +01:00
Matt Bierner
86e3a3a062 Restrict vscode-file requests to main window (#139140)
* Restrict vscode-file requests to main window

This change tries to limit use of the vscode-file protocol to the main window.

While investigating this issue, I hit a bug: `CodeWindow` registers a `onBeforeRequestHandler` but can then be disposed of. When this happens, the handler remains active but any references to `this` inside of it now reference the disposed class.

To fix this, I've moved all the request filtering logic into `app.ts` instead and register it on the `defaultSession` instead of on a web contents.

Then to fix the original issue, I added logic that checks the routingId of the request against the routingIds of all known windows. Only windows with known routingIds are allowed to use `vscode-file`.

* Move logic into configure session

* Check processId

* Check BrowserWindow.getAllWindows instead of just main VS Code windows
2022-01-18 12:43:47 -08:00
Benjamin Pasero
b03fe7a97c watcher - implement and adopt universal file watcher 2022-01-14 08:03:15 +01:00
Tyler Leonhardt
edfe5d03bb delegate encryption and credentials to server if we have a remote 2022-01-12 12:54:21 -08:00
Tyler Leonhardt
4d930765f3 refactor credentials service to main
ensure keytar is there and register service correctly

remove console log

remove extra line
2022-01-12 09:21:19 -08:00
Benjamin Pasero
cadf5cc70f Introduce and use global storage service in main process (#139632)
* convert to async methods

* more async

* shuffle things around

* first cut global storage main

* jsdoc

* cleanup
2021-12-22 13:26:28 +01:00
Benjamin Pasero
b9a2191563 files - add a method to generate a random path name (#139364) 2021-12-17 11:08:17 +01:00
Benjamin Pasero
36bb6a6848 files - make localFilesystem channel reusable 2021-12-15 17:59:53 +01:00
Sandeep Somavarapu
87bf1d8065 #126376 remove user configuration file service and use atomic read 2021-12-15 17:25:49 +01:00
Sandeep Somavarapu
7566103475 Merge pull request #139021 from microsoft/sandy081/sharedprocess-userdata-scheme
use user-data scheme for user data in shared process
2021-12-15 13:38:44 +01:00
Benjamin Pasero
c6373868a8 files - rename disk based file providers to make intent clear 2021-12-15 12:17:00 +01:00
Sandeep Somavarapu
421f88c7f9 #126376 use user-data scheme for user data in shared process and use main process fsp 2021-12-13 20:13:12 +01:00
Benjamin Pasero
420c749ca8 Rename resolveShellEnv to getResolvedShellEnv (fix #137923) 2021-11-26 10:28:49 +01:00
Alex Dima
778014d381 Move extension host spawning to a worker thread (on the main process) 2021-11-11 15:29:15 +01:00
Alex Dima
e9f8290003 Wait for up to 6s for extension hosts to exit, then proceed to kill them 2021-11-04 22:15:48 +01:00
Alex Dima
4967ca4182 Merge remote-tracking branch 'origin/main' into alex/main-process-extension-host 2021-11-04 20:39:05 +01:00
Benjamin Pasero
02d4cb5383 Unable to resolve your shell pops-up instantly (fix #136272) 2021-11-03 08:38:59 +01:00
Alex Dima
6f72d1b184 Try to fork the extension host process directly from the main process 2021-10-26 11:16:47 +02:00
Alex Dima
81471f8da2 Merge remote-tracking branch 'origin/main' into alex/main-process-extension-host 2021-10-25 15:55:19 +02:00
Alex Dima
41d6fc7e3a Create extension host processes from a node worker in the main process 2021-10-25 15:39:26 +02:00
Sandeep Somavarapu
bda864be28 Fix #134909 2021-10-25 14:24:14 +02:00
Benjamin Pasero
a9438c996c sandbox - restore session based file watching (#132282) 2021-10-21 08:37:20 +02:00
Benjamin Pasero
2f795d34ee sandbox - implement non-recursive watch support (#132282) 2021-10-20 08:56:34 +02:00
Benjamin Pasero
32666ede94 sandbox - first cut file service implemented by main process (#132282) 2021-10-19 13:59:09 +02:00
Logan Ramos
3cce1d2c25 Clearer Settings UI for new telemetry setting (#135028)
* Work on improving telemetry setting description

* two options

* third option

* Add old crash reporter to getTelemetryLevel

* More verbose wording + comments

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2021-10-13 15:03:12 -04:00
Benjamin Pasero
c70170a480 Show an error when resolving shell environment fails or is timing out (fix #133910) 2021-09-29 13:54:18 +02:00
Benjamin Pasero
bce732b7fc Open workspace from vscode:// url (fix #133976) 2021-09-28 12:37:06 +02:00
Logan Ramos
12ae331012 Move appenders to be better controlled by services (#133465)
* Cleanup telemetry appenders to be owned by service

* Add telemetry level to services

* simplify

* Fix compile

* Rename supportsTelemetryLogging -> supportsTelemetry

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2021-09-22 10:39:57 -04:00
Logan Ramos
aab8675480 Deprecate crash reporter
/cc @sbatten
2021-09-21 13:29:09 -04:00
Logan Ramos
9407123681 Intial work to add error to telemetry setting (#132996)
* Intial work to add error to telemetry setting

* deprecate and centralize the telemetry setting

* Fix compilation

Co-authored-by: SteVen Batten <stbatt@microsoft.com>
2021-09-14 10:50:25 -04:00
SteVen Batten
8fb7bbabf1 fixes telemetry levels 2021-09-03 13:05:14 -07:00
SteVen Batten
9525d0e1ed centralize telemetry level (#131919)
* centralize telemetry level

* add comments and const enum
2021-08-30 10:38:42 -07:00
Matt Bierner
a3cb14be7f Organize imports in vs/code 2021-08-04 17:05:16 -07:00
Benjamin Pasero
e007ca899c cli - handle unhandled errors (fix #128854) 2021-08-04 13:43:07 +02:00