Commit Graph

55 Commits

Author SHA1 Message Date
Matt Bierner
337b02953f Move TernarySearchTree to own file (#163684)
* Move TernarySearchTree to own file

This class is taking up most of `map.ts`. I think it's time to split it out into its own file

* Adding missing file change

* Update changed file
2022-10-17 09:21:23 -07:00
Joyce Er
f9a0fdeff2 Tolerate minor edit session identity differences (#163804)
Also add basic support for partial edit session identity matches
2022-10-16 23:51:51 -07:00
Joyce Er
db4f5a84dc Debt - do not expose an unregister method from service (#158641)
* Debt - do not expose an unregister method from service

* Add registration disposable to disposable store
2022-08-30 08:34:15 -07:00
Joyce Er
fa4ff1519d Implement and adopt edit session identifier API proposal (#157733)
* Add canonical workspace identifier proposed API

* Use canonical id to store and resume edit sessions

* Add git extension workspace identity provider

* Fix warning incorrectly showing up

* Make auto resume behavior opt in

* * Create a separate service
* Accept WorkspaceFolder instead of URI
* Return string instead of object

* Make edit session restores resilient to provider registration races

* Introduce an activation event
* Activate contributing extension before using provider

* `CanonicalWorkspaceIdentity` -> `EditSessionIdentity`

* Show progress while resuming edit session

* Store edit session even if extension will take care of opening target workspace

* Address most of PR feedback

* `IEditSessionsWorkbenchService` -> `IEditSessionsStorageService`

* Unregister provider in renderer

* Split out proposal into new `editSessionIdentityProvider.d.ts`

* Fix bad merge

* Always show progress in window

* Convert URI schemes
2022-08-19 08:01:43 -07:00
yutotnh
64b74d9a64 fix: typo (#153187) 2022-06-27 20:42:02 +00:00
Matt Bierner
f7e12a3a92 Use optional method calls in more places (#151634)
This replaces code like:

```ts
if (foo.bar) {
    foo.bar(cat);
}
```

with:

```ts
foo.bar?.(cat)
```

Which is more concise but has the same meaning
2022-06-09 15:04:28 -07:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Dima
24569c613e Rearrange files to better separate between workbench/api and workbench/services (#141003) 2022-01-31 16:14:21 +01:00
Benjamin Pasero
579e0a39c2 Cleanup GlobPattern handling in extension host (#140689)
* rewrite `NotebookExclusiveDocumentPattern` handling (#140491)

* 💄

* also fix #140707

* address feedback
2022-01-17 14:21:10 +01:00
Benjamin Pasero
e3cf7e5e1b API: Allow to use the file watcher for aribitrary folders (#3025) (#139881)
* API: Allow to use the file watcher for aribitrary folders (#3025)

* fix tests

* update `createFileSystemWatcher` docs

* refuse to watch resources that are watched in workspace already

* properly check proposed API

* make it work via `createFileSystemWacher` (first cut)

* more docs

* cleanup

* enable recursive watching based on pattern

* add tests

* drop out-of-workspace events when using simple patterns

* do not apply excludes when watchig files

* log extension watch requests

* also log unwatch

* improved exclude handling

* more docs

* drop proposed api needs

* remove `suite.only`

* cannot watch inside workspace more than once

* do not send extension decriptor over

* adopt latest changes

* add `baseUri` to relative pattern

* backwards compat
2022-01-13 13:32:03 +01:00
Johannes Rieken
d528769c4d don't send full ExtensionDescription when using message API 2022-01-11 13:57:30 +01:00
Sam Estep
faaeb6be41 Add option to not pass --no-ignore-parent to rg 2022-01-02 23:11:16 -05:00
Sandeep Somavarapu
a0a448f344 Fix #128280 2021-09-23 14:33:18 +02:00
Ladislau Szomoru
3edce10f20 Cleanup modal property from proposed api 2021-05-02 14:22:41 +02:00
Ladislau Szomoru
480f3c0b35 Return undefined if dialog is cancelled (#122234) 2021-04-26 15:28:25 -07:00
SteVen Batten
a9f70f7919 finalize basic workspace trust api 2021-04-21 09:56:35 -07:00
SteVen Batten
86157f0d55 api resolves immediately trust state in non-modal 2021-04-19 08:52:52 -07:00
SteVen Batten
c5fab4faa3 Boolean Trust State (#121141)
* move to boolean-based trust state

* update api based on feedback
2021-04-13 12:54:52 -07:00
SteVen Batten
15af2df708 tweak api based on conversations (#120397) 2021-04-02 11:02:03 -07:00
Ladislau Szomoru
49a164e886 Workspace trust API polish 2021-04-01 15:59:04 +02:00
Ladislau Szomoru
648ea3d1e0 Refactor requireWorkspaceTrust to requestWorkspaceTrust 2021-04-01 15:59:04 +02:00
Ladislau Szomoru
c55aff6379 API feedback (WorkspaceTrustRequest -> WorkspaceTrustRequestOptions) (#119658) 2021-03-24 10:30:31 +01:00
Ladislau Szomoru
14fd07d57a Workspace trust api feedback 2021-03-03 12:41:22 +01:00
Ladislau Szomoru
05ea4c5e4e Removed optional message, and added modal parameter (#117241) 2021-02-22 14:10:01 +00:00
SteVen Batten
afd102cbd2 Trusted Workspaces Feature Branch Merge (#115961)
* draft trusted workspace service / model

* renaming

* add request model and action

* err fix

* add request handlers with mock actions

* some quick fixes

* adding badge icon to activity bar gear

* Add Statusbar item to indicate trust

* Cleanup code

* Add background color

* Use theme color for the status background color

* adding basic editing experience

* observe trust with startup tasks

* Extension enablement

* Add capability to provide a custom message

* Remove old actions

* explorer: if you can not undo, pass undo to editor

fixes #111630

* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689

* Fixed compilation error

* Handle extension uninstall

* Handle extension install

* Ability to prompt when state is untrusted

* Do not change state is the modal dialog is dismissed or the Cancel button is pressed

* Refactored enablement code

* Prompt when installing from VSIX

* Prompt when installing from the Gallery

* Move file into the browser folder

* fixes and polish

* restructure workspace contributions

* restructure actions and use confirmations

* Initial draft of the proposed APIs

* Added stubs for the proposed api

* Trusted Workspace proposed API

* Fix a regression introduced by merge

* status bar indicator improvements

* remove helper command as we now have hooks

* verbose messaging for the immediate request

* add indication to global activity icon of pending request

* try personal title

* Add configuration setting

* Add additional extension actions

* Fix contributions

* Removed context key that is not needed

* Fixed issue with the dialog

* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016

* Fixes #115221: update emoji tests

* Give a higher priority to language configuration set via API call (#114684)

* debug console menu action polish

* Avoid the CSS general sibling combinator ~ for perf reasons

* more notebook todos

* Use label as tooltip fallback properly
Part of #115337

* Fixes microsoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`

* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364

* simplify map creation, fyi @bpasero

* Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)

* fix multiple save dialogs appearing on Windows when spamming Ctrl+S

* remove old fix and instead keep track of windows with open dialogs in the dialogMainService

* keep initialisation of activeWindowDialogs in constructor

* remove unused variable

* some changes

* queue dialogs based on hash of options

* simplify structure, fix comment typo

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* remove unnecessary async/await for aquireFileDialogLock method

* don't acquire file dialog lock for message boxes

* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* 💄 dialog main service locks

* debt - adopt some ? operator

* Better hiding of custom hover in icon label

* Limit to 8ms (120fps)

* more API todos for notebooks

* 💄

* Update grammars

* chore - group notebook specific api proposals together

* added unreleased fixes to endgame notebook

* Add changes back to the modal dialog

* Add back the workspace trust proposed APIs

* Adjust dialog buttons

* Standardize on WorkspaceTrust name across interfaces, classes, variables

* Renamed some of the missing keys

* Add TestWorkspaceTrust stub and fix failing tests

* Add requiresWorkspaceTrust property to fix test failure

* remove notebook change

Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2021-02-06 00:38:32 -08:00
Sandeep Somavarapu
52cc4e6a0d #108793 check casing and use proper extUri 2020-12-09 16:14:09 +01:00
Benjamin Pasero
d49955575e 💄 relative pattern 2020-11-26 08:26:12 +01:00
Johannes Rieken
31c034604e remove old forUris, rename forUris2 to forUris, https://github.com/microsoft/vscode/issues/110241 2020-11-11 08:43:08 +01:00
Sandeep Somavarapu
50416be1c6 #110241 Adopt TernarySearchTree.forUris2 2020-11-10 18:36:54 +01:00
Johannes Rieken
70a8fc5b23 ignore path casing for workspace folders, https://github.com/microsoft/vscode/issues/108095 2020-10-05 11:14:40 +02:00
Johannes Rieken
960205b8a0 use ternary search tree for uris instead of paths, fyi @bpasero, @sandy081, @roblourens, https://github.com/microsoft/vscode/issues/93368 2020-04-08 10:07:12 +02:00
Rob Lourens
009af2025d Add useDefaultExcludes property to findTextInFiles API
Fix #85946
2020-03-03 15:13:09 -08:00
Matt Bierner
d99bbafe17 Pick up new TS version for building VS Code 2020-01-28 11:00:02 -08:00
Matt Bierner
1b70625f8c Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Rob Lourens
731e2b9591 Revert rootPath changes
This reverts commits a416c77e56,
5bc80f3ea0,
0403a10885
2019-12-09 10:56:39 -08:00
Rob Lourens
5bc80f3ea0 Make rootPath undefined in a multiroot workspace, #69335 2019-12-06 14:07:29 -08:00
Rob Lourens
7cc88f5caa Handle RelativePattern in findTextInFiles correctly
Fix #85722
2019-11-27 15:43:28 -08:00
Johannes Rieken
dedf0de944 change type of _serviceBrand from any to undefined, #79918 2019-08-30 15:40:46 +02:00
Johannes Rieken
7fefcb0f46 Merge branch 'master' into joh/extHostInject 2019-08-09 14:56:27 +02:00
Benjamin Pasero
41df640e06 format error message properly (#78740) 2019-08-09 13:24:40 +02:00
Johannes Rieken
7a6f22b3af rename rpcService to extHostRpcService 2019-08-09 09:51:22 +02:00
Johannes Rieken
2420d4c505 separate rpc and init data into separate services 2019-08-07 19:51:28 +02:00
Johannes Rieken
ebd96071d1 make extHost-things services, setup injector 2019-08-07 16:11:00 +02:00
Johannes Rieken
051b669b61 💄 2019-08-05 16:12:05 +02:00
Rob Lourens
70ab0ada55 Fix 'null' exclude for findFiles, add more tests
Fix #77813
2019-07-24 14:24:13 -07:00
Rob Lourens
65fdc745ae Use null across EH boundary instead of undefined 2019-07-23 15:39:03 -07:00
Martin Aeschlimann
8e38e56f89 make isEqual case sensitive for non-file URIs 2019-06-17 12:06:10 +02:00
Benjamin Pasero
c72cfe0c65 Provide API to get access to the workspace configuration file (#37421) (#72490)
* Provide API to get access to the workspace configuration file (#37421)

* fix untitled ID

* update docs
2019-04-17 14:24:10 +02:00
Johannes Rieken
261fa9f939 fix #71992 2019-04-12 09:59:30 +02:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00