Commit Graph

55 Commits

Author SHA1 Message Date
Benjamin Pasero
33cc09da7a Revert "Removing EXT_HOST_CREATION_DELAY hacks" (#83422)
This reverts commit 2b61a8817b.
2019-10-28 12:08:07 +01:00
Daniel Imms
2b61a8817b Removing EXT_HOST_CREATION_DELAY hacks
This one was a bit tricky to figure out what was going on, but this is how it
was working before: Terminals that use extension processes calls
$createTerminal from the ext host, this returns a promise with an ID that gets
returned asynchronously after the process has been setup (ie. an ext host process
proxy was created).

The reason we needed the timeout was because the process initialization is async
as we need a layout to occur so that we have the dimensions of the terminal to
give to the process. The fix could have been setTimeout(..., 0) as well but that
feels hacky as well, the fix in this commit is to pipe an event through from
the process manager which is the actual time when we are good to start telling
ext hosts are the new terminals.

Fixes #77655
2019-10-25 12:57:30 -07:00
Eric Amodio
618b9aa022 Reduces terminal buffering test wait to 0
Removes unneeded suite
2019-10-23 18:28:16 -04:00
Eric Amodio
1ab47af535 Fixes #48513 - updated from review comments 2019-10-23 18:28:16 -04:00
Eric Amodio
e887486e4d Fixes #48513 - buffers terminal onData events 2019-10-23 18:28:16 -04:00
Daniel Imms
4bd485513c Merge remote-tracking branch 'origin/master' into tyriar/79425 2019-09-12 21:19:59 -07:00
Daniel Imms
c3e7a4a1ec Move a lot of terminal into browser
Fixes #79425
2019-09-12 20:36:08 -07:00
Daniel Imms
678abfe8b2 Remove Terminal.onDidWriteData
Replaced by vscode.window.onDidWriteTerminalData

Fixes #78574
2019-09-12 19:09:12 -07:00
Daniel Imms
37e0b8e229 Add terminal.integrated.automationShell
Fixes #78497
2019-08-09 09:40:38 -07:00
Daniel Imms
d2ee9a16a5 Merge remote-tracking branch 'origin/master' into tyriar/69865_remove_renderers 2019-08-06 10:30:56 -07:00
Daniel Imms
ac80d49e15 Ensure all Emitters in terminal are disposed
Fixes #78498
2019-08-06 10:20:19 -07:00
Daniel Imms
81adc15a12 Merge remote-tracking branch 'origin/master' into tyriar/69865_remove_renderers 2019-08-06 10:02:39 -07:00
Daniel Imms
dc6b475be7 Add global event window.onDidWriteTerminalData
Fixes #78502
2019-08-06 09:58:26 -07:00
Daniel Imms
25fe980387 Remove terminal renderers
Part of #69865
2019-08-05 14:31:15 -07:00
Johannes Rieken
32da48e7a0 consistent dto namings 2019-08-05 16:50:13 +02:00
Daniel Imms
9b60caf9e0 Improve naming of start/spawn request calls 2019-07-25 16:09:03 -07:00
Daniel Imms
3866deba35 Use pty naming instead of virtual process
Part of #77160
2019-07-25 16:00:41 -07:00
Daniel Imms
0927be89c8 Tweak names, make shellLaunchConfig readonly again 2019-07-24 14:29:24 -07:00
Logan Ramos
018034a7e7 Bubble up the change of shellLaunch config 2019-07-24 13:58:34 -07:00
Logan Ramos
4008ea909e Merge remote-tracking branch 'microsoft/master' into shell-path-error-remote 2019-07-24 11:22:02 -07:00
Daniel Imms
df5d748fe5 Fix integration tests 2019-07-23 16:23:02 -07:00
Logan Ramos
d826dfd943 Allow remote error messages to work 2019-07-19 11:19:00 -07:00
Daniel Imms
48e7c6d927 Fix start cb in CustomExecution2
Fixes #77428
2019-07-16 15:10:17 -07:00
Matt Bierner
618da58752 Use map instead of object literals in mainThreadTerminalService
Replaces a few uses of object literals with regular maps, which  better enforce type correctness
2019-07-15 12:00:37 -07:00
Daniel Imms
fd48fa0d3b Fix dimenisons test and clean up 2019-07-12 10:37:29 -07:00
Daniel Imms
3092a1023c Remember dimensions from other terminals
Part of #77228
2019-07-11 21:18:06 -07:00
Daniel Imms
6dabbf2963 Merge pull request #76736 from microsoft/alexr00/terminalVPChanges
Changes to terminal to enable Tasks use of TerminalVirtualProcess
2019-07-05 09:49:02 -07:00
Daniel Imms
8bd0e79c73 Fix ext host terminals
Fixes #76670
2019-07-05 09:06:11 -07:00
Alex Ross
65f53d53b1 Changes to terminal to enable Tasks use of TerminalVirtualProcess 2019-07-05 17:57:03 +02:00
Daniel Imms
880a0c1507 Merge remote-tracking branch 'origin/master' into tyriar/virtual_process 2019-07-02 18:10:33 -07:00
Daniel Imms
9d01ac8949 Fix virtual process resize and debounce event 2019-07-02 17:40:25 -07:00
Matt Bierner
ae2cc878f8 Using DisposableStore in mainThread class
#74250
2019-07-02 16:37:35 -07:00
Daniel Imms
0054980481 Pass args via object 2019-07-02 11:20:59 -07:00
Daniel Imms
0d809b4036 Clean up 2019-07-02 11:10:13 -07:00
Daniel Imms
51aab4d1eb Impl overrideDimensions 2019-07-02 10:26:59 -07:00
Daniel Imms
b96cbd870b Fix issues with early ext host terminal messages going missing 2019-07-02 09:44:37 -07:00
Daniel Imms
29303c819d Get input working 2019-07-01 16:14:13 -07:00
Daniel Imms
6f1d0fc7ec Get virtual processes mostly working 2019-07-01 15:58:29 -07:00
Daniel Imms
2205cb69ed Start of terminal virtual processes 2019-07-01 12:27:23 -07:00
Daniel Imms
bdd15725a9 Push ext host check to mainThread, apply fix to request defaults too
Fixes #76049
2019-06-26 11:59:29 -07:00
Daniel Imms
00eee140d9 Don't send available shells request to both ext hosts
Part of #76049
2019-06-26 11:59:28 -07:00
Daniel Imms
3ce04754ad Rename runInBackground to hideFromUser
See #75278
2019-06-25 10:53:30 -07:00
Daniel Imms
62037fb7bc Fire onDidChangeMaximumDimension when dimensions are set
Fixes #73496
2019-06-20 10:03:21 -07:00
Daniel Imms
994bfe2d6a Remove getDefaultShell 2019-06-19 15:31:44 -07:00
Daniel Imms
0aab08edf2 Add getDefaultShellAndArgs
Also differentiate default from system shell
2019-06-19 15:25:44 -07:00
Daniel Imms
87e16500d2 Call getDefaultShell via ext host on web
Part of #75795
2019-06-19 12:57:26 -07:00
Daniel Imms
331da82ad5 Enable shell selector outside Windows
Fixes #75718
2019-06-18 11:28:36 -07:00
Daniel Imms
c287c3cfc7 Get default shell selector working 2019-06-17 11:53:58 -07:00
Daniel Imms
a7412fbb2b Pass cwd through to main 2019-06-17 09:32:07 -07:00
Daniel Imms
976320ddd2 Pass workspace shell permissions to ext host 2019-06-13 15:41:00 -07:00