Commit Graph

884 Commits

Author SHA1 Message Date
Peng Lyu
0f05c6dd4f Fix #160729. Disable workspace md paste handler for notebook. (#160833)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-09-15 09:48:21 -07:00
Matt Bierner
03ada8a3e8 Rework how markdown server works with documents (#160948)
* Rework how markdown server works with documents

This rewrites how the markdown server works with documents. The goal is to better handle switching between in-memory versions of a doc (from `TextDocument`) and versions of the same doc on disk. From the markdown service's POV, there is only one type of document

As part of this, I've also adopted the newest markdown language service version

* Bump package-lock versions
2022-09-15 09:27:02 +02:00
Matt Bierner
fa1fee3b21 Pick up latest Markdown language service (#160831) 2022-09-14 09:20:52 -07:00
Matt Bierner
2cf7468289 Fix markdown server deleting documents on close if they still exist on disk (#160859) 2022-09-14 09:16:39 -07:00
Matt Bierner
3729f509b5 Support creating image in workspace when pasting image data into markdown (#160554)
For #157043
2022-09-10 08:56:18 -07:00
Matt Bierner
5d5ea15a65 Allow passing in custom workspace/parser to markdown server (#160429)
For #159805

This splits the markdown server into two main functions:

- `startVsCodeServer` which assumes the client can implement all the functionality of VS Code. It is not specific to VS Code however, the client just need to implement the custom messages that VS Code does

- `startServer` which lets you pass in your own implementation of the parser and workspace. A consumer of the server can then use this to have their own custom server implementation, which might use normal node apis to read files
2022-09-08 11:35:42 -07:00
Matt Bierner
2d27f8db6a Use MD LS for resolving all document links (#160238)
* Use MD LS for resolving all document links

This switches the markdown extension to use the markdown language service when resolving the link. This lets us delete a lot of code that was duplicated between the extension and the LS

* Pick up new ls version
2022-09-07 20:55:14 -07:00
Matt Bierner
077f5865da Support latest md ls (#160228)
- Update `looksLikeMarkdownPath` to look at open documents and notebooks, not just the uri
- Register custom command  for document links
2022-09-07 07:17:41 +02:00
Matt Bierner
c4722f1bb2 Write markdown link setting change to correct scope (#159816)
Fixes #159084

Also fixes the same issue for JS/TS
2022-09-02 13:38:41 +10:00
Matt Bierner
d9fd208c29 Default to workspace root when dropping into untitled md files (#159814)
Fixes #159812
2022-09-01 16:03:40 -07:00
Matt Bierner
21337aed3f Pick up newest markdown language service (#159619)
This brings support for code actions and source actions, along with some bug fixes

Also fixes `getAllMarkdownDocuments` to prefer open documents instead of those on disk
2022-08-31 09:20:41 +02:00
Matt Bierner
01ea9c11ea Update extension enabled tsconfig libs (#159631)
Matches what we set for `src/`
2022-08-31 07:57:15 +02:00
Matt Bierner
a13e5e1da6 Also apply max-width to videos in webviews (#159500) 2022-08-30 00:52:54 +02:00
Matt Bierner
b91533f3d7 Pick up latest vscode-markdown-languageservice (#159341) 2022-08-26 13:08:49 -07:00
Matt Bierner
ea6cfdd2ef Pick up 8.0.2 for MD language client (#159319)
Missed updating this when pulling in new server version

https://github.com/microsoft/vscode-languageserver-node/issues/1064
2022-08-26 11:13:37 -04:00
Matt Bierner
0a7b686a48 Fix markdown not registering find all references support (#159242) 2022-08-26 01:42:52 +02:00
Matt Bierner
940abc9c11 Fix workspace edit format for update md paths on move (#158965)
Unblocks testing #158416
2022-08-23 16:33:00 -07:00
Matt Bierner
3393b785de Bump server version (#158297) 2022-08-16 14:38:41 -04:00
Matt Bierner
720a61fc28 Fix markdown link diagnostics not updated when directories are renamed / deleted (#157956)
Fix markdown link diagnostics not updated when directories are renamed/deleted

Turns our that `createFileSystemWatcher` will not fire if a parent dir is renamed / deleted. See #60813

To fix this, I believe we have to create watchers for all parent directories too (or watch everything in the entire workspace)
2022-08-12 13:48:40 -04:00
Matt Bierner
b731beeef4 Use notebook document uri for drop / copy paste (#157939)
Fixes #157938
2022-08-11 19:52:55 +01:00
Matt Bierner
38ea5c22a6 Pick up new markdown LS version (#157843) 2022-08-10 18:16:24 -07:00
Matt Bierner
8bf82819fc Add experimental support for update markdown links on file moves/renames (#157209)
* Add experimental support for update markdown links on file moves/renames

Fixes #148146

This adds a new experimental setting that automatically updates markdown

Note that this needs a new version of the vscode-markdown-languageservice so the build is expected to break for now

* Pick up new LS version
2022-08-09 08:31:40 -07:00
Matt Bierner
389938998f Show error when markdown preview restore fails (#157566)
Fixes #155493
2022-08-09 09:55:40 +02:00
Matt Bierner
0103536a60 Apply editor-font-family to all code in notebooks (#157554)
Apply editor-font-family to all `code` in notebook

Fixes #146696

This matches what we do in the markdown preview
2022-08-08 20:59:16 +02:00
Tyler James Leonhardt
d8453c0440 Rev built-in versions of vscode-nls to 5.1.0 (#157530)
* rev version of vscode-nls to 5.1.0

* and yarn lock
2022-08-08 18:43:45 +02:00
Matt Bierner
07e45c5a71 Fix package version (#157202)
Not sure why this was not caught by earlier builds
2022-08-04 21:40:06 -07:00
Matt Bierner
b012216211 Fix markdown images having duplicate ids (#157177)
Fixes #153144
2022-08-05 06:31:42 +02:00
Matt Bierner
784de60319 Add activeWebviewPanelId context key (#156944)
Fixes #156942

This context tracks the id of the active webviewPanel
2022-08-03 07:03:33 +02:00
Matt Bierner
8b27dcb1f8 Pick up latest markdown language service (#156933) 2022-08-02 23:31:58 +02:00
John Murray
7e400c7137 Provide valid markdown-specific default for editor.quickSuggestions setting (#156686) (#156689)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-08-02 13:51:41 -07:00
Matt Bierner
e3267b75c6 Fix onDidDeleteMarkdownDocument not hooked up (#156913) 2022-08-02 22:18:08 +02:00
Matt Bierner
1097f3e440 Use finalized vscode-languageserver version (#156910)
Use finalized vscode-languageserver build
2022-08-02 15:51:07 -04:00
Matt Bierner
3a5a458643 Clear markdown diagnostics when file is closed (#156912) 2022-08-02 20:32:02 +02:00
Matt Bierner
241c770203 Exclude esbuild files from build (#156362) 2022-07-27 09:32:07 -04:00
Matt Bierner
9cf2fabdd6 Rename editor.dropIntoEditor.enabled setting (#156381)
Fixes #156344
2022-07-27 06:44:44 +02:00
Matt Bierner
cf145a83ac Enable safe inline svg tags in trusted html (#156216)
Enable safe svg tags in trusted html

From cce00ac40d/src/tags.js (L124)
2022-07-25 16:32:10 -07:00
Matt Bierner
68cbaa708e Pick up new version of markdown-language-server (#156010)
This fixes md diagnostics and links for multiroot workspaces
2022-07-24 22:22:03 -07:00
Matt Bierner
a9b387204b Add some additional logging to md server (#156007)
Logs watcher operations
2022-07-23 00:32:10 +02:00
Matt Bierner
e2006a52da Add npmignore to markdown server (#155898)
* Add npmignore to markdown server

* Update version
2022-07-21 16:21:57 -07:00
Matt Bierner
b2daf1af82 Add MD server tracing and update diagnostics on files changes (#155797) 2022-07-21 10:07:06 -07:00
Matt Bierner
924dde5c1e Documenting markdown LS (#155789) 2022-07-21 11:48:30 +02:00
Matt Bierner
32f5e49082 Move MD diagnostics to language server (#155653)
* Move MD diagnostics to language server

This switches us to using the LSP pull diagnostic model with a new version of the language service

* Bump package version

* Delete unused file
2022-07-19 16:34:09 -07:00
Matt Bierner
394eaa9fa3 Fix md document links for untitled files (#155248) 2022-07-14 18:15:13 -07:00
Matt Bierner
9ee8961347 Move MD references, rename, and definition support to md LS (#155127) 2022-07-14 08:32:27 +02:00
Matt Bierner
867acc336f Remove references to finalized drop api (#155128) 2022-07-14 08:27:25 +02:00
Matt Bierner
50056f3e78 Finalize drop into editor api (#155102)
Fixes #142990
Fixes #149779
2022-07-13 12:54:52 -07:00
Matt Bierner
bec36ce756 Move md path completions and document links to language server (#155100) 2022-07-13 12:49:37 -07:00
Matt Bierner
75e231ad82 Clean up document link resolve (#154959)
- Move vscode scheme normalization to the DocumentLinkProvider
- Remove extra function since we already recognize uri-like links
2022-07-12 15:55:21 -07:00
Matt Bierner
eeb8d49317 Move md workspace symbol search to language service (#154874)
* Move md workspace symbol search to language service

Also implements more of IWorkspace for the server

* Revert extra change
2022-07-12 10:04:25 -04:00
Matt Bierner
c9bf4393d5 Rename drop API interface (#154876)
Makes the names more consistent
2022-07-12 11:33:13 +02:00