Commit Graph

39 Commits

Author SHA1 Message Date
Matt Bierner
360c9fd134 Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
Logan Ramos
2eae3caa26 Implement API changes from TPI feedback (#265213)
* Implement API changes from TPI feedback

* Update names

* Handle old fallback
2025-09-04 17:45:03 -04:00
Daniel Imms
832ae085a4 Merge pull request #263623 from rwoll/fix-blockOnResponse
skip flakey blockOnResponse tests
2025-08-27 10:49:55 -07:00
Logan Ramos
a18d41e90a Finalize LM API (#263415)
* Finalize BYOK API

* More byok

* Fix compile errors

* Feedback

* Fix fat fingering

* Fix capabilities

* Bump version

* Rename contrib point + activation events

* Update test

* Add proposed api check to require authorization

* Change comment
2025-08-27 17:25:34 +00:00
Ross A. Wollman
87b4d2a251 skip flakey blockOnResponse tests
`workbench.action.chat.open.blockOnResponse` is flaking in CI. So far,
I cannot reproduce locally so skipping to avoid noise in CI while I
debug.

Since the core logic (i.e. not the test) is only hit if `blockOnResponse`
is set to `true`, leaving it in is low-risk.

Relates #263572.
Relates #263575.
2025-08-27 10:24:04 -07:00
Rob Lourens
a9ca87f882 Reenable integration test (#263181)
Some things have changed, hoping this is more stable now
Fix #242671
2025-08-24 13:41:59 -07:00
Ross Wollman
58c4c3bf4b Wait for agent loop to finish in automation (#262370)
* add `workbench.action.chat.open::waitForComplete`

* s/waitForCompletion/blockOnResponse

* cleanup tests

* remove unused comment

* Apply suggestion from @connor4312

Co-authored-by: Connor Peet <connor@peet.io>

* fixup tests

* don't block test loop on invokeTool

* Revert "don't block test loop on invokeTool"

This reverts commit d8d16dbe79.

* fix tool confirmation test

* attempt to account for the flip of isPendingConfirmation

* [DEBUG] debug CI flake

* register tool so it exists in all test envs

* finish configuring custom tool

* run test in seperate chat windows

* revert debug changes

* remove timeout dep

* fix assertion

* cleaup tests by examining output of command directly

---------

Co-authored-by: Connor Peet <connor@peet.io>
2025-08-20 10:13:48 -07:00
Logan Ramos
f6b2bec410 Modify LM api based on feedback (#261645)
* API feedback

* Some further API cleanup

* Some API stuff

* Try more cleanup

* CI please pass

* READONLY
2025-08-14 16:59:44 -04:00
Logan Ramos
8551a1d51d Finalize the bring your own key api (#255892)
* Start small

* start on new byok api

* Some more api work

* Hook up more of the API

* A single file with no errors yay!

* Some cleanup

* Slow and steady progress

* More code

* Add resolve

* Hate everything

* More progress on rewriting id

* Some error fixing

* Fix null service

* Use claude to fix tests

* Fix tests

* Fix tests

* More test fixing

* Some setup

* Some model picker stuff

* Fix model picker with new BYOK api

* Remove support for contirbuting to mdel picker action bar

* Adjust to allow for user prompting

* Add event

* Fix conflicts
2025-07-18 13:42:55 -04:00
Rob Lourens
714f54156f Add editedFileEvents (#246996)
* Start plumbing working set events

* more

* More fixes

* Update tests
2025-04-20 16:54:07 +00:00
Rob Lourens
a4ee2666f0 Store chat sessions in fs (#243670)
* Start on storing chat sessions on fs

* More

* More ChatSesssionStore work

* More changes

* More fixes

* Avoid layer break

* Handle clear session, block shutdown while saving, handle other cases

* Key name

* Fix build error

* Tweaks

* Don't show migrated empty sessions in hsitory

* Comment out unused transfer code for now

* Fix test
2025-03-18 01:07:18 +00:00
Rob Lourens
5e5183a362 🔪 DELETE chatVariableResolver API proposal 💀 (#239755)
* 🔪 DELETE chatVariableResolver API proposal 💀

* Remove import

* Remove chat variable test

* Bump distro
2025-02-07 19:03:21 +01:00
Johannes Rieken
04eff405cf restore history sharing rules for agents (#233930) 2024-11-15 18:48:35 +01:00
Johannes Rieken
434e2d6b5c stuff (#233905)
* align chat history filtering

* tweak styles of hunk menu

* fix tests
2024-11-15 17:32:37 +01:00
Rob Lourens
d9f379b135 Finalize ChatRequest#model (#231811)
* Finalize ChatRequest#model
Fix #230844

* Register model to fix tests
2024-10-21 16:42:23 -07:00
Rob Lourens
36257be8ef Add ChatTitleProvider, updates to Show Chats (#225997)
* Sort chat history entries by lastMessageDate

* Add date labels to chat history picker

* Remove unused dynamic 'isDefault'

* Add ChatTitleProvider

* Disallow deleting and moving active chats

* Add test for new data normalization

* Fix build and add test

* Fix new test
2024-08-19 15:40:38 -07:00
Rob Lourens
14ebfdc345 Add variable 'isSlow' (#212657)
* Add variable 'isSlow'
Since 'codebase' doesn't really work as a reference, I'm only making accessible to our agents for now

* fix

* Check for slow variables in parser as well
2024-05-15 17:40:21 -07:00
Rob Lourens
6643db734a Add chat variable id and rename to 'references' (#212480)
* Add chat variable id

* Rename 'variables' to 'references'

* Replace other 'variables' usages

* Fix tests
2024-05-13 14:30:14 -07:00
Rob Lourens
b8292ab7f2 Replace ChatResolvedVariable with ChatValueReference (#211665)
* Replace ChatResolvedVariable with ChatValueReference
Participant API
#199908

* Fix integration test

* any -> unknown
2024-05-01 09:14:54 -07:00
Rob Lourens
eb736c18c2 Limit chat history to messages with the current participant (#209898)
* Limit chat history to messages with the current participant

* Fix build error

* Fix build for real
2024-04-09 08:56:52 -07:00
Rob Lourens
ed6c6d3f28 Kill "interactive session provider" DEAD (#209700)
* Reduce chat provider usage

* Clear out IChat props

* Delete interactive session provider API

* Totally remove static chat provider registration

* Clean up onDidRegisterProvider events

* Remove provider ID references from model

* Eliminate many 'providerId' references

* Simplify view registration

* Clean up participant-specific actions

* Delete getProviderInfos

* Rename context key

* Fix tests

* Fix action label

* Fix view title

* Fix test

* Fix test

* Fix integration test

* Remove more providerId

* Add API stub to make this compatible with the existing Copilot Chat
2024-04-07 21:06:43 -07:00
Rob Lourens
75e751380f ChatRequestHandler should allow returning void (#208349)
Fix #205835
2024-03-22 00:57:34 +01:00
Rob Lourens
042c0893d9 Handle duplicate chat participant names (#208142)
* Enable duplicate chat participant names
#208103

* Register participants with an ID

* Update participant history in API

* Changes to dupe chat suggest widget, and fix serialize/deserialize

* Tweaks

* Test fixes

* Fix tests

* Test fixes

* Fix integration test
2024-03-20 16:44:03 -07:00
Rob Lourens
2752932c07 Remove sendInteractiveRequestToProvider from interactive API (#206623)
* Remove `sendInteractiveRequestToProvider` from interactive API

* Fixes
2024-03-01 07:41:22 -08:00
Rob Lourens
bd79cb3a46 Change FollowupProvider to take a ChatContext. (#206611)
* Change FollowupProvider to take a ChatContext.
Also fix #205761

* Update test
2024-03-01 07:32:52 -07:00
Rob Lourens
00abefa3e2 Add chatParticipant contribution point (#206474)
* Add package.json registration for chat agents

* Update for tests

* Separate static and dynamic chat agent parts

* Handle participant registration correctly

* Fix tests

* Fix test

* Remove commented code

* Fix more tests

* Pluralize

* Pluralize test contribution
2024-02-29 06:52:12 -08:00
Rob Lourens
61f447b79a More small chat API fixes (#205901)
* Fix #205811

* Fix #205807

* Make description optional

* Fix

* fix test
2024-02-21 12:57:18 -08:00
Rob Lourens
efc04b885e New proposal for chat variable resolver (#205572)
* Tweak ChatFollowup

* Remove API TODOs

* New proposal for chat variable resolver

* Bump distro

* Enforce same-extension followup

* Add participant proposal to integration test folder

* Allow no participant for a followup
2024-02-19 20:52:19 +01:00
Rob Lourens
05bf957b31 Rename the chat agent API to "participant" (#205477)
* Start renaming chat API from "agent" to "participant"

* Rename the rest of the API

* Rename in integration test

* Update integration test api proposals

* Bump distro
2024-02-19 14:53:58 +01:00
Rob Lourens
4ba66bf35e Chat API: add 'command' to response history (#205377) 2024-02-16 09:09:04 -07:00
Rob Lourens
c2316194e2 Get rid of history2, variables2 (#205124)
* Get rid of history2

* Remove prompt2 and variables2

* Clean up variables2/prompt2

* Fix tests

* Fix ranges

* Fix test
2024-02-13 11:33:21 -08:00
Rob Lourens
b2f1748501 Rename "subcommand" to "command" (#204911)
* Rename "subcommand" to "command"

* Fix build
2024-02-10 13:58:18 -08:00
Rob Lourens
b49c1c1170 Add ChatAgentResult2#metadata (#204851)
* Support serializable metadata on 'result' object from chat agent

* Fix 'errorDetails' on the VM

* Fix acceptAction, get rid of generic parameter on ChatAgent

* Use result metadata for followups

* Use serialized result for history

* Don't share metadata between agents

* Add a test for result metadata

* Fix build
2024-02-10 05:40:01 -08:00
Rob Lourens
5e3a912d7f Move welcome message to chat agent (#204163)
* Move welcome message provider to default agent

* Remove welcome message/sample questions from interactive provider

* Remove provider display name and icon

* Add default agent for tests

* And proposal
2024-02-02 18:41:13 +01:00
Rob Lourens
c15e48bc27 Reenable chat test (#203706)
I think this isn't an issue with the test- every time it fails, we see "The Web Worker Extension Host did not start in 60s". The chat tests are the first tests, and so they just time out due to being affected by the slow startup. That EH timeout issue looks old.
Fix #203429
2024-01-29 16:51:06 +01:00
Johannes Rieken
290a1153b8 disable frequently failing chat-suite (#203430)
https://github.com/microsoft/vscode/issues/203429
2024-01-25 11:52:51 +01:00
Rob Lourens
63349889d9 Avoid "slash command" name in agent API (#202729)
* Avoid "slash command" name in agent API

* Fix reference

* Fix
2024-01-18 21:05:28 +01:00
Rob Lourens
7cbff1919e Chat code cleanup (#198022)
* Clean up some obsolete chat API
Start deleting the interactive session provider, use agents only

* Delete old chat agents API

* Remove providerRequestId

* Remove unused stuff from interactive.d.ts

* Get rid of chat session state saving

* Fix test

* I guess this type was in use
2023-11-12 06:44:14 +01:00
Rob Lourens
6c02f61149 Fix variables in chatAgents2 API requests, add tests (#195529)
* Fix variables in chatAgents2 API requests

* Enable file references and the 'used references' section by default in Insiders

* Add integration tests for chat

* Fix equality

* fix test
2023-10-13 06:27:30 +02:00