Commit Graph

12708 Commits

Author SHA1 Message Date
Benjamin Pasero
73fd3f1103 fix build (#157217)
* fix build

* fix compile

* flaky

* .
2022-08-05 09:16:20 +02:00
Matt Bierner
07e45c5a71 Fix package version (#157202)
Not sure why this was not caught by earlier builds
2022-08-04 21:40:06 -07:00
Matt Bierner
b012216211 Fix markdown images having duplicate ids (#157177)
Fixes #153144
2022-08-05 06:31:42 +02:00
Tyler James Leonhardt
d859b334cb We only need to wait on the input box for un-supported environments (#157157)
we only need to wait on the input box for un-supported environments
2022-08-04 23:55:51 +02:00
Matt Bierner
c5f857f0cf Remove skipped webview tests (#157155)
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
2022-08-04 23:49:05 +02:00
Matt Bierner
68912bd844 Use 'import type' for '@jupyterlab/nbformat' (#157153)
This is a type only dev dep so we should prevent referencing it as a value
2022-08-04 23:46:53 +02:00
Matt Bierner
0c78644c6e Use tabs to figure out when to report JS/TS diagnostics (#157117)
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
2022-08-04 10:46:56 -07:00
Raymond Zhao
9f80085795 Fix language-specific tab expansion and polish (#157035)
* Fix language-specific tab expansion and polish

Fixes #156075

* Add back check
2022-08-03 16:31:19 -07:00
Peng Lyu
5d4730dbec Merge pull request #157029 from microsoft/rebornix/notebook-no-test-skip
No skip tests in notebook api/kernel
2022-08-03 14:48:09 -07:00
rebornix
336373dfc5 bring back kernel execute test 2022-08-03 10:14:45 -07:00
rebornix
82314b9ed5 remove outdated test 2022-08-03 10:08:02 -07:00
Michael Lively
61e8687fa3 Notebook Cells re-render upon changes to metadata (#156917)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* update condition to re-render cells, now includes metadata changes

* notebook cells now re-render upon metadata changes

* fix missing metadata update

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2022-08-03 09:46:12 -07:00
Matt Bierner
784de60319 Add activeWebviewPanelId context key (#156944)
Fixes #156942

This context tracks the id of the active webviewPanel
2022-08-03 07:03:33 +02:00
Peng Lyu
7833aade5a Separate notebook kernel and api test (#156946)
* Separate notebook kernel and api test.

* no need to test reopen dirty document
2022-08-03 07:03:10 +02:00
Peng Lyu
418b944396 debt: move insert command towards unit tests. (#156929) 2022-08-03 01:42:53 +02:00
Matt Bierner
8b27dcb1f8 Pick up latest markdown language service (#156933) 2022-08-02 23:31:58 +02:00
Peng Lyu
4b551dab35 Turn on notebook document test. (#156932) 2022-08-02 23:20:00 +02:00
John Murray
7e400c7137 Provide valid markdown-specific default for editor.quickSuggestions setting (#156686) (#156689)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-08-02 13:51:41 -07:00
Matt Bierner
e3267b75c6 Fix onDidDeleteMarkdownDocument not hooked up (#156913) 2022-08-02 22:18:08 +02:00
Matt Bierner
1097f3e440 Use finalized vscode-languageserver version (#156910)
Use finalized vscode-languageserver build
2022-08-02 15:51:07 -04:00
Matt Bierner
3a5a458643 Clear markdown diagnostics when file is closed (#156912) 2022-08-02 20:32:02 +02:00
Matt Bierner
424fe151f1 Add patch for enabling new TS plugins on web approach (#149186)
* Add patch for enabling new TS plugins on web approach

https://github.com/microsoft/TypeScript/pull/47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR

* Update for new files names
2022-08-02 20:00:22 +02:00
Peng Lyu
fded572606 Re #155587. Move undo/redo to unit tests. (#156849) 2022-08-02 09:28:37 +02:00
Tyler James Leonhardt
13066d79e3 up timeout to 5min (#156846) 2022-08-01 17:15:52 -07:00
Matt Bierner
cf43717e18 Pick up new md grammar (#156844)
Also updates themes to better handle https://github.com/microsoft/vscode-markdown-tm-grammar/issues/4
2022-08-01 17:13:55 -07:00
Matt Bierner
f0434c0960 Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Peng Lyu
f31a88e161 Remove move cell integration test (#156825)
* Remove move cell integration test

* 💄

* test didn't really run locally
2022-08-01 16:54:49 -04:00
Peng Lyu
f4433141c7 Move off asPromise (#155920)
* Troubleshoot asPromise

* Update batch edit api

* Update workspace edit

* fix #156663

* 💄
2022-08-01 21:09:41 +02:00
Matt Bierner
97c8a97261 Include globally enabled TS Server plugins when reporting issues (#156510)
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
2022-08-01 10:44:46 -07:00
Matt Bierner
4eef7a94e1 Tell users about enabled TS plugins on crash (#156514)
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
2022-08-01 10:44:33 -07:00
Babak K. Shandiz
2150470804 🎁 Add option to disable script hovers in package.json files (#156752)
* ⚙️ Define `npm.scriptHover` configuration parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🌐 Add localized description for `npm.scriptHover` config parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🎁 Respect `npm.scriptHover` config parameter in `NpmScriptHoverProvider`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-08-01 09:43:31 -07:00
Alex Ross
12b08be500 Only use the commit in share link when upstream (#156658)
Fixes #156627
2022-07-29 12:30:05 +02:00
Michael Lively
6fbee10cc1 more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash 2022-07-28 11:53:51 -07:00
Tyler James Leonhardt
4017fd126f Show quick pick when redirect fails to complete redirect to be more robust (#156515)
* show quick pick when redirect fails to complete redirect to be more robust

* matt feedback
2022-07-28 10:26:18 -07:00
Matt Bierner
06f8d52e37 Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Matt Bierner
00bb9bdefc Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
Martin Aeschlimann
857412ab10 devcontainer schema: handle deprecated properties (#156425) 2022-07-27 20:27:47 +02:00
Alex Ross
a3b712e04e Create a insiders.vscode.dev link when I use insiders for sharing (#156436)
Fixes #156255
2022-07-27 10:55:08 -04:00
Matt Bierner
241c770203 Exclude esbuild files from build (#156362) 2022-07-27 09:32:07 -04:00
Ladislau Szomoru
d01945923c Git - Fix regression with Commit action button icon (#156417)
Fix regression with Commit action button icon
2022-07-27 13:11:07 +02:00
Ladislau Szomoru
e210bbfea4 Git - fix edge case during rebase (#156410)
Fix blocking issue while resolving conflicts during rebase
2022-07-27 12:03:47 +03:00
Matt Bierner
9cf2fabdd6 Rename editor.dropIntoEditor.enabled setting (#156381)
Fixes #156344
2022-07-27 06:44:44 +02:00
Michael Lively
53c3028c47 add notebook-out to .gitignore 2022-07-26 12:29:23 -07:00
Michael Lively
2077ae5120 fix package.json/esbuild.js for files in publish 2022-07-26 12:19:27 -07:00
Matt Bierner
cf145a83ac Enable safe inline svg tags in trusted html (#156216)
Enable safe svg tags in trusted html

From cce00ac40d/src/tags.js (L124)
2022-07-25 16:32:10 -07:00
易良
fbdc848c29 fix: typos (#155310)
* fix: typos

* chore: revert formatting changes

* fix: Remove redundant blank lines
2022-07-25 15:41:30 -07:00
Martin Aeschlimann
0b7a99104d theme-seti icon Laravel .blade.php lose php icon when installing blade related extension (#156204)
theme-seti icon Laravel .blade.php lose php icon when installing blade related extension. Fixes #153410
2022-07-25 16:35:30 -04:00
Raymond Zhao
52a71a1843 Make some Emmet settings language-overridable (#156184)
Fixes #156075
2022-07-25 20:00:36 +02:00
Martin Aeschlimann
361215a168 seperate out devContainer schemas for vscode & codespaces (#156170)
* seperateout devContainer schemas for vscode & codespaces

* fix for vscode schema
2022-07-25 18:17:23 +02:00
Matt Bierner
68cbaa708e Pick up new version of markdown-language-server (#156010)
This fixes md diagnostics and links for multiroot workspaces
2022-07-24 22:22:03 -07:00