Commit Graph

584 Commits

Author SHA1 Message Date
Jakob Fahr
9f2ca57b05 Fix #82199, numbers hard to read in light theme markdown preview (#82450) 2019-10-14 11:47:53 -07:00
Matt Bierner
acdbc65fcc Update highlight js and md versions 2019-10-12 20:14:07 -07:00
Matt Bierner
21ba436c51 Fix one more case of #81320
The markdown link people write may be uri encoded. We need to decode these before trying to open them
2019-10-09 13:01:30 -07:00
Johannes Rieken
32b2861498 workaround - remove as const to make webpack happy... 2019-10-07 14:17:39 +02:00
Matt Bierner
8e944be15c Support jsonc for code block type with highlightjs 2019-10-04 17:57:33 -07:00
Matt Bierner
36aa903d5a Rewrite how we handle links in the md preview
Try to simplify how we resolve links:

- Move most logic out of the preview itself.
- Simplify the amount of rewriting we do in the markdown engine
2019-10-04 17:57:33 -07:00
Matt Bierner
ef698fa6cd Make markdown refresh more stable
Fixes #80680

- Always sync the current preview line number with the editor, even when `scrollEditorWithPreview` is false

- If the md file is focused and refresh is called, do not try resetting the current line to match the editor file. This mainly effects the case where `scrollEditorWithPreview` is false
2019-10-03 13:46:31 -07:00
Matt Bierner
2235ebf5db Handle new vscode-resource format for md linkes
Fixes #81849

This is a safer scoped fix, not the best one. Will look into removing most of this uri munging for october
2019-10-02 14:09:38 -07:00
Matt Bierner
8f6108beea Removing unused .mac style rule for rendered markdown 2019-09-19 16:26:33 -07:00
Konstantin Solomatov
316fd807fe remove docIndex in markdown language extension (#80933) 2019-09-16 10:50:20 -07:00
Johannes Rieken
9aab002dea push workaround for ts-loader weirdness 2019-09-12 09:59:31 +02:00
Matt Bierner
153e063486 Fix markdown preview refresh command potentially resetting preview scroll position to top if focused on preview
Fixes #80680
2019-09-11 20:50:52 -07:00
Matt Bierner
a835f40c5b Remove deprecated scrollPreviewWithEditorSelection setting 2019-09-11 14:28:22 -07:00
Konstantin Solomatov
5db460d2fe Fix activation of linters on unopened files caused by markdown plugin (#80506)
* Fix bug causing a large number of linters to be activated due to the markdown extension opening TextDocuments during indexing

* indentation problem

* code review by @OmarTawfik

* revert changed file

* Code review: use nodejs' Buffer

* fix ineffcient code
code review comments

* introduce SkinnyTextLine

* refactor redundant code

* revert changed files

* formatting

* remove empty line
2019-09-11 11:39:08 -07:00
Matt Bierner
2fe62e7dfe Use the document that contains the md link as the resource for getting config, not the target document 2019-09-10 16:31:53 -07:00
Matt Bierner
28c5988f47 Renaming setting names 2019-09-10 16:20:01 -07:00
Matt Bierner
728ee3aa73 Extract 2019-09-10 16:06:08 -07:00
Salvador Cabrera Lozano
c307d73664 Fix for #26659. (#80227)
* Fix for #26659.

Clicking on a  local file link will open up the editor on a separate editor group (new or reuse existing one).

* Fix for #26659: Add way to open Markdown links in a different editor group

Adding "markdown.editor.openMarkdownLinks" setting to specify where
links to markdown files should open (current editor group by default).
2019-09-10 15:58:27 -07:00
Matt Bierner
7226e32d1b Use shared tsconfig for markdown preview
Fixes #80121
2019-09-09 10:20:56 -07:00
Matt Bierner
7a00ddf9f8 Format files for 3.6
Fixes #80118
2019-09-02 21:29:05 -06:00
Matt Bierner
a66e9d4835 Don't dispose markdown preview emitters before firing events
Fixes #79827
2019-08-26 13:40:07 -07:00
Matt Bierner
962158e164 Fix yarn lock 2019-08-21 18:15:49 -07:00
Matt Bierner
4f5ef27990 Pull in latest markdown-it version 2019-08-21 18:03:50 -07:00
Matt Bierner
646d4ddb75 Use _register 2019-08-20 15:07:25 -07:00
Matt Bierner
e44d9a2888 Rename parameter 2019-08-20 11:28:31 -07:00
Matt Bierner
1802be3b70 Always require an argument to command
#75612
2019-08-20 11:26:49 -07:00
Matt Bierner
f509f7f141 Rename command
#75612
2019-08-20 11:25:42 -07:00
Matt Bierner
7c3aeb10a2 Merge pull request #77151 from connor4312/feat/markdown-render-command
feat(markdown): add render command (fixes #75612)
2019-08-20 11:23:47 -07:00
Matt Bierner
c5dc9d16be Finalize asWebviewUri api
Fixes #79242

As discussed, renames `toWebviewResource` to `asWebviewUri` to be consistent with the `asAbsolutePath` api naming
2019-08-19 20:18:26 -07:00
Matt Bierner
b9b5692e27 Support using csharp in markdown preview to identify c# code blocks 2019-08-19 09:18:22 -07:00
Salvador Cabrera
34339f92c4 Fix: Markdown Preview scroll remains same after clicking on some other link #78465
Improves the behavior on how markdown preview behaves when clicking a link
2019-08-19 09:35:06 -05:00
Matt Bierner
1bbf3b3fa6 Add telemetry+warning for webviews that don't have a content security policy
Fixes #79248
2019-08-15 15:16:39 -07:00
Matt Bierner
e1d3dd53d1 Mark static readonly 2019-07-22 16:24:53 -07:00
Neonit
c5ab082ed7 Adjust Code Tab Size to 4 in Markdown Preview
Sets the tab size to 4 in the Markdown preview for code blocks in Markdown documents. I consider a tab size of 4 being standard and the default of 8 being unbearable. The few people, if any, using a different tab size than 4 can use the custom markdown preview style feature, if it is going to be fixed anytime (https://github.com/microsoft/vscode/issues/77290).

[`tab-size` is still marked *experimental* in the MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/tab-size), but it doesn't hurt, if not supported. However, in the used Chromium version it is supported.
2019-07-22 11:49:04 +02:00
Pine
bfd274a23b Merge pull request #77546 from microsoft/pine/builtin-array-setting
Use array of string for applicable builtin settings
2019-07-18 14:03:59 -07:00
Pine Wu
d44f9dae34 Use array of string for applicable builtin settings 2019-07-17 15:07:31 -07:00
Matt Bierner
b850405aa6 Merge pull request #76647 from masliu/master
Save resourceColumn for previews, fixes #74008
2019-07-17 16:01:46 -07:00
Matt Bierner
12e482f532 Remove markdown.tmbundle from markdown language features extension
The grammar is contributed by the language basics extension
2019-07-12 11:59:50 -07:00
Connor Peet
3c42f56552 fixup! render a string as well 2019-07-11 11:24:28 -07:00
Connor Peet
7dd109c2df feat(markdown): add render command (fixes #75612)
This adds a command which renders the provided document, or the active
editor if one is provided. Following the pattern of some of the preview
commands, it returned `undefined` if there's no document provided and
no active text editor. Otherwise, seems to work...

```ts
const html = await vscode.commands.executeCommand<string>('markdown.render');
```

A way to render arbitrary strings in addition to documents may be useful at
some point in the future. However, I didn't implement that here as that'd
require some refactoring of the markdown engine. If we're interested though
I could certainly give that a shot.
2019-07-10 15:49:06 -07:00
Matt Bierner
4c07744817 Make sure we handle loading of markdown resources from UNC workspace correctly
Fixes #48403
2019-07-09 15:52:43 -07:00
Matt Bierner
c01a3a718d Use clearer name for csp webview element
#76489
2019-07-09 11:45:20 -07:00
Matt Bierner
a558a9504a Adding toWebviewResource api
For #76489
2019-07-08 18:38:47 -07:00
masliu
173d010b0a Rename sourceViewColumn to resourceColumn 2019-07-04 22:29:23 -04:00
masliu
47f9ed5d22 Save source viewColumn for previews, fixes #74008 2019-07-04 21:37:28 -04:00
Miguel Solorio
0f295fd07b Update markdown preview icon to have bevel edges 2019-07-03 15:05:45 -07:00
Matt Bierner
9e7bb2c881 Support image/* data uris in markdown preview
Fixes #76080
2019-07-01 15:57:35 -07:00
Miguel Solorio
05ee90f7fd Merge remote-tracking branch 'origin/master' into misolori/new-icons 2019-06-28 11:05:33 -07:00
Miguel Solorio
9f7dd28e6d Update icons 2019-06-26 15:46:15 -07:00
Matt Bierner
be41fd02a2 Show document link tooltip first and put click instructions in parens
Fixes #76077

This change also update our standard link hovers to follow this format
2019-06-25 16:38:50 -07:00