Commit Graph

171 Commits

Author SHA1 Message Date
Megan Rogge
a2f5ec29b2 Revert "Revert "be sure that terminal target gets set for the instance (#138875)""
This reverts commit 8605d7aeff.
2021-12-13 17:08:29 -06:00
Daniel Imms
8605d7aeff Revert "be sure that terminal target gets set for the instance (#138875)"
This reverts commit 578eb0d4ae.
2021-12-13 08:15:32 -08:00
Megan Rogge
578eb0d4ae be sure that terminal target gets set for the instance (#138875) 2021-12-10 14:51:45 -08:00
Daniel Imms
866b9df390 Wait for quick input to open again after runCommandWithValue
Fixes #138658
2021-12-10 10:59:40 -08:00
Rob Lourens
9893857d4b Handle "clear search results" cancelling running search
Fix #138841
2021-12-10 10:51:26 -08:00
Rob Lourens
e5637ce9af Fix #138748 2021-12-09 10:00:25 -08:00
Benjamin Pasero
27e38a8e27 smoke - always create screenshot on failure on desktop 2021-12-09 09:51:55 +01:00
Benjamin Pasero
158bd2507e smoke - always have a logger 2021-12-09 08:48:42 +01:00
Benjamin Pasero
15415b6de6 smoke - align killing 2021-12-09 08:03:48 +01:00
Benjamin Pasero
ec3ba7a320 smoke - rewrite killing 2021-12-09 07:55:25 +01:00
Benjamin Pasero
acc0803f38 cleanup automation 2021-12-09 07:03:29 +01:00
Rob Lourens
1341ca3d7f Remove timeouts in search smoketest.
Improvements came from waiting for search to complete before clicking buttons, clearing previous results before starting the search, and adding a retry around the clicking.
2021-12-08 15:34:35 -08:00
Benjamin Pasero
18cba4882d smoke - more logging 2021-12-08 15:23:27 +01:00
Benjamin Pasero
64562e2a0e smoke - reimplement logging 2021-12-08 14:13:41 +01:00
Benjamin Pasero
fbad065eea Playwright: record a trace per failing test, not suite (#138600)
* smoke - record traces per test and not entire suite

* smoke - only persist failing tests

* smoke - cleanup

* smoke - more logging

* smoke - push a test failure to proof the point

* smoke - switch back to chrome for smoke tests

* smoke - warn when exit takes 10s

* Revert "smoke - push a test failure to proof the point"

This reverts commit e572a0c40d.
2021-12-08 10:09:30 +01:00
Tyler James Leonhardt
224701f74d try remove timeouts in smoke tests for quickaccess (#138615) 2021-12-07 12:25:35 -08:00
Benjamin Pasero
13c0ed811e 🆙 playwright & set trace names (#138539) 2021-12-06 19:42:05 +01:00
Benjamin Pasero
ff970e88e5 Revert "smoke - 🆙 retry timeout"
This reverts commit d60b844aa3.
2021-12-02 07:38:04 +01:00
Benjamin Pasero
9d427e4df4 smoke test tweaks
- remove timeout on shutdown
- log exactly where time is spend on shutdown (web)
- stop spawning code when terminated
2021-12-02 07:34:13 +01:00
Benjamin Pasero
d60b844aa3 smoke - 🆙 retry timeout 2021-12-01 11:34:25 +01:00
Megan Rogge
7b3078d931 fix #137795 2021-11-30 12:48:58 -08:00
Megan Rogge
005947e3b8 fix #137722
fix #137808
2021-11-30 11:54:28 -08:00
Megan Rogge
e89889fe54 fix #137799 2021-11-30 11:21:01 -08:00
Megan Rogge
18725fc147 set default profile to pwsh for only windows for #137225 2021-11-30 10:57:59 -08:00
Megan Rogge
4be98a3bce set default to pwsh instead of bash for #137725 2021-11-30 10:21:15 -08:00
Daniel Imms
d5bfd6d31c Remove unneeded logs in test 2021-11-29 11:48:14 -08:00
Daniel Imms
e208c8604e Remove timeout from automation terminal util
I don't believe this was ever required, awaiting writeInTerminal should make sure the
data event is triggered in xterm, the following enter should just trigger another data
event. This doesn't guarantee it was accepted by the process yet, just that xterm.js
emitted the event.

Part of #137847
2021-11-29 11:46:57 -08:00
Benjamin Pasero
1af6cb0edc smoke test tweaks 2021-11-29 17:53:11 +01:00
Benjamin Pasero
18c6692316 tests - print main process pid when killing fails 2021-11-29 13:48:27 +01:00
MalikIdreesHasanKhan
595d893fdc Fixed typos. (#135729) 2021-11-29 11:32:14 +01:00
Benjamin Pasero
e71b28a444 Smoke test lifecycle changes (#137969)
* rewrite teardown

* 💄

* avoid spam errors

* 💄

* split spawning browser from electron

* await copyExtension

* cleanup

* refactor methods

* cleanup

* cleanup

* cleanup

* 🆙 deps
2021-11-28 10:30:52 +01:00
Benjamin Pasero
df4b5d6d04 smoke - strengthen shutdown path 2021-11-26 18:08:27 +01:00
Benjamin Pasero
a11814c57a smoke - switch away from potentially flaky editors.selectTab method 2021-11-26 09:22:19 +01:00
Benjamin Pasero
6f2239307b Smoke test tweaks (#137809)
* smoke - move data migration tests into one and align

* fix app starting

* `createWorkspaceFile` is not async

* 💄

* support screenshot on failure even for stable app

* smoke - try to remove timeout (#137847)

* improve exit call
2021-11-25 14:37:22 +01:00
Rob Lourens
2932ec095d Add retry to quickaccess tests
Fix #137733
2021-11-23 15:35:48 -08:00
Daniel Imms
ef440e563d Merge remote-tracking branch 'origin/main' into tyriar/persist_tests 2021-11-23 12:47:36 -08:00
Benjamin Pasero
954ce2c3f4 proper await exit 2021-11-23 10:31:46 +01:00
Megan Rogge
4e303fcc52 fix #137590 2021-11-21 10:04:21 -08:00
Daniel Imms
5dec5256d7 Add some detach/attach tests 2021-11-19 10:33:43 -08:00
Megan Rogge
f66bc86da8 add terminal editor and tab smoke tests (#137393)
* Add a bunch of tests

* tweak tests

* add profile tests, now breaking (no profiles showing up)

* uncomment tests

* update expected

* fix test

* merge

* all passing

* bunch of improvements

* improve readability

* all should be passing and cleaned up

* all passing

* fix #137243 and clean-up

* remove .only

* fix #137247

* get rid of enum

* see if this fixes timing issue

* use keybinding for show terminal instead

* remove delay, implement better accept function

* get rid of unneeded index

* try something else

* wait for empty editor to be active

* remove .only

* decrease redundancy in names

* re-add xterm selector

* try something else

* undo change that broke things worse

* add terminal-tabs test

* all tabs tests passing locally

* kill all

* await before running each

* fix tests

* remove .only

* try waiting for focused xterm

* remove .only

* clean up

* 🧹

* fix profiles tests by using this.app.props

* revert to use default shell

* re-add conditional

* Get tests passing on WebKit

On WebKit the smoke tests were failing because the quick pick was
triggering a focus event on the terminal after the blur event had
already happened, this caused the view service to think the terminal
was still focused when it wasn't. The fix was to reset the context key
also in IViewsService.closeView.

* Safari -> WebKit

* Prefer arrow functions

* remove beforeEach timeout

* add timeouts to contributed profile tests

* add terminal editor tests, fix #137377

* add a bunch of tests

* refactor

* get rid of profile specific command

* more polish

* refactor getTabs -> assertTerminalGroups

* fix failing test

* more polish

* remove .only

* add assertSingleTab

* remove unused import

* fix error

* fix more failures

* more changes

* fix almost all except for plus button

* fix failing plus button test

* all passing

* modify error that gets thrown

* modify error message again

* remove unused wildcard/ ANY_NAME, fix icon code

* fix icon code

* large refactor, improvements

* finish polish

* 1 failing

* get test to pass

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2021-11-18 15:11:40 -08:00
Megan Rogge
239a94cee8 remove debug log 2021-11-17 14:01:31 -08:00
Megan Rogge
00fa317c43 Add terminal profile smoke tests (#137079) 2021-11-17 14:00:01 -08:00
Benjamin Pasero
6f28593438 smoke - retry quick open search (fix #136499) 2021-11-15 07:52:12 +01:00
Daniel Imms
c65c8738f9 Copy and use IWindowDriver in PlaywrightDriver 2021-11-12 06:11:18 -08:00
Daniel Imms
634dae736e Merge remote-tracking branch 'origin/main' into tyriar/smoke_test_improvements 2021-11-12 05:45:20 -08:00
Daniel Imms
5bfaf29f2b Fix layering problem 2021-11-10 08:38:02 -08:00
Daniel Imms
6a6a1b65df Use handles in playwright driver 2021-11-10 08:03:22 -08:00
Benjamin Pasero
bef4dba21f Parcel update and CI improvements (#136830)
* 🆙 product

* 🆙 parcel/watcher

* 🆙 parcel/watcher

* tests - separate remote logs from others

* store server logs too

* more tweaks

* fix name

* error when 10s passed
2021-11-10 08:13:56 +01:00
Daniel Imms
bd98431baf Write basic terminal default profile test
Co-authored-by: Megan Rogge <merogge@microsoft.com>
2021-11-09 10:10:54 -08:00
Daniel Imms
628f486b1d Move playwright driver impl to class
Part of #136064
2021-11-09 08:45:08 -08:00