Commit Graph

90679 Commits

Author SHA1 Message Date
rebornix
79dd3eb4de dedup. 2021-11-18 16:39:06 -08:00
rebornix
865714bdcb abstract focus indicator. 2021-11-18 16:38:07 -08:00
rebornix
9680ab09a1 💄 2021-11-18 16:38:07 -08:00
rebornix
0620364b98 top insert toolbar is viewpart. 2021-11-18 16:38:07 -08:00
rebornix
680555311c updateLayout for bottom toolbar. 2021-11-18 16:38:06 -08:00
rebornix
b18571c673 cellpart 2021-11-18 16:38:06 -08:00
Rob Lourens
d0f6f16a1e Merge pull request #133637 from suzmue/focused
clear focused thread if it does not exist
2021-11-18 16:13:10 -08:00
Suzy Mueller
36ff562d92 use condition to check for focus 2021-11-18 19:04:02 -05:00
Suzy Mueller
4d920d6b7f Merge branch 'microsoft:main' into focused 2021-11-18 19:03:06 -05:00
Alex Dima
7fbe563c0a Fixes #136937: Do not log extension activation canceled error if the extension host is going down 2021-11-19 00:45:29 +01:00
rebornix
5d0da7b953 move decorations out of cell renderer 2021-11-18 15:44:46 -08:00
Alexandru Dima
c30fc3d415 Merge pull request #123071 from Pranomvignesh/Fix-keybindings-title
Fix keybindings title
2021-11-19 00:13:25 +01:00
Alex Dima
2c6d3b27bb Change Alt to Option only in the aria label provider and adopt change in tests 2021-11-19 00:11:57 +01:00
Megan Rogge
f66bc86da8 add terminal editor and tab smoke tests (#137393)
* Add a bunch of tests

* tweak tests

* add profile tests, now breaking (no profiles showing up)

* uncomment tests

* update expected

* fix test

* merge

* all passing

* bunch of improvements

* improve readability

* all should be passing and cleaned up

* all passing

* fix #137243 and clean-up

* remove .only

* fix #137247

* get rid of enum

* see if this fixes timing issue

* use keybinding for show terminal instead

* remove delay, implement better accept function

* get rid of unneeded index

* try something else

* wait for empty editor to be active

* remove .only

* decrease redundancy in names

* re-add xterm selector

* try something else

* undo change that broke things worse

* add terminal-tabs test

* all tabs tests passing locally

* kill all

* await before running each

* fix tests

* remove .only

* try waiting for focused xterm

* remove .only

* clean up

* 🧹

* fix profiles tests by using this.app.props

* revert to use default shell

* re-add conditional

* Get tests passing on WebKit

On WebKit the smoke tests were failing because the quick pick was
triggering a focus event on the terminal after the blur event had
already happened, this caused the view service to think the terminal
was still focused when it wasn't. The fix was to reset the context key
also in IViewsService.closeView.

* Safari -> WebKit

* Prefer arrow functions

* remove beforeEach timeout

* add timeouts to contributed profile tests

* add terminal editor tests, fix #137377

* add a bunch of tests

* refactor

* get rid of profile specific command

* more polish

* refactor getTabs -> assertTerminalGroups

* fix failing test

* more polish

* remove .only

* add assertSingleTab

* remove unused import

* fix error

* fix more failures

* more changes

* fix almost all except for plus button

* fix failing plus button test

* all passing

* modify error that gets thrown

* modify error message again

* remove unused wildcard/ ANY_NAME, fix icon code

* fix icon code

* large refactor, improvements

* finish polish

* 1 failing

* get test to pass

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2021-11-18 15:11:40 -08:00
Alex Dima
af9c88036c Merge remote-tracking branch 'origin/main' into pr/Pranomvignesh/123071 2021-11-18 23:28:03 +01:00
Alex Dima
15f1721061 Fix logging 2021-11-18 23:20:49 +01:00
Alex Dima
f6eb10d0d4 Set display:none on content widgets which don't want to be visible to avoid overflowing the editor's area with invisible dom nodes (see #122370) 2021-11-18 23:18:33 +01:00
Alex Dima
d7f92d9f14 Fixes microsoft/monaco-editor#2339: Listen to focusin and focusout and refresh the dom focus tracker state 2021-11-18 22:43:24 +01:00
Sandeep Somavarapu
65b4d89c8a clean up 2021-11-18 22:22:26 +01:00
João Moreno
6ac63ccffb Use RBAC for builds (#137473)
* build: 👷 adopt latest azure storage account

* build: 💄

* missing compilation

* iterate faster

* try using AzureCliCredential

* fix indentation

* arg

* fix build

* use MSI for storage

* fix dependency

* argh

* debug

* fix!

* bring back

* argh

* use RBAC for cosmos

* empty
2021-11-18 12:37:23 -08:00
mamphis
2eeac2f800 glyphMargin: Wrapped codicons inside parent div
This patch resolves #137436.
When multiple classes (e.g. codicon-debug-breakpoint,codicon-debug-hint)
are added they would disable the ::after content for consecutive classes
for the HTML Element.

This patch adds a parent element to the overlay and adds all classes as
seperated divs, so they can be drawn on top of each other.
2021-11-18 21:10:09 +01:00
Daniel Imms
d614b269ba Merge pull request #137464 from microsoft/tyriar/instance_service_cleanup
Refactor TerminalInstanceService
2021-11-18 11:32:49 -08:00
Benjamin Pasero
4fb4bc9dfb Update to a newer sudo-prompt library (#137467)
* 🆙 @vscode/sudo-prompt

* use @vscode/sudo-prompt
2021-11-18 19:55:37 +01:00
Daniel Imms
db65778f51 Break circular dependency between term instance/instance service
Fixes #136062
2021-11-18 10:31:40 -08:00
Daniel Imms
d2d8b74e68 Update/add docs for ITerminalInstanceService 2021-11-18 10:16:25 -08:00
Daniel Imms
0a5f68d2cc Move preparePathForShell into TerminalInstance 2021-11-18 09:57:46 -08:00
Alexandru Dima
d9b65b65d4 Merge pull request #136625 from pdrgds/main
fix #131458
2021-11-18 18:56:49 +01:00
rebornix
17c8f52cdf missing; 2021-11-18 09:54:44 -08:00
Daniel Imms
6df426e670 Create ITerminalInstance.sendPath 2021-11-18 09:54:08 -08:00
Alex Dima
a9bddd66bc Improve caching of previous find matches in the SelectionHighlighterState 2021-11-18 18:53:44 +01:00
rebornix
f9ccf968f6 specify output id in show more... 2021-11-18 09:45:16 -08:00
Johannes Rieken
e9d7fac2c7 fix https://github.com/microsoft/vscode/issues/137415 2021-11-18 18:36:47 +01:00
Daniel Imms
3a55226ba3 Move preparePathForShell into terminalEnvironment 2021-11-18 08:55:55 -08:00
Daniel Imms
7d3408de99 Consolidate convertProfileToShellLaunchConfig into instance service
Part of #136062
2021-11-18 08:45:09 -08:00
Alexandru Dima
0de4150ed5 Merge pull request #137016 from rudavko/remove-duplication-by-using-distinct
Remove code duplication by using existing utils function
2021-11-18 17:38:33 +01:00
Daniel Imms
9d7519e3eb Move get xterm ctor out of instance service
Part of #136062
2021-11-18 08:31:29 -08:00
Daniel Imms
1331a412d9 Remove unused interface members from ITerminalInstanceService
Part of #136062
2021-11-18 08:09:55 -08:00
Alex Dima
27bcdf57a7 Remove the localProcessExtensionHostStartupTimes telemetry event 2021-11-18 16:56:28 +01:00
Alex Dima
4a1a8b07ff Cement launching the extension host from a worker on the main process 2021-11-18 16:39:57 +01:00
João Moreno
acfb946ec1 ci: 👷 no need for yarninstaller task 2021-11-18 15:57:11 +01:00
Alex Dima
24ba24e329 Fixes #137337: Respect theme colors when generating CSS for scrollbars 2021-11-18 15:29:10 +01:00
Martin Aeschlimann
6651f8ab43 [json] Adapt language status indicator. Fixes #137288 2021-11-18 14:46:59 +01:00
Jay Trees
21d447ec96 Remove brackets from statements 2021-11-18 14:45:38 +01:00
Johannes Rieken
8c64e1ec31 Merge pull request #136657 from microsoft/joh/shortcut_fs
Add shortcut between file system provider and consumer
2021-11-18 12:28:30 +01:00
Benjamin Pasero
90a67d4013 fix tests 2021-11-18 09:06:29 +01:00
Benjamin Pasero
999507ad64 tests - merge keytar test into native modules test 2021-11-18 08:37:43 +01:00
Benjamin Pasero
05a71436c7 tests - lift test to browser since it has no node.js deps 2021-11-18 08:25:02 +01:00
Rob Lourens
bedf867b5b #131808 - Set up output collapsed part in cell template 2021-11-17 17:43:08 -08:00
Eric Cheng
722cbe1910 Fixed minor typos and grammar mistakes in README and CONTRIBUTING (#134282)
* changed minor typos, little grammar mistakes

* fixed minor grammar mistakes in CONTRIBUTING
2021-11-17 17:34:57 -08:00
Rob Lourens
333a215cb8 Add CellProgressBar
fix issue where progress bar doesn't appear when collapsing input while cell is running.
Also small cleanup to cell dnd in renderer
#131808
2021-11-17 15:39:14 -08:00