Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 19:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity
77,987 Commits 3,672 Branches 359 Tags
3b05017bb8ef3ae35d264c844327c898a0f4be1e
Commit Graph

206 Commits

Author SHA1 Message Date
Johannes Rieken
3b05017bb8 more 💄, more strict typings 2021-03-05 13:09:18 +01:00
Johannes Rieken
1d8493b203 💄 in mainThreadNotebooks, return types, more private, dispoable store, duplication removal, etc 2021-03-05 12:52:35 +01:00
Johannes Rieken
85c1a17b60 Merge IEditor and INotebookEditor, move editor things into notebook editor service 2021-03-05 12:17:21 +01:00
Johannes Rieken
0e94794c9d debt - remove unneccessary indirections from notebook service 2021-03-03 16:49:33 +01:00
rebornix
6643b5e520 de-dup: uri. 2021-03-02 12:34:30 -08:00
Johannes Rieken
66b7ffaabf simplify $tryShowNotebookDocument further 2021-03-02 13:07:36 +01:00
Johannes Rieken
83f4088681 notebook - simplify group/viewColumn handling when opening a notebook editor via API 2021-03-02 12:29:28 +01:00
rebornix
d7f90c7dbc re #114554. 2021-03-01 20:10:09 -08:00
Johannes Rieken
b99df4f2b6 don't pass model service to applyEdit but check model version for edit that come from extensions, fixes https://github.com/microsoft/vscode/issues/117683 2021-03-01 09:54:02 +01:00
Peng Lyu
08eac1a22d Merge pull request #117204 from microsoft/rebornix/nb-selections 
Notebook selections/CellRange
 2021-02-22 16:25:10 -07:00
Logan Ramos
413963c489 Remove editorOpenWith (#116856) 
* Move editorOpenWith to the editorService

* Remove custom editor input handling

* Fix open with API command

* adopt master properly

* Remove dnagling comment

* Address some feedback

* Cleanup region comment.

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Cleanup region comment.

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Update override typings

* Fix missing picker

* Fix bug with reopen with

* Remove duplicate import

* First round of feedback via changes
- OverrideOptions => EditorOverride
- It is safe to destructure (...) undefined
- Ensure when destructuring, override is always winning
- Not a big fan of shared builtinProviderDisplayName import

* editorservice - static DEFAULT_EDITOR_OVERRIDE_ID

* editors - introduce a editor associations registry

This moves the relevant code out of the editor service.

* cleanup editor picking

* cleanup editor delegate

* final 💄

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
 2021-02-22 17:16:15 -05:00
rebornix
ed08a14111 selections[0] is primary. 2021-02-22 10:16:57 -08:00
Benjamin Pasero
ae0a103755 :chore: address some todos 2021-02-22 10:50:07 +01:00
rebornix
dea95d3e4f map handles to cellrange in UI. 2021-02-21 22:24:20 -08:00
rebornix
1e0adc0da5 unnecessary null -> undefined. 2021-02-21 19:47:27 -08:00
rebornix
de956ce8bd differenciate selection and focus. 2021-02-21 19:35:26 -08:00
rebornix
e8966ecaa9 notebookeditor.selections 2021-02-19 17:03:33 -08:00
Johannes Rieken
4a74fa81c1 💄 2021-02-19 15:04:17 +01:00
Johannes Rieken
57cd5d4936 🪓 remove unused $acceptDisplayOrder-RPC and everything around it 2021-02-19 15:02:43 +01:00
Johannes Rieken
7e7a71d733 💄 more supportsBackup removal 2021-02-19 14:54:32 +01:00
rebornix
9c77f4d86a add NotebookDocument.save(). 2021-02-18 11:57:49 -08:00
Johannes Rieken
7bca8a91b4 send correct delta after restarting extension host, https://github.com/microsoft/vscode/issues/115698 2021-02-18 18:09:45 +01:00
Johannes Rieken
2a12fd7202 dispose more things, https://github.com/microsoft/vscode/issues/115698 2021-02-18 17:36:29 +01:00
Johannes Rieken
a246f643ee debt, copy-paste police 2021-02-18 17:27:32 +01:00
Johannes Rieken
31e3a7794d merge NotebookController#reloadNotebook into notebook editor model, remove NotebookServce#resolve and add create and fetchData "primitives", https://github.com/microsoft/vscode/issues/114263 2021-02-18 16:05:54 +01:00
rebornix
83d540c4bf 💄 2021-02-17 08:06:54 -08:00
rebornix
b3f8737839 fix #116808. 2021-02-16 16:40:51 -08:00
Johannes Rieken
974b214334 rename: resolveNotebook is openNotebook 2021-02-16 14:50:57 +01:00
Johannes Rieken
196bf678a1 reset dirty state when reverting a notebook, update extension host when dirty state of a notebook (working copy) changes 2021-02-15 11:44:51 +01:00
Johannes Rieken
52f633d19c some 💄, some API todos 2021-02-12 19:08:34 +01:00
Johannes Rieken
cc0ccaf1c0 more disposing when dispose main thread notebooks, https://github.com/microsoft/vscode/issues/115698 2021-02-12 14:34:20 +01:00
Johannes Rieken
5a7711ac92 💄 2021-02-12 14:29:06 +01:00
Johannes Rieken
ccc28e3726 Remove languages property from NotebookData and NotebookDocument 2021-02-11 14:21:40 +01:00
Johannes Rieken
9737b1aad1 move INotebookKernelInfoDto2 to protocol, separate kernel from dto, renames 2021-02-11 11:59:32 +01:00
Johannes Rieken
55d267293b have a clear separation between KernelProvider and Kernel 2021-02-11 09:59:11 +01:00
rebornix
0df177fe39 fix tests. 2021-02-04 18:33:17 -08:00
rebornix
f2b87fd6cd Extensions do not update cell outputs/metadata directly. 2021-02-04 16:35:50 -08:00
rebornix
66635b8bd6 remove unknown content change in nb text model. 2021-02-02 12:54:11 -08:00
rebornix
04abcc0338 yarn watchd does not detect interface change again. 2021-02-02 11:44:47 -08:00
rebornix
b112052169 fix #114171 2021-01-25 14:19:59 -08:00
rebornix
7468a06012 Revert "fix #114171." 
This reverts commit e32e353bfd.
 2021-01-25 10:45:27 -08:00
rebornix
e32e353bfd fix #114171. 2021-01-14 15:18:16 -08:00
Matt Bierner
f0c758bdcc Support open to side from the 'open editor with' quick pick 
Fixes #102124

This should enable open to side for custom editors and for notebooks
 2020-12-18 16:58:24 -08:00
Johannes Rieken
aa36c6211b move duplicated code into central place 2020-11-30 14:51:54 +01:00
rebornix
3f0ada11fd core action active editor context should always have a view model. 2020-11-25 14:04:02 -08:00
rebornix
23e7e2fef0 showNotebookDocument. 2020-11-24 10:29:07 -08:00
Johannes Rieken
7ec1a6899c remove transformXYZOutput 2020-11-18 11:24:10 +01:00
rebornix
2249f2aba5 fix #108406. openNotebookDocument. 2020-10-09 11:34:55 -07:00
rebornix
bb7b1ef6b8 Use the same undo redo group for notebook editing 2020-10-05 10:28:40 -07:00
rebornix
677e4bcdc4 fix content provider closure. 2020-09-21 17:32:00 -07:00