Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity
149,693 Commits 3,672 Branches 359 Tags
3bc76baebedbad2935205c4e90953f27205dd2fa
Commit Graph

45 Commits

Author SHA1 Message Date
Tyler James Leonhardt
80f75cffa0 Don't unregister built-in providers on 403 (#278890) 
related to https://github.com/microsoft/vscode/issues/278875
 2025-11-21 17:11:03 -08:00
Copilot
c6464f84b9 Remove classic Microsoft authentication implementation (#276787) 
* Initial plan

* Remove classic Microsoft authentication implementation

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Remove classic implementation

* extra space

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Co-authored-by: Tyler Leonhardt <tyleonha@microsoft.com>
 2025-11-11 23:18:53 +00:00
Tyler James Leonhardt
7e8f8e9230 Add new msal-no-broker implementation option to allow for getting rid of classic soon (#263966) 
Also, removes the redirectUri from acquireTokenSilent because MSAL was throwing because of it.
 2025-08-29 09:01:02 +02:00
Tyler James Leonhardt
7d1d412b25 default is true, fix the log (#263931) 2025-08-29 00:14:58 +00:00
Tyler James Leonhardt
b2224f2fc6 Improve logic for detection of node vs web worker extension host (#248534) 
* Use `WorkerGlobalScope` instead of `navigator` since node defines `navigator` now

* microsoft auth too

* better logic
 2025-05-09 19:37:27 +02:00
Tyler James Leonhardt
690d2be258 Clean up some dead code and add a telemetry even to track classic microsoft auth usage (#248256) 
So we can see how many people disable MSAL.
 2025-05-06 15:36:17 -07:00
Tyler James Leonhardt
a9ce0b5556 Include an ability to change the default client id (#238736) 
Include an ability to change the client id

So our migration is easy to test
 2025-01-24 16:46:50 -08:00
Tyler James Leonhardt
8eddff6613 Default to MSAL authentication 🚀 (#237920) 
Here we go. Ref https://github.com/microsoft/vscode/issues/178740
 2025-01-14 21:23:14 +01:00
Tyler James Leonhardt
c0c6b07185 Disable MSAL for now (#235048) 
Because of late breaking issues:

* https://github.com/microsoft/vscode/issues/234932
* https://github.com/microsoft/vscode/issues/234954

This also comments out the `_setupRefresh` logic since that is causing the high CPU load. I'd like to see what happens when we don't do this behavior.
 2024-12-03 01:39:32 +00:00
Tyler James Leonhardt
7ddb65bac8 Update logging & delete dead code (#234458) 
* Update logging values so the logs aren't so noisy
* Delete a bunch of dead async code
 2024-11-23 01:17:07 +01:00
Tyler James Leonhardt
d12854f6ba Default MSAL to true (#234290) 
Using new `microsoft-authentication.implementation` setting
 2024-11-20 13:15:09 -08:00
Tyler James Leonhardt
35183efe58 Revert "Rename MSAL setting" (#230164) 
Revert "Rename MSAL setting (#230142)"

This reverts commit 2a677c686b.
 2024-09-30 14:38:38 -07:00
Tyler James Leonhardt
2a677c686b Rename MSAL setting (#230142) 2024-09-30 19:25:47 +02:00
Tyler James Leonhardt
e1db90f81d Add logging for deciding on MSAL (#226112) 
so it's clear why
 2024-08-20 18:28:02 -07:00
Tyler James Leonhardt
c125b90d41 Add experimentation to Microsoft auth (#226107) 
* Add experimentation to Microsoft auth

So that we can gradually roll out MSAL support.

* correct order
 2024-08-20 17:17:15 -07:00
Tyler James Leonhardt
44464d7ccd Fix reload modal logic when turning on/off MSAL (#225446) 
This wasn't firing before. This fixes that.
 2024-08-13 00:24:18 +02:00
Tyler James Leonhardt
70d27743ac Ability to use MSAL in the Desktop (#225272) 
* Ability to use MSAL in the Desktop

* add comment about MSAL workaround
 2024-08-09 12:18:34 -07:00
Tyler James Leonhardt
5d7157cb03 Implement getAccounts API over getSessions (#215874) 
And plumb that through to the Microsoft auth provider
 2024-06-16 18:12:37 -07:00
Tyler James Leonhardt
41e940f76f Use SequencerByKey to sequence operations of the same set of scopes (#192638) 
The idea here is... if a token is currently being refreshed, well then getting a token of those scopes should wait for that to finish.

Core has a really nice `SequencerByKey` for exactly this kind of thing, and so I've stolen that and started to organize the code with a `common` folder.

Oh, I also noticed we were sorting twice and fixed that to only sort once.

ref https://github.com/microsoft/vscode/issues/186693
 2023-09-09 07:09:20 +02:00
Tyler James Leonhardt
dd2441f7ba Polish Sovereign Cloud support (#184634) 
* Use `@azure/ms-rest-azure-env` as official reference of endpoints
* Allow better configuration of custom clouds (these are new so it is ok to change the settings without migration)

Also clean up:

* querystring -> URLSearchParams (getting rid of a package dependency in the web)
* handle `workbench.getCodeExchangeProxyEndpoints` in one place
 2023-06-08 12:39:29 -07:00
Tyler James Leonhardt
bede6ba243 Instrument Microsoft account type (#180573) 
So we can see if folks are using MSA or AAD accounts. Also, this cleans up some dead code.

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3903
 2023-04-21 14:23:34 -07:00
Tyler James Leonhardt
3a02bc9de1 Updates from the rename (#179901) 
* Updates from the rename

Azure Cloud -> Microsoft Sovereign Cloud

* remove azure once more
 2023-04-13 13:01:13 -07:00
Tyler James Leonhardt
b0d7acec38 Logger per auth provider (#179896) 
So that we can have an output channel for each.
 2023-04-13 19:26:36 +01:00
Brandon Waterloo [MSFT]
f9d14d68fb Support sovereign/custom clouds in microsoft authentication provider (#178725) 2023-04-07 16:38:38 -07:00
Logan Ramos
bf1697d98c Consume proposed telemetry API (#165862) 
* Consume proposed telemetry API

* Update webpack
 2022-11-08 21:58:28 -05:00
Tyler James Leonhardt
847629239b add owner and comment to some telemetry events (#148752) 2022-05-05 17:30:51 -04:00
Tyler Leonhardt
52a394bdea Introduce removeSessionByIToken to remove sessions that aren't in this._tokens yet. Fixes #145189 2022-04-14 15:21:54 -07:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Tyler Leonhardt
f498b374c0 large refactor including new secret storage wrapper and overall code clean up and organization 2022-02-01 18:14:31 -08:00
Logan Ramos
c047af40b2 Fix compilation 2022-01-19 16:18:14 -05:00
Tyler Leonhardt
12902bc7a1 allow overridding of client id and tenant for microsoft auth 2022-01-14 14:36:34 -08:00
Tyler Leonhardt
4d496f61bc remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201 2021-10-25 11:16:37 -07:00
Tyler Leonhardt
c1b4cf00b9 update auth extensions to use packageJSON property instead 2021-07-23 11:48:39 -07:00
Tyler James Leonhardt
87d692b7bf Add scopes property to login telemetry (#128261) 
* Add scopes property to login telemetry
 2021-07-08 21:48:44 -07:00
Rachel Macfarlane
14669c2e45 Make scopes parameter optional to getSessions and remove getAllSessions 2021-02-12 09:13:11 -08:00
Rachel Macfarlane
eceff53351 Rename login/logout to createSession/removeSession 2021-02-11 16:46:47 -08:00
Rachel Macfarlane
650906c369 Pass scopes through to authentication providers 2021-02-11 14:15:36 -08:00
Rachel Macfarlane
9118a3461c Make onDidChangeSessions event for auth providers fire complete session 2021-02-11 10:14:28 -08:00
Rachel Macfarlane
c85297669e Move id, label, and options to authentication provider registration 2021-01-11 10:53:17 -08:00
Rachel Macfarlane
7db413d4c1 Move secrets API to extension context 2021-01-04 22:04:40 -08:00
Rachel Macfarlane
31419adc34 Polish onDidChangePassword changes 2020-10-12 10:31:16 -07:00
Rachel Macfarlane
0a30c7a64d Add GDPR comments for auth provider telemetry 2020-07-08 11:22:21 -07:00
Rachel Macfarlane
ab7a5ec3ad Address part of feedback for #100993 2020-07-06 08:51:24 -07:00
Rachel Macfarlane
87b0c54586 Make AuthenticationSession a class and remove getAccessToken method, fixes #91554 2020-05-15 14:34:04 -07:00
Rachel Macfarlane
9559d186d4 Rename vscode-account extension to microsoft-authentication 2020-05-13 09:41:42 -07:00