Commit Graph

297 Commits

Author SHA1 Message Date
Alexandru Dima
3d8888779d Fixes #112446: Avoid timeouts in mirroring terminals to the extension host by assigning a temporary UUID to terminals created on the extension host side 2021-01-07 00:13:42 +01:00
Rob Lourens
dce22cf74b Fall back on node API when $SHELL is not set, for
user shell and shell environment discovery
See github/codespaces#1639
2020-12-14 09:36:00 -08:00
Rob Lourens
af6843bacf Convert terminal ext api null args to undefined
Fix #110253
2020-11-15 12:49:42 -08:00
Alex Dima
f3b8f4f765 Do not use process.env directly in findExecutable 2020-10-26 16:00:15 +01:00
Rob Lourens
89540b65db Don't persist debug terminals
#109084
2020-10-22 17:02:18 -07:00
Alex Dima
44f8fcdd2f Avoid needing the entire IConfigurationResolverService for variable resolving & more explicit typing for fetchSetting 2020-10-13 21:10:23 +02:00
Benjamin Pasero
55f071a72f debt - more use of product service over product.ts 2020-09-17 10:08:28 +02:00
Daniel Imms
aa6b2f163d Initial terminal welcome support 2020-08-27 12:38:33 -07:00
Daniel Imms
e8c3ff351b Log ext host terminal process requests 2020-07-24 06:46:25 -07:00
Daniel Imms
b8b7e72473 Move env var collection impl into common
Part of #101857
2020-07-13 06:26:35 -07:00
Daniel Imms
1dd4c04384 Fix launching in ext host/pty terminals 2020-06-12 11:05:45 -07:00
Daniel Imms
af3c79edcb Move ExtensionContext.environmentVariableCollection to stable
Fixes #46696
2020-05-06 03:03:57 -07:00
Daniel Imms
d62c642e3f Don't use environment collections when using strictEnv
Fixes #96630
2020-04-30 14:09:52 -07:00
Daniel Imms
7f5bada046 Move EnvironmentVariableCollection API into ExtensionContext (#96061)
* Move env var collection to ext context

* Remove dispose, fix persistent passing

* Fire collection change on persistence change

* Fix tests by forcing activation and getting ctx

* chore: bump js-debug

Co-authored-by: Connor Peet <connor@peet.io>
2020-04-24 16:45:30 -07:00
Daniel Imms
ae21a79256 Apply the environment in remote 2020-03-27 15:48:07 -07:00
Daniel Imms
fc0712520f Add api tests for env var collections
This does not cover the persisted case
2020-03-27 09:30:32 -07:00
Daniel Imms
000f8392b3 Only persist collections marked to do so 2020-03-27 09:03:53 -07:00
Daniel Imms
d91532afa8 Load in persisted collections from past sessions on ext host 2020-03-27 07:44:56 -07:00
Daniel Imms
1235bd0a60 Support diffs of collections, extracting additions 2020-03-26 16:51:04 -07:00
Daniel Imms
edc7100114 Apply multiple extension mutators, share code with ext host 2020-03-26 15:40:03 -07:00
Daniel Imms
540232e38f Handle persisting and invalidating of collections 2020-03-26 11:20:23 -07:00
Daniel Imms
e775d54e2b Apply ext env changes to new terminals 2020-03-25 12:45:37 -07:00
Daniel Imms
556550a29a Fire debounced event on change 2020-03-25 12:15:42 -07:00
Daniel Imms
05225c7f36 Resolve merged collection 2020-03-25 12:07:21 -07:00
Daniel Imms
ed9e7241b7 Move single ext collection updates across 2020-03-25 11:57:12 -07:00
Daniel Imms
8ee60554b5 Send collections to renderer 2020-03-25 07:51:05 -07:00
Daniel Imms
b2a9d4dd61 Serialize collections on ext host 2020-03-25 07:35:19 -07:00
Daniel Imms
b41b85d224 Start building out env var service 2020-03-25 07:26:11 -07:00
Daniel Imms
338d4298f4 Debounce update event 2020-03-25 06:46:08 -07:00
Daniel Imms
17dc799997 Implement env var collection structure 2020-03-25 06:37:37 -07:00
Daniel Imms
97eaa84d46 Pass terminal method through to ext host terminal service 2020-03-24 08:02:11 -07:00
Daniel Imms
cd17694974 Fix possible race condition
Fixes #90883
2020-02-18 07:35:59 -08:00
Daniel Imms
5fad95f544 Change getDefaultShellAndArgs to use promises
Part of #75793
2020-02-05 12:03:45 -08:00
Daniel Imms
1aefcce704 Change requestAvailableShells to use promises
Part of #75793
2020-02-05 11:55:14 -08:00
Daniel Imms
a62805844e Expose IExtHostTerminalService.getDefaultShellArgs internally
Fixes #88280
2020-01-13 07:45:08 -08:00
Matt Bierner
1b70625f8c Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Sandeep Somavarapu
7bbafc2221 Fix #87088 2020-01-08 11:40:42 +01:00
Jean Pierre
4804d6e21a Merge branch 'master' into fix-70323 2019-12-16 21:43:17 -05:00
Andre Weinand
e38b49b5a3 restructure variable resolver 2019-11-20 17:36:09 +01:00
Jean Pierre
311c8f1d87 Merge branch 'master' into fix-70323 2019-11-06 19:54:01 -05:00
Daniel Imms
1d60909d1f Implement Terminal.creationOptions API
Fixes #63052
2019-11-05 10:30:43 -08:00
jeanp413
c3d9cdb01b null => undefined 2019-10-26 19:47:56 -05:00
Daniel Imms
5db496f7cf Fix strictFunctionTypes in terminal proc
Part of #81574
2019-10-22 09:30:00 -07:00
Daniel Imms
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
This reverts commit 7f5a4a3f5b.
2019-10-13 10:55:54 -07:00
Daniel Imms
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Benjamin Pasero
93bb67d7ef debt - use common/product over node/product 2019-09-16 11:35:11 +02:00
Benjamin Pasero
5e1179f0b8 web - move help actions to browser 2019-09-16 10:37:58 +02:00
Daniel Imms
d68d86d2db Improve testing around terminal env vars 2019-09-12 18:00:54 -07:00
Daniel Imms
ebed7e9c5e Change setLocaleVariables to detectLocale
The setting is now an enum instead of boolean and defaults to auto
which should provide better detection and not set in cases where it
shouldn't.

Fixes #80072
2019-09-12 16:16:07 -07:00
Daniel Imms
63a0da438b Have ExtHostTerminalService extend Base service 2019-09-11 09:54:27 -07:00