Commit Graph

793 Commits

Author SHA1 Message Date
Matt Bierner
354e1a0595 Finalize data file reading API (#152127)
Fixes #147481
Also reverts #150963 since the `kind` field is not being finalized
2022-06-15 07:56:02 -07:00
Johannes Rieken
3d471d2ca9 Merge pull request #151841 from microsoft/joh/cute-bobcat 2022-06-15 08:46:12 +02:00
Matt Bierner
8b0b3ee72e Remove notebook editor decoration type (#151574)
* Remove the notebookEditorDecorationType API proposal

Fixes #146838

* Remove all the infastructure around the now removed notebookEditorDecorationType api
2022-06-13 13:51:10 -07:00
Matt Bierner
7284c3e4c1 Use classes for drop/paste edit types (#151980) 2022-06-13 13:10:07 -07:00
Johannes
0376810398 add API proposal for TextEdit#newText: SnippetString 2022-06-13 11:33:42 +02:00
Matt Bierner
d7c90c2b2b Update text editor drop proposal (#151552)
This updates the text editor drop proposal (#142990). This change introduces `DocumentDropEdit` which removes the need for `SnippetTextEdit`. This interface may also be extended in the future with additional metadata
2022-06-08 17:44:28 -04:00
Matt Bierner
370dfd5fee Iterate on paste edit provider api (#151477)
* Iterate on paste edit provider api

For #30066

- Pass all selections to paste providers. For #151326
- Introduce `DocumentPasteEdit` as return type. This new type uses an `insertText` that is applied to every paste location (for multicursor), plus an optional additional edit
-  Add `DocumentPasteProviderMetadata`. This lets extensions tell us which types of mimetypes they are interested in, letting us avoid round trips if no extensions care about the pasted data

* Correctly batch insertText
2022-06-08 15:06:55 -04:00
Matt Bierner
75a6ddc862 Add DataTransferItem.kind (#151384)
Fixes #150963

The new `.kind` property makes it easier to tell the type of a data transfer item
2022-06-07 08:06:00 -07:00
Matt Bierner
fd19b8567e Mark notebookContentProvider proposal as deprecated (#150493)
For https://github.com/microsoft/vscode/issues/147248

Marks the top level types in this file as deprecated. Also hooks up `registerNotebookContentProvider` to report deprecated API usage
2022-05-26 22:40:06 +00:00
Matt Bierner
e4f7f6a9da Add PasteEditProvider (#107283)
For #30066

This adds a new `documentPaste` api proposal that lets extensions hook into copy and paste.

This can be used to do things such as:

- Create link when pasting an image
- Bring along imports when copy and pasting code
2022-05-25 12:27:58 +02:00
Henning Dieterichs
9ef07308ea Finalizes inline completions 2022-05-24 12:52:19 +02:00
Peng Lyu
27ea5e48ae Merge pull request #150146 from microsoft/rebornix/source-commands
Notebook kernel source menu contribution
2022-05-23 18:11:33 -07:00
Matt Bierner
45304da73d Finalize NotebookEditor api proposal (#149767)
* Finalize NotebookEditor api proposal

Fixes #149271

This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:

- The deprecated properties/functions
- A few contribution points such as `notebook/cell/executePrimary`

* remove extra quote
2022-05-23 23:27:17 +00:00
rebornix
8d503ffaf4 connection state in another pr 2022-05-20 16:35:46 -07:00
rebornix
9d49470ac6 Merge remote-tracking branch 'origin/main' into rebornix/controller-connection 2022-05-20 15:49:23 -07:00
Matt Bierner
1c7ab35761 Rename to DocumentOnDropEditProvider (#149730)
This change renames `DocumentOnDropProvider` to `DocumentOnDropEditProvider`. This new name aligns with the existing `DocumentFormattingEditProvider`
2022-05-17 09:26:54 -07:00
Matt Bierner
3f531a7de3 Add notebookWorkspaceEdit api proposal (#149128)
* Add notebookWorkspaceEdit api proposal

Splits a new `notebookWorkspaceEdit` out of the existing `notebookEditorEdit` proposal.

The notebookWorkspaceEdit reflects the api that we believe should be finalized instead of `notebookEditorEdit`. It lets extensions use workspaceedits to change cells in a notebook or replace the metadata for a notebook document

As part of this change, I've also marked all of the `notebookEditorEdit` apis as deprecated (except for `replaceNotebookMetadata` which exists in the new proposal too)

* Export type from extHost
2022-05-16 11:25:14 -07:00
rebornix
bd99c998a1 Remove proxy controller. 2022-05-15 18:56:22 -07:00
Johannes
aa706918c1 only match against notebook uri when document selector specificies notebook type, fixes https://github.com/microsoft/vscode/issues/149363 2022-05-13 09:29:57 +02:00
Matt Bierner
67014adc30 Remove the textDocumentNotebook API proposal (#149277)
* Remove the textDocumentNotebook API proposal

All consumers have now been migrated off of this proposal, so it is safe to remove from our code

* Remove deprecated api usage from test
2022-05-12 08:59:11 +02:00
rebornix
7e34708dcc prepare for removing proxy kernel. 2022-05-11 11:46:20 -07:00
Tyler James Leonhardt
2d9244c330 Finalize InputBoxMessageSeverity API (#148961) 2022-05-06 14:37:40 -07:00
Henning Dieterichs
bae40168ae Fixes issues from code review 2022-05-05 09:54:41 +02:00
Henning Dieterichs
3b08d52d0b Updates inlineCompletions proposal from inlineCompletionsNew proposal.
Also moves InlineCompletionList.commands to inlineCompletionsAdditions proposal.
2022-05-05 07:49:38 +02:00
Johannes
e7bc9bb5fc don't return duplicates from vscode.extensions.allAcrossExtensionHosts, add ExtensionIdentifierSet fyi @alexdima 2022-04-22 12:43:25 +02:00
Logan Ramos
aa69f3d762 Fix #15178 Finalize tabs API 🎉 2022-04-21 11:08:12 -04:00
Johannes
ad4470522e propose extensions.allAcrossExtensionHosts and related APIs, https://github.com/microsoft/vscode/issues/145307 2022-04-21 14:45:46 +02:00
Johannes
9530dca29d finalize notebookDocumentEvents-API, https://github.com/microsoft/vscode/issues/144662 2022-04-20 13:58:37 +02:00
Matt Bierner
50ea16198d Remove the concat text document api proposal
Fixes #146781
2022-04-14 14:39:44 -07:00
rebornix
f20a0f2a10 extract exthost/mainthread proxy kernels. 2022-04-14 11:10:48 -07:00
rebornix
ec30263535 Merge remote-tracking branch 'origin/main' into rebornix/lazy-kernel 2022-04-14 10:09:45 -07:00
rebornix
61095a1347 notebook controller or id 2022-04-14 10:07:49 -07:00
Tyler Leonhardt
527d63162a address feedback by having concrete ValidationMessage type 2022-04-12 17:18:13 -07:00
rebornix
860221a193 two kernel types 2022-04-11 08:05:40 -07:00
Matt Bierner
f8a64a1482 Adding readonly to a few more array arguments 2022-04-05 11:06:37 -07:00
Matt Bierner
86bab72670 Adding deprecation message for concat text document
For #146781
2022-04-04 17:00:09 -07:00
Matt Bierner
44ffeba237 Switch to provider based model for on drop
This simplifies implementing the provider and also give potentially gives us more control over how the drop happens
2022-04-01 15:51:38 -07:00
Johannes
bd71718372 add SnippetTextEdit, allow drop-handler to return them 2022-03-30 12:06:01 +02:00
Johannes
bf0b4ac976 remove old notebook events from API proposal and implementation 2022-03-28 14:47:56 +02:00
Logan Ramos
1dc2b29aaf Fix #145895 2022-03-23 11:43:30 -04:00
Logan Ramos
aa42171f54 Fix #145747 2022-03-23 10:04:28 -04:00
Logan Ramos
a2d8edb83d Tabs API renaming 2022-03-21 13:35:34 -04:00
Tyler Leonhardt
68802ccc44 initial proposal of InputBoxValidationSeverity 2022-03-19 09:30:45 -07:00
Matt Bierner
bfc026b97a Drop into text editor api proposal (#143334)
* Add drop into editor api proposal

For #142990

* Use AsyncEmitter
2022-03-18 11:32:11 -07:00
Logan Ramos
4d9393e9d3 Renamed NotebookEditorDiffTabInput 2022-03-18 12:53:55 -04:00
Logan Ramos
85c3df0dde Tie in tab input, remove cleanup .d.ts 2022-03-17 16:54:44 -04:00
Logan Ramos
02f15063a0 Implement other tab inputs 2022-03-17 15:50:01 -04:00
Matt Bierner
989caf1849 Remove extra type 2022-03-17 11:56:38 -07:00
Johannes
2f9632ec45 first steps towards Tab#input 2022-03-17 16:49:34 +01:00
Henning Dieterichs
3626e6ab0c Adds inlineCompletionsNew and inlineCompletionsAdditions proposed APIs to avoid breaking changes when finalizing inline completions API. 2022-03-10 11:23:01 +01:00