Commit Graph

315 Commits

Author SHA1 Message Date
Matt Bierner 7bc2019b8d Updating pinning test 2021-05-21 15:01:05 -07:00
Jean Pierre be8745ac9e Fixes #123228 (#123584)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2021-05-21 14:51:18 -07:00
Matt Bierner 6ee883bfa3 Split href before decoding instead of after
Fixes #123228

This fixes the case where `#` appears in the path
2021-05-21 14:49:46 -07:00
Matt Bierner 77ff6eb03b Add image specific link normalizer (#124400) 2021-05-21 14:42:50 -07:00
Matt Bierner e9b8c12915 Add types 2021-05-21 14:36:19 -07:00
Matt Bierner 22dc518a21 Remove unused type 2021-05-21 12:16:49 -07:00
Matt Bierner 97bbacd808 Remove extra call to with 2021-05-21 12:16:49 -07:00
Matt Bierner 79dea51e79 Rewrite webview urls to be more url-ish
## Problem

Webview uris currently have the form:

```
https://uuid.vscode-webview.net/vscode-resource/scheme/authority/path...
```

We have this syntax because we need to be able to recover the original scheme and authority of the resource in order to load it from disk

However this syntax means that absolute urls don't behave as you'd expect. For example, if you have a webview that sets a `<base>` to a document in the workspace, an absolute url `/abs/path.png` ends up being resolved to:

```
https://uuid.vscode-webview.net/abs/path.png
```

This drops the original scheme and authority, which prevents us from loading the resource

## Fix
With this change, I've moved the original scheme and authority into the authority of the webview uri instead of the path:

```
https://scheme+authority.vscode-resource.uuid.vscode-webview.net/path...
```

With this change, absolute paths should correctly be resolved
2021-05-21 09:28:43 -07:00
Andrea Mah f594bb47e5 removing more unecessary whitespace 2021-05-19 17:00:55 -06:00
Andrea Mah 41606da2dc removing unecessary spaces 2021-05-19 16:59:26 -06:00
Andrea Mah 9ee1906718 pr feedback and combining prevEditor info for preview and non-preview 2021-05-19 16:57:12 -06:00
Andrea Mah 94498778fb cleanup 2021-05-13 15:24:56 -06:00
Andrea Mah 9731995d94 addressed ! nit 2021-05-13 12:39:52 -06:00
Andrea Mah 3dec3b3385 applied PR feedback 2021-05-13 12:30:10 -06:00
Andrea Mah d2894562d5 fixing issue with static scroll alongside text editor 2021-05-12 17:59:00 -06:00
Andrea Mah 18950181eb scroll state persists while toggling between static preview and text 2021-05-12 16:59:57 -06:00
Andrea Mah 927e791753 Fix Initial Scroll Position on Markdown Dynamic Preview (#123613)
* added semicolons to pass code check

* removed preliminary work for static preview

* cleanup

Co-authored-by: Andrea Mah <t-andreamah@microsoft.com>
2021-05-11 17:12:19 -07:00
Logan Ramos 656e1e6086 More deprecated assertion cleanup 2021-05-04 15:55:26 -04:00
Sang e5c466f587 markdown-language-features: Fix Windows Preview Link Uri (#120090)
* markdown-language-features: fix windows file uri

* refactor: use Uri.joinPath instead
2021-04-19 17:31:07 -07:00
Benjamin Pasero 14981ce89d tests - enable colors for windows (CI supports it and the new Windows terminal too) 2021-04-19 09:29:20 +02:00
Matt Bierner d5f4e119e0 Use Array.from's map directly instead of a second call to map 2021-04-12 14:42:39 -07:00
Matt Bierner 73ae56b82b Build with latest TS nightly (#120690)
* Pick up new TS 4.3

Also tests adding override keywords for extensions as part of #120675

* Update to daily TS and workaround TS 4.3 issue

Works around https://github.com/microsoft/TypeScript/issues/43578
2021-04-07 12:19:05 -07:00
William Desgardin 30ccdf6b6c feat: add typographer option for markdown preview (#119641)
Co-authored-by: Matt Bierner <matb@microsoft.com>
2021-03-29 14:18:59 -07:00
gregvanl 975115a2cb Setting descriptions typos and formatting 2021-03-25 10:17:31 -07:00
Benjamin Pasero e916637528 tests - enable color output for integration tests 2021-03-01 15:10:15 +01:00
Manuel Thalmann cdd7066f00 Allow Markdown-Rendering Without Providing an Env-Parameter (#117041)
* Add a rule for initializing the image-stabilizer

* Only use `containingImages` if the variable exists
2021-02-22 14:02:36 -08:00
Habib Karim 9f08368e92 Handle normalized absolute file paths on markdown preview link click (#116649)
* Handle normalized absolute file paths on markdown preview link click #115812

* Parse file path using vscode.Uri
2021-02-18 19:07:22 -08:00
David Sanders 7b317afd93 Fix starting scroll for URIs with fragment (#111126) 2021-01-22 17:41:25 -08:00
Henning Dieterichs 1f8643ef76 Refresh Images In Markdown Preview On Change (#114083)
* Refresh Images In Markdown Preview On Change (implements #65258).

* Fixes tests.

* Implements etags.

* Adds tests for urlToUri.

* Updates doc comment.
2021-01-19 18:01:21 -08:00
Jean Pierre 7f4d67c94c Fix #110812 (#114553) 2021-01-19 14:21:02 -08:00
Alexandru Dima 7242082983 Fixes #112834: Ensure the markdown link provider is registered before invoking vscode.executeLinkProvider 2020-12-30 21:50:10 +01:00
Alexandru Dima 7ca71e763d Move away from deprecated 'vscode' node module (#112718) 2020-12-17 21:40:14 +01:00
meganrogge 0f33afa9f9 fix #112217 by replacing look behinds 2020-12-14 10:30:45 -08:00
Matt Bierner 79557ebbd2 Make sure markdown preview is updated if on disk file is updated
Fixes #111685
2020-12-09 14:08:15 -08:00
meganrogge 4884986dd6 tweak smart select test 2020-12-02 10:13:02 -08:00
meganrogge a2193cb827 fix #111714 2020-12-02 10:10:21 -08:00
meganrogge 5e54da666c fix #111675 and #111673 2020-12-01 17:03:47 -08:00
meganrogge b2eca1fd4d Fix InMemoryDocument to support both OS line endings
Co-authored-by: mjbvz <matb@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
2020-11-11 14:05:20 -08:00
Rob Lourens 35f9bac07d Disable markdown smart select tests #110365 2020-11-10 20:02:24 -08:00
Erik Krogh Kristensen 7a4e81a674 fix catastrophic backtracking when parsing markdown files (#109964) 2020-11-10 14:56:06 -08:00
Megan Rogge 63d15a97c7 Support character markup in mardown smart select (#110195)
* create tests and add selection functions for inline ranges
2020-11-10 11:38:27 -08:00
David Sanders fcef0e3db4 Use Array.flat() (#110189) 2020-11-09 12:46:26 -08:00
meganrogge 6e2aa0bfb7 clean up code and remove unused methods 2020-11-06 12:42:17 -08:00
David Sanders 153ba443d5 Use string.matchAll (#110074) 2020-11-06 11:49:56 -08:00
meganrogge fc07b2f170 add comments to clarify code 2020-11-06 11:38:21 -08:00
Matt Bierner 24b28f57be Always use vscode.open to open markdown links
Fixes #108998

This ensures we use the custom editor if it is the default
2020-11-05 17:00:16 -08:00
meganrogge 08e556dc5d fix #109486 and #109489 2020-11-04 10:16:06 -08:00
Megan Rogge 5d4df8273e markdown smart select (#108818)
smart select
2020-10-26 15:33:48 -07:00
Matt Bierner dd124a5cae Cleaning up code
- Use more explicit names
- extract
- Use `??`
2020-10-16 17:18:44 -07:00
Nafana df59ceb026 Markdown reference links starting with ^ should not be clickable (#108015)
Co-authored-by: mmacovei <mmacovei@sfu.ca>
2020-10-08 00:38:17 -06:00