Commit Graph

300 Commits

Author SHA1 Message Date
Johannes Rieken
3fc8913343 show quick pick when multiple formatter apply, #41882 2019-03-21 17:40:31 +01:00
Matt Bierner
499cfbe8a8 Add fallback values for when exthost adapter cannot be found
Fixes #69147

Due to the asynchronous communication between the exthost and main process, there may be cases where we request data from a provider that has been unregistered. This currently logs an error.

This change adds a fallback value that we can return instead when the adapter is missing.
2019-03-20 18:11:19 -07:00
Johannes Rieken
5a920062da remove extHost-dependency from mainThreadLanguages, #70319 2019-03-20 12:40:54 +01:00
Matt Bierner
bf7f750a19 Add asArray helper 2019-03-19 10:33:39 -07:00
Johannes Rieken
c92ce4014f move extHost.protocol to common, #70319 2019-03-19 15:46:01 +01:00
Johannes Rieken
d9558862cc add uri-property to CallHierarchtItem, better wording, better behaviour when switching calls/callers 2019-03-19 10:06:19 +01:00
Johannes Rieken
a92a5bf11f Merge branch 'master' into joh/callh 2019-03-18 12:41:19 +01:00
Alex Ross
8f16a02e66 Move remote agent environment out of node (#70568) 2019-03-15 17:00:57 +01:00
Johannes Rieken
c9a8a1d08f simple tree UX 2019-03-14 17:56:45 +01:00
Johannes Rieken
2f89a79efe api proposal, add call hierarchy contrib 2019-03-14 16:14:43 +01:00
Johannes Rieken
4f8dbd4544 use a parent pointer instead of 2d array, #67872 2019-03-12 10:04:06 +01:00
Matt Bierner
963ddff246 Strict null check extHostLanguageFeatures 2019-03-11 08:49:41 -07:00
Matt Bierner
d37e38b6c3 Revert extract and use null supressions as requested 2019-03-11 08:33:13 -07:00
Matt Bierner
9d503a5481 Naming 2019-03-11 08:29:43 -07:00
Matt Bierner
a92031dc02 Strict null check work in extHost and mainThread language Features
- annotate undefined returned types
- Don't call functions with null or undefined values.
- Refactor _convertCompletionItem so that we don't need to mutate the returned object
- Suppress a type error related to electricCharacters.
2019-03-11 08:29:43 -07:00
Matt Bierner
52556f9742 Auto converting let -> const where possible in mainthread and extHost
Const provides better type guards and can make logic clearer
2019-03-05 16:53:41 -08:00
Matt Bierner
8f3cda12e4 Strict null check extHostFileSystem 2019-03-05 16:53:40 -08:00
Matt Bierner
5c5d64e601 Remove cast that was causing type error 2019-02-19 16:41:24 -08:00
Matt Bierner
e9a1cea1fd Strict null fixes in extHost 2019-02-19 16:29:01 -08:00
Martin Aeschlimann
dd40499fda Use URI for linkDTO 2019-02-14 18:24:32 +01:00
Johannes Rieken
3283483974 add formatter call, use it for no-formatter-case for now #41882 2019-02-14 11:16:32 +01:00
Johannes Rieken
a45fb4099c make insets fit into layering scheme 2019-02-13 16:23:52 +01:00
Johannes Rieken
ac03e62afc last round of making changes smaller 2019-02-13 15:20:29 +01:00
Johannes Rieken
58d2b5be06 disable event for now, remove extension location from provider 2019-02-13 14:46:31 +01:00
Johannes Rieken
44b7588362 remove getNamedCustomer, connect MainThreadWebview with CodeInsetController 2019-02-13 12:47:46 +01:00
Johannes Rieken
8246c1648f workbenchs/parts became workbench/contrib 2019-02-13 12:47:46 +01:00
Johannes Rieken
ace73c05b7 move rest code code inset to workbench out of (monaco) editor 2019-02-13 12:47:46 +01:00
Rob DeLine
066dfef8f7 Add Code Inset Feature 2019-02-13 12:46:25 +01:00
Matt Bierner
f9687fc5ec Strict null work on extHostLanguageFeatures 2019-02-11 09:31:13 -08:00
Matt Bierner
f1afe72087 Add getDocument helper method
Many places  in `extHostLanguageFeatures` were calling `getDocumentData` without checking if the result is undefined. Add an `getDocument` that cannot return undefined values and instead throws an error if there is no document
2019-02-11 09:31:13 -08:00
Matt Bierner
9ee6077373 Strict null work in extHost 2019-02-11 09:31:13 -08:00
Johannes Rieken
52d134aacb update proposed api to have multiple positions, #41838 2019-02-11 12:08:27 +01:00
Johannes Rieken
d50b568d87 multiple cursor in internal api of smart select, #41838 2019-02-11 11:34:09 +01:00
Johannes Rieken
0693cb7afc debt - don't track recursive but explict, #67694 2019-02-07 13:56:26 +01:00
Johannes Rieken
1cb6e26ab2 es6 compile attempts 2019-02-06 11:44:11 +01:00
Matt Bierner
71ee61ef2d Fix active signature not being propagated properly
#33413
2019-01-28 14:46:29 -08:00
Johannes Rieken
97ed8aba29 add developer command that prints available formatters to console, #41882 2019-01-21 18:19:02 -08:00
Matt Bierner
bcc2281e45 Rename CodeAction.canAutoApply -> CodeAction.preferred
Part of #62110

Use the more generic name as suggested in https://github.com/Dart-Code/Dart-Code/issues/1393. This makes the intent of the field more clear and also allows us to extend the concept of preferred code actions to refactorings and other classes of code actions

Experimentally also allows a `preferred` value for `apply` when configuring code aciton keyboard shortcuts. This applies the preferred code action returned from the list of code actions returned
2019-01-21 14:09:30 -08:00
rebornix
ee3a616601 Max code actions per file is 1000 2019-01-17 17:11:28 -08:00
Matt Bierner
1904cd8d84 Prototype auto fixable quick fixes
Part of #62110

- Adds a new field `canAutoApply` to code actions. This field indicates that a code action can be applied without additional user input. For quick fixes, this should be set if the fix properly addresses the error

- Enable auto fixes for TS spelling errors

- Added a `editor.action.autoFix` command to triggers auto fixes at the current cursor position
2019-01-16 17:56:22 -08:00
Johannes Rieken
14ce5183db renames, #58649 2019-01-11 16:18:56 +01:00
Matt Bierner
6ac9ea2af7 Revert "Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)""
This reverts commit 7b375fcb82.

Reapplies 4a38520d59 with a fix for #66202

Fixes #66202
2019-01-08 11:49:32 -08:00
Johannes Rieken
f9dac59254 add warning/'missing name'-message when symbol has no name, fixes #65545 2019-01-08 12:55:42 +01:00
Joao Moreno
7b375fcb82 Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)"
This reverts commit 4a38520d59.
2019-01-08 10:09:47 +01:00
Matt Bierner
4a38520d59 Add activeSignatureHelp to SignatureHelpContext (#65440)
For #33413

Adds the active `SignatureHelp` object (along with the active signature) to the `SignatureHelpContext`.
2019-01-07 13:55:58 -08:00
Alex Dima
9cf36cdf8f Rename CanonicalExtensionIdentifier to ExtensionIdentifier 2019-01-07 12:00:54 +01:00
Matt Bierner
c109d319fe Second pass converting for index based looping to for-of loops
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Alex Dima
25417553be Adopt case insensitive extension identifiers 2018-12-21 12:41:41 +01:00
Johannes Rieken
514ec620de add SelectionRange and SelectionRangeKind, #63935 2018-12-17 15:10:18 +01:00