I recently ran into an issue where I was trying to call showQuickPick with a readonly array. This is currently not allowed, even though `showQuickPick` never mutates the input
This change marks a few places in `vscode.d.ts` where we take arrays as parameters as `readonly []`. It also caught a potential bug with`getSession` modifying the input array
* Simplify logic for webview resource uris
This change attempts to simplify the logic around webview resource uris by doing the following:
- Hard code the resource origin. We always will be hitting a service worker for these paths so they don't need to be dynamic (although in the future we may want to pull them from `product.json`)
This lets us remove these properties from the environment service
- Move remote handling from the resource loader in `asWebviewUri`.
- Remove the handling of http and https paths from the resource loader.
I don't think these cases can be hit any longer (although I need to confirm this with more testing for the web case). Instead I added a check to `asWebviewUri` so that we return the original uri if a http(s) uri is passed in
* Restore normalizeResourcePath
We still need to convert between a remote uri and one that our remote file system can read
* Fix test
* Restore passing in remote on extension side
* Remove only
* fix#73122 allow FSP to stat a file as readonly
* add enableProposedApi check
* omit existing members of FileStat
* dispose _enableProposedApi
* implement feedback from @bpasero
* add onDidChangeReadonly event so tab title gets '(read-only)' suffix immediately
* push missing changes
* adopt latest API proposal
* fix missing property in mtfs
* tests - add fileservice test for readonly
* more tests
* wire into notebooks
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
* Allow text search providers to give messages
* Remove console log and messages property
* Render text search provider messages in Search Editor
* Filter out duplicate messages
* Add Info vs Warning messages
* Improve wrapping behaviour of provider message