Commit Graph

144 Commits

Author SHA1 Message Date
Alex Ross
40bda94ebc Custom executions get lost during fetchTasks
Fixes #100577
2020-06-22 18:36:32 +02:00
Alex Ross
d52f137ed5 Return task execution early from executeTask
Fixes #100361
2020-06-17 13:54:21 +02:00
Alex Ross
1abf21d3d8 Explicitly set task execution way before running task
Part of #100361
2020-06-17 13:39:02 +02:00
Daniel Imms
5fad95f544 Change getDefaultShellAndArgs to use promises
Part of #75793
2020-02-05 12:03:45 -08:00
Alex Ross
c3a5ac0820 Adopt deprecation service for deprecated task constructor
Part of https://github.com/microsoft/vscode/issues/88391
2020-01-22 12:43:01 +01:00
Matt Bierner
1b70625f8c Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Andre Weinand
e38b49b5a3 restructure variable resolver 2019-11-20 17:36:09 +01:00
Alex Ross
1aa537bf59 Use log service in exthosttask and exthosttreeviews
Part of #84283
2019-11-12 10:33:21 +01:00
Alex Ross
ab89935fd3 First pass at resolving task definition and passing back to custom execution (#83764)
First pass at resolving task definition and passing back to custom execution. It only currently resolves simple predefined variables, no input, command, or defaultBuildTask.

Part of #81007
2019-11-05 16:35:21 +01:00
Alex Ross
030af9515a Stabilize CustomExecution task API
Fixes #80375
2019-10-22 17:10:25 +02:00
Alex Ross
dc4b1c231c Rename CustomExecution2 to CustomExecution
Part of #80375
2019-10-11 14:43:23 +02:00
Alex Ross
6fe6269c41 Keep better track of custom executions for reruns and depends
Fixes #80964
2019-09-17 17:27:15 +02:00
Alex Ross
1c01ce84b5 Refactor extHostTask (#80970)
so that most of it is in common
2019-09-16 12:09:14 +02:00
Alex Ross
ca4c1bf7a0 Go to ext host for system default shell and args for tasks
Fixes https://github.com/microsoft/vscode-remote-release/issues/1203
2019-09-05 14:59:08 +02:00
Johannes Rieken
dedf0de944 change type of _serviceBrand from any to undefined, #79918 2019-08-30 15:40:46 +02:00
Gabriel DeBacker
0e56130bdf Fix issue with CustomExecutions not working through tasks.executeTask (#79132)
* Do not clear out the map, and track the provided execution during execute task

* Clear provided custom executions map on execution complete

* Save last custom execution
2019-08-15 16:24:53 +02:00
Johannes Rieken
7a6f22b3af rename rpcService to extHostRpcService 2019-08-09 09:51:22 +02:00
Johannes Rieken
0920cd6ecb move task registration depending on process into /node/ 2019-08-08 10:45:03 +02:00
Johannes Rieken
c2f2b85502 register ExtHostTask as service 2019-08-07 20:07:32 +02:00
Johannes Rieken
2420d4c505 separate rpc and init data into separate services 2019-08-07 19:51:28 +02:00
Johannes Rieken
ebd96071d1 make extHost-things services, setup injector 2019-08-07 16:11:00 +02:00
Daniel Imms
81adc15a12 Merge remote-tracking branch 'origin/master' into tyriar/69865_remove_renderers 2019-08-06 10:02:39 -07:00
Daniel Imms
dc6b475be7 Add global event window.onDidWriteTerminalData
Fixes #78502
2019-08-06 09:58:26 -07:00
Alex Ross
a98faa4454 Remove CustomExecution
Fixes #78540
2019-08-06 13:48:37 +02:00
Daniel Imms
25fe980387 Remove terminal renderers
Part of #69865
2019-08-05 14:31:15 -07:00
Gabriel DeBacker
5e135c4caf Make exception error more accurate 2019-07-30 08:35:06 -07:00
Gabriel DeBacker
9bbf3f25d5 Make sure that task definition is not changed in resolved task 2019-07-30 08:20:29 -07:00
Gabriel DeBacker
506d55d171 Merge remote-tracking branch 'upstream/master' 2019-07-30 08:06:23 -07:00
Daniel Imms
3866deba35 Use pty naming instead of virtual process
Part of #77160
2019-07-25 16:00:41 -07:00
Daniel Imms
9d43802fd4 Create CustomExecution2 test, make start fire after onDidOpenTerminal
Part of #70978
2019-07-23 17:35:11 -07:00
Gabriel DeBacker
793fc0295c Use correct resolved TDO and task for custom execution 2019-07-22 06:58:16 -07:00
Daniel Imms
48e7c6d927 Fix start cb in CustomExecution2
Fixes #77428
2019-07-16 15:10:17 -07:00
Matt Bierner
4eb2bf393b Use DisposableStore 2019-07-15 15:03:54 -07:00
Alex Ross
e84fc7021b Adopt TerminalVirtualProcess for Custom task execution (#76852)
* Adopt TerminalVirtualProcess for Custom task execution

* Update Custom task execution API to return TerminalVirtualProcess in callback

This also required the addtion of a start on the virtual terminal process

* Clarify start API

Fixes #76492
2019-07-10 09:31:40 +02:00
Joel Day
b6089b1db5 Adding support for TaskProvider.resolveTask (#71027)
* Adding support for TaskProvider.resolveTask.

* Reorganize task grouping and resolution async code for readability.

* Made small changes and implmented resolveTask for gulp
2019-07-03 15:47:37 +02:00
Alex Ross
f3086a6e11 Remove sync fs use in tasks
Fixes #70577
2019-06-05 17:10:13 +02:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00
Alex Ross
1bc278f36d Fix reruning of Custom Execution tasks
Fixes #71232
2019-03-27 09:59:07 +01:00
Johannes Rieken
c92ce4014f move extHost.protocol to common, #70319 2019-03-19 15:46:01 +01:00
Alex Ross
8f16a02e66 Move remote agent environment out of node (#70568) 2019-03-15 17:00:57 +01:00
Alex Ross
de771267b8 Strict null check mainThreadTask.ts
Fixes #70510
2019-03-15 09:19:44 +00:00
Alex Ross
d0e0aa2ddd Strict null check extHostTask.ts
extHostTask.ts remains commented out in tsconfig.strictNullChecks.json since it still depends on unchecked files

Fixes #70414
2019-03-14 15:50:45 +00:00
Gabriel DeBacker
6d665482c8 Put back more of the terminal changes 2019-03-06 14:03:16 -08:00
Gabriel DeBacker
d5e4009ae9 Remove need for acquiring dimensions for terminal from main thread 2019-03-06 11:47:57 -08:00
Gabriel DeBacker
8b1b0763a3 Merge with master 2019-03-06 07:44:35 -08:00
Matt Bierner
52556f9742 Auto converting let -> const where possible in mainthread and extHost
Const provides better type guards and can make logic clearer
2019-03-05 16:53:41 -08:00
Gabriel DeBacker
ca923da1d4 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-02-27 10:17:22 -08:00
Sandeep Somavarapu
564b7120ab clean up 2019-02-21 11:34:03 +01:00
Gabriel DeBacker
d728d3dca8 Merge with master 2019-02-20 09:59:44 -08:00
Alex Dima
3199f1fd3b Introduce and adopt IExtHostWorkspaceProvider 2019-02-20 17:11:51 +01:00