Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 03:29:00 +01:00
Code Issues Packages Projects Releases Wiki Activity
122,498 Commits 3,675 Branches 359 Tags
40e700a8d22459e75aa34ec7b30c30d8c8a1b4e7
Commit Graph

1045 Commits

Author SHA1 Message Date
Francisca Carneiro
f93c5bc0c5 Fix #182308: Pressing PageUp in the search panel no longer causes the layout to change. (#213067) 
Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
 2024-06-04 15:13:40 -07:00
Robo
5216c04428 chore: update to electron 29 (#209818) 
* chore: update electron@29.1.0

* chore: update typings to 20.x

* chore: bump electron@29.1.5

* ci: fix crash in compiling extensions-ci

* chore: disable .d.ts check for build/

$ ../node_modules/.bin/tsc -p tsconfig.build.json
node_modules/@types/chokidar/index.d.ts:21:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/@types/chokidar/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

21 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
                ~~~~~~~~~

node_modules/chokidar/types/index.d.ts:8:14 - error TS2420: Class 'import("/Users/demohan/github/vscode/build/node_modules/chokidar/types/index").FSWatcher' incorrectly implements interface 'import("fs").FSWatcher'.
  Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref

8 export class FSWatcher extends EventEmitter implements fs.FSWatcher {
               ~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@types/chokidar/index.d.ts:21
     1  node_modules/chokidar/types/index.d.ts:8

Refs a0f9e09f64

* chore: update core types

* temp: fix layer validation

* chore: update nodejs checksums

* ci: use latest v20 LTS for missing node-gyp

Refs eacec5f490

* ci: define LIBCPP_HARDENING_MODE

* ci: fix crash in vscode-web-min-ci

* chore: update rpm deps-list

* chore: bump tree-sitter-typescript@0.20.5

* chore: bump electron@29.3.0

* chore: bump electron@29.3.1

* chore: update rpm deps-list for x86_64

* ci: disable io_uring UV backend on linux

* ci: disable io_uring backend for oss as well

* chore: update typings to 20.x

* ci: add TODO for io_uring workaround

* chore: bump distro

* chore: update preinstall node version checks

* chore: update @types/gulp

Refs https://github.com/microsoft/vscode/issues/212442

* ci: disable io_uring in more test suites
 2024-05-11 01:20:28 +09:00
Daniel Imms
3e49f239c9 Enable terminal smoke tests on desktop 
Fixes #146811
 2024-04-02 09:08:45 -07:00
Daniel Imms
511929fc52 Remove other icon smoke tests 2024-04-01 04:35:44 -07:00
Daniel Imms
a00e2b9455 Remove terminal change icon tests as they required quick pick 2024-03-29 11:59:04 -07:00
Benjamin Christopher Simmonds
a8f73340be Fix for smoketest extension installation timeout (#205444) 
hover smoke test fix #204771
 2024-02-17 17:58:12 +01:00
Logan Ramos
233fd797c0 Skip flaky extension smoke tests (#205309) 2024-02-15 22:05:54 +01:00
Benjamin Christopher Simmonds
5b8fe0ed3e Fix smoke test (#204836) 
fix smoke test
 2024-02-09 16:47:22 +01:00
Logan Ramos
bcf9b4ff0f Skip extension smoketest (#204775) 2024-02-08 22:14:55 +01:00
Raymond Zhao
fb84f3bcfb test: skip flaky Settings editor smoke test (#202097) 2024-01-09 18:16:42 +01:00
Martin Aeschlimann
56b0088dce update vscode-test-web (#201187) 
* update vscode-test-web

* add @playwright/browser-chromium

* add skipLibCheck

* add skipLibCheck

* use esnext

* cleanup
 2023-12-19 16:03:03 +01:00
Josh Soref
69ddb3f3c6 Write out Cannot (#198377) 
spelling: cannot

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2023-11-20 17:22:21 +00:00
Daniel Imms
0fa8f868a5 Correct setting name in smoke test 2023-11-11 05:15:09 -08:00
Daniel Imms
d9520bd5dc Add smoke test for multi-line prompt sticky scroll 2023-11-09 08:28:19 -08:00
Daniel Imms
4b2ed32ec3 Clean up, simplify smoke test 2023-11-08 11:15:18 -08:00
Daniel Imms
3794d74d3c Fix polling error compile 2023-11-08 09:49:39 -08:00
Daniel Imms
29ddbd371e Simplify polling 2023-11-08 09:39:40 -08:00
Daniel Imms
35ae6b1925 Use a polling approach for writing and asserting 2023-11-08 09:20:44 -08:00
Daniel Imms
9ad04e81aa Combine write data calls 2023-11-08 07:42:25 -08:00
Daniel Imms
bff9161987 Make empty terminal smoke test technique reusable 2023-11-08 07:16:24 -08:00
Daniel Imms
bd2d20551d Make sticky scroll smoketest even more consistent 2023-11-08 07:11:14 -08:00
Daniel Imms
90d1e81ce9 Make sticky scroll smoketest more consistent 2023-11-08 06:30:51 -08:00
Daniel Imms
26db70d00a Fix sticky scroll smoketest on linux 2023-11-08 05:58:03 -08:00
Daniel Imms
64ac05a2e9 Add simple terminal sticky scroll smoke test 2023-11-08 05:23:01 -08:00
Raymond Zhao
e9e1f8a132 Revert "Separate Settings editor open and search steps" (#196997) 
Revert "Separate Settings editor open and search steps (#196866)"

This reverts commit 932e49579b.
 2023-10-30 09:53:19 -07:00
Raymond Zhao
932e49579b Separate Settings editor open and search steps (#196866) 2023-10-30 07:50:27 -07:00
Connor Peet
c2a6932e9e eng: onboard to the extension test runner (#195570) 
* eng: onboard to the extension test runner

Adds a `.vscode-test.js` file that uses the new extension test CLI to
run tests. Also, onboards the markdown-language-features as the first
built-in extension to use it.

With the `ms-vscode.extension-test-runner` extension installed, the
markdown-language-features' tests can be run and debugged easily in
the UI :)

* fixup
 2023-10-13 13:11:05 -07:00
Raymond Zhao
e20515c62e Bump dependencies for debug sub-dependency (#195513) 2023-10-13 09:01:12 -07:00
Raymond Zhao
88fc434af4 Mitigate smoke test failure #195491 (#195493) 2023-10-12 20:03:27 +02:00
Raymond Zhao
b63441dbc9 Hide ToC during search if requested (#194821) 
Fixes #194812
 2023-10-10 09:49:00 -07:00
Sandeep Somavarapu
7a0fecc0a7 #191860 - retry if command is not found 2023-09-06 09:36:50 +02:00
Sandeep Somavarapu
eafe1c398d #191860 skip until insiders is released 2023-09-04 17:29:31 +02:00
Sandeep Somavarapu
63d4fe776b fix #191860 (#192121) 2023-09-04 13:30:46 +02:00
Tyler James Leonhardt
79277e0b8f Skip flakey smoke test (#191936) 
* Skip flakey smoke test

ref https://github.com/microsoft/vscode/issues/191860

* skip at describe since there's only 1 test
 2023-08-31 23:34:22 +02:00
Alpha Romer Coma
7ef754c2f6 Fix supported markdown-lint violations in markdown files (#190750) 
docs: fix supported markdownlint violations
 2023-08-24 08:37:25 +00:00
Raymond Zhao
42b4bf0670 Add Settings editor smoke tests (take 2) (#189867) 2023-08-08 13:01:53 -07:00
Raymond Zhao
39e5dafcd6 Revert "Add Settings editor smoke tests" (#189848) 
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a559.
 2023-08-07 18:40:37 +01:00
Raymond Zhao
e1dfb2a559 Add Settings editor smoke tests (#189687) 
Fixes #141054
 2023-08-07 08:22:07 -07:00
Robo
ea490e5545 chore: update to Electron 25 (#188268) 
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
 2023-08-07 21:46:27 +09:00
Benjamin Pasero
cbdfe4e0b4 Removal of feedback control (fix #188960) (#189027) 2023-07-28 10:12:52 +02:00
Raymond Zhao
5be539a588 Bump semver (#187654) 2023-07-12 01:49:45 +02:00
Raymond Zhao
c067a3bf81 chore: bump semver 7 dependencies (#187171) 2023-07-06 20:18:02 +02:00
Connor Peet
2138622b04 build: add watch/compile tasks for CLI (#182344) 
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
 2023-06-20 14:34:11 -07:00
Benjamin Pasero
4c45cff558 Data loss smoke test failures (fix #181952) (#182059) 2023-05-10 14:23:12 +00:00
Tyler James Leonhardt
378b0d711f Implement titlebar logic using a new NLS property (#177426) 
* Revert "Have English language return default result (#175157)"

This reverts commit 3c9f409888.

* Revert "Fix locale and language handling (#174779)"

This reverts commit 4e32196835.

* Revert "Add en as fallback osLocale (#175039)"

This reverts commit 7b6b6869e8.

* Revert "Ensuring locale is set to the OS locale and language is set to the Application Language (#174733)"

This reverts commit ecf479e662.

* Implement titlebar correctly using platformLocale
 2023-03-17 09:32:40 +01:00
Raymond Zhao
7b6b6869e8 Add en as fallback osLocale (#175039) 2023-02-21 17:26:37 -08:00
Tyler James Leonhardt
4e32196835 Fix locale and language handling (#174779) 
* Use language to get config and fix smoke test

* better check

* not

* fix a lot of mistakes

* skip test on linux
 2023-02-19 08:17:04 +01:00
Connor Peet
812ef50afe smoke: adopt new vscode test version (#168373) 
Has timeout logic that fixes #166092
 2022-12-08 01:14:41 +01:00
Ladislau Szomoru
96d05578ac Test - update minimatch (#167101) 2022-11-23 21:33:27 +00:00
Matt Bierner
f945df1b2d Enable strict mode and bump target for test/smoke (#165296) 2022-11-02 19:23:58 -07:00