Commit Graph

180 Commits

Author SHA1 Message Date
Andrea Mah
41606da2dc removing unecessary spaces 2021-05-19 16:59:26 -06:00
Andrea Mah
9ee1906718 pr feedback and combining prevEditor info for preview and non-preview 2021-05-19 16:57:12 -06:00
Andrea Mah
3dec3b3385 applied PR feedback 2021-05-13 12:30:10 -06:00
Andrea Mah
d2894562d5 fixing issue with static scroll alongside text editor 2021-05-12 17:59:00 -06:00
Andrea Mah
18950181eb scroll state persists while toggling between static preview and text 2021-05-12 16:59:57 -06:00
Andrea Mah
927e791753 Fix Initial Scroll Position on Markdown Dynamic Preview (#123613)
* added semicolons to pass code check

* removed preliminary work for static preview

* cleanup

Co-authored-by: Andrea Mah <t-andreamah@microsoft.com>
2021-05-11 17:12:19 -07:00
Sang
e5c466f587 markdown-language-features: Fix Windows Preview Link Uri (#120090)
* markdown-language-features: fix windows file uri

* refactor: use Uri.joinPath instead
2021-04-19 17:31:07 -07:00
Matt Bierner
d5f4e119e0 Use Array.from's map directly instead of a second call to map 2021-04-12 14:42:39 -07:00
Matt Bierner
73ae56b82b Build with latest TS nightly (#120690)
* Pick up new TS 4.3

Also tests adding override keywords for extensions as part of #120675

* Update to daily TS and workaround TS 4.3 issue

Works around https://github.com/microsoft/TypeScript/issues/43578
2021-04-07 12:19:05 -07:00
gregvanl
975115a2cb Setting descriptions typos and formatting 2021-03-25 10:17:31 -07:00
Habib Karim
9f08368e92 Handle normalized absolute file paths on markdown preview link click (#116649)
* Handle normalized absolute file paths on markdown preview link click #115812

* Parse file path using vscode.Uri
2021-02-18 19:07:22 -08:00
David Sanders
7b317afd93 Fix starting scroll for URIs with fragment (#111126) 2021-01-22 17:41:25 -08:00
Henning Dieterichs
1f8643ef76 Refresh Images In Markdown Preview On Change (#114083)
* Refresh Images In Markdown Preview On Change (implements #65258).

* Fixes tests.

* Implements etags.

* Adds tests for urlToUri.

* Updates doc comment.
2021-01-19 18:01:21 -08:00
meganrogge
0f33afa9f9 fix #112217 by replacing look behinds 2020-12-14 10:30:45 -08:00
Matt Bierner
79557ebbd2 Make sure markdown preview is updated if on disk file is updated
Fixes #111685
2020-12-09 14:08:15 -08:00
meganrogge
a2193cb827 fix #111714 2020-12-02 10:10:21 -08:00
meganrogge
5e54da666c fix #111675 and #111673 2020-12-01 17:03:47 -08:00
Erik Krogh Kristensen
7a4e81a674 fix catastrophic backtracking when parsing markdown files (#109964) 2020-11-10 14:56:06 -08:00
Megan Rogge
63d15a97c7 Support character markup in mardown smart select (#110195)
* create tests and add selection functions for inline ranges
2020-11-10 11:38:27 -08:00
David Sanders
fcef0e3db4 Use Array.flat() (#110189) 2020-11-09 12:46:26 -08:00
meganrogge
6e2aa0bfb7 clean up code and remove unused methods 2020-11-06 12:42:17 -08:00
David Sanders
153ba443d5 Use string.matchAll (#110074) 2020-11-06 11:49:56 -08:00
meganrogge
fc07b2f170 add comments to clarify code 2020-11-06 11:38:21 -08:00
Matt Bierner
24b28f57be Always use vscode.open to open markdown links
Fixes #108998

This ensures we use the custom editor if it is the default
2020-11-05 17:00:16 -08:00
meganrogge
08e556dc5d fix #109486 and #109489 2020-11-04 10:16:06 -08:00
Megan Rogge
5d4df8273e markdown smart select (#108818)
smart select
2020-10-26 15:33:48 -07:00
Matt Bierner
dd124a5cae Cleaning up code
- Use more explicit names
- extract
- Use `??`
2020-10-16 17:18:44 -07:00
Nafana
df59ceb026 Markdown reference links starting with ^ should not be clickable (#108015)
Co-authored-by: mmacovei <mmacovei@sfu.ca>
2020-10-08 00:38:17 -06:00
Matt Bierner
240afbde58 Use array.equals 2020-09-16 11:58:01 -07:00
Matt Bierner
fdf23dc5f9 Working on supporting markdown links in serverless+web
For #101203
2020-07-10 13:25:55 -07:00
Matt Bierner
3a54cd7ca3 Disable markdown commands when in markdown cells in notebooks
Fixes #101514
2020-07-06 14:59:29 -07:00
Matt Bierner
1275b918be Use joinPath in a few more places 2020-06-10 16:44:10 -07:00
Matt Bierner
b5ba760623 Adopt Uri.joinPath
For #99717
2020-06-09 16:08:42 -07:00
Matt Bierner
a51205f59d Fix markdown preview in serverless
For #99717
2020-06-09 16:04:47 -07:00
Matt Bierner
3e9b7f5072 Fix markdown fontsize
Fixes #98178
2020-05-20 15:40:27 -07:00
Matt Bierner
41ca01f942 Remove console log
Fixes #96915
2020-05-04 17:28:33 -07:00
Thomas Weingartner
b5136c0c79 Fix to 'Markdown Preview of relative links drops 'host' from path' (#95092)
* Fix #93691

* Fix #93961
2020-04-13 14:43:00 -07:00
Matt Bierner
9cfd597153 Rework markdown preview code to better support markdown preview editors
Splits the preview part of the markdown preview from the dynamic preview management part of things. Static preview swap to preview the active markdown file and don't scroll sync with any other markdown files
2020-04-11 17:30:12 -07:00
Matt Bierner
d4ce7148dd New custom editor API proposal
For #77131

Fixes #93963
Fixes #94515
Fixes #94517
Fixes #94527
Fixes #94509
Fixes #94514
Fixes #93996
Fixes #93913

This removes explicit edits from the API and reshapes the API to more closely match VS Code's internal API. The change also tries to better express the lifecycle of backups
2020-04-08 17:53:39 -07:00
Matt Bierner
d41997790c Remove CustomDocument.viewType
Fixes #93867
For #77131

This property is no longer needed (or very helpful) with the current api design
2020-03-31 12:00:17 -07:00
Matt Bierner
579dab3196 Update custom editor api
For #77131

- Use a class for `CustomDocument` instead of an interface. Extensions can now add their own data to a `CustomDocument` by sublassing

- Renamed `resolveCustomDocument` to `openCustomDocument` and require that extensions return a `CustomDocument`

- Exposed edits on `CustomDocument`

- Made the third parameter of `registerCustomEditorProvider` a generic options bag that takes a `webviewOptions`
2020-03-23 13:10:49 -07:00
Matt Bierner
9dae408dc3 Switch webview api back to use delegate model
For #77131

Going back the the delegate based model for a few reasons:

- It gives us a better approach to add additional API hooks in the future (such as for rename)

- In practive, the capabilities were almost always the same as the `userData` on the document. It is rather confusing to have both `userData` and the capabilities 'on' the document
2020-03-12 16:54:48 -07:00
Benno
0b3e54edb1 update #91296 allow multiple workspace roots (#92082)
* update #91296 allow multiple workspace roots

* update #92082
2020-03-09 12:56:54 -07:00
Matt Bierner
022b6c6d23 Use customtexteditor for markdown editor 2020-03-04 14:14:31 -08:00
Matt Bierner
6e30cf38a7 Mark markdown comment folding regions as comments
Fixes #91271
2020-03-02 11:26:29 -08:00
Matt Bierner
8291f8c152 Polishing of custom editor api proposal for 1.43 release
For #77131
2020-02-25 10:55:41 -08:00
Matt Bierner
99d5733e5f New iteration of webview editor API proposal
For #77131

**Motivation**
While our existing webview editor API proposal more or less works, building an editable webview editor is fairly tricky using it! This is especially true for simple text based editors.

It'd also be nice if we could get bi-directional live editing for text files. For example, if I open the same file in a webview editor and in VS Code's normal editor, edits on either side should be reflected in the other. While this can sort of be implemented using the existing API, it has some big limitations

**Overview of changes**
To address these problems, we've decided have two types of webview editors:

- Text based webview editors. These editors used a `TextDocument` as their data model, which considerably simplifies implementing an editable webview. In almost all cases, this should be what you use for text files

- Complex webview editors. This is basically the existing proposed API. This gives extension hooks into all the VS Code events, such as `save`, `undo`, and so on. These should be used for binary files or in very complex text editor cases.

Both editor types now have an explicit model layer based on documents. Text editor use `TextDocument` for this, while custom editors use `WebviewEditorCustomDocument`. This replaces the delegate based approach previously used.
2020-02-21 16:26:01 -08:00
Matt Bierner
8e475f9b24 Implement draft 2 from #86802 (#87117) 2019-12-16 14:18:58 -08:00
Andrew Liu
37eeb3755a quick fix (#85506) 2019-11-25 11:30:04 -08:00
Matt Bierner
cbd414ba58 Don't force refresh the markdown preview's html when changing the active document 2019-11-08 17:00:56 -08:00