Commit Graph

507 Commits

Author SHA1 Message Date
Sandeep Somavarapu 1944e5d133 Fix #135935 2021-11-03 14:05:36 +01:00
Raymond Zhao 5b7208ac08 Add -g flag for the open command (#135517)
Fixes #135291
2021-10-21 08:37:04 -07:00
Benjamin Pasero d5ecf7e9d8 fs - some 💄 and enabling of graceful-fs centrally 2021-10-21 07:17:37 +02:00
Raymond Zhao 049691cf79 Fix env passing with open cmd (#135039)
Pass process.env using env flags

Fixes #134696
2021-10-19 08:32:57 -07:00
Raymond Zhao 2aa340816f Pass process.env using env flags
Also remove redundant env in options
Fixes #134696
2021-10-13 16:25:23 -07:00
Benjamin Pasero 0e11dc34f4 CLI on macOS with -w does not exit when running multiple times (fix #134030) 2021-09-29 09:57:36 +02:00
Raymond Zhao 04c5aa46b4 Support only Big Sur, fixes #134023 (#134071) 2021-09-28 18:54:41 -07:00
Logan Ramos 12ae331012 Move appenders to be better controlled by services (#133465)
* Cleanup telemetry appenders to be owned by service

* Add telemetry level to services

* simplify

* Fix compile

* Rename supportsTelemetryLogging -> supportsTelemetry

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2021-09-22 10:39:57 -04:00
Raymond Zhao 254c5c7c86 Add prototype of mac open command (#131213)
Co-authored-by: Benjamin Pasero
2021-09-14 10:03:46 -07:00
Logan Ramos 9407123681 Intial work to add error to telemetry setting (#132996)
* Intial work to add error to telemetry setting

* deprecate and centralize the telemetry setting

* Fix compilation

Co-authored-by: SteVen Batten <stbatt@microsoft.com>
2021-09-14 10:50:25 -04:00
Benjamin Pasero 94c829afd6 macOS: application hangs when --wait is used with --verbose (fix #132611) 2021-09-08 17:26:52 +02:00
Sandeep Somavarapu 85b0df2272 rename 2021-09-08 11:44:46 +02:00
Sandeep Somavarapu 007205deac #119440 do not use optional services 2021-09-08 11:38:57 +02:00
Sandeep Somavarapu 38b3871faa #119440 Remove optional download service 2021-09-06 16:38:45 +02:00
SteVen Batten 8fb7bbabf1 fixes telemetry levels 2021-09-03 13:05:14 -07:00
SteVen Batten 9525d0e1ed centralize telemetry level (#131919)
* centralize telemetry level

* add comments and const enum
2021-08-30 10:38:42 -07:00
Akat 77905c850e fix some typo in comments, renaming few methods (#130470) 2021-08-11 17:57:48 -07:00
Matt Bierner a3cb14be7f Organize imports in vs/code 2021-08-04 17:05:16 -07:00
Benjamin Pasero e007ca899c cli - handle unhandled errors (fix #128854) 2021-08-04 13:43:07 +02:00
Benjamin Pasero 666ce447cb telemetry - avoid sync fs APIs for building CLI telemetry message 2021-06-07 15:32:35 +02:00
Benjamin Pasero 802648f2a1 electron - adopt some newer APIs and 💄 main code 2021-06-04 09:22:38 +02:00
Benjamin Pasero 949f60498a Merge pull request #124346 from microsoft/ben/pfs-promises
fs - favor non promise based methods (fix #124176)
2021-05-21 11:36:20 +02:00
Benjamin Pasero 81ef603d0d sandbox - move some files to electron-sandbox that are ready 2021-05-06 09:10:35 +02:00
Benjamin Pasero 8b2f0222be Make state service async (#122977)
* state service - make it electron-main only

* state service - make writes async

* some cleanup

* more cleanup and removal of sync fs
2021-05-05 09:30:12 +02:00
Benjamin Pasero e2954beb4b Remove --no-sandbox (#122909)
* linux - remove `--no-sandbox` flag

We should not disable sandbox on Linux.
We only added this to support running on Kernel <= 3.8 where setuid sandbox is used.

* fix ci

* add some docs
2021-05-04 11:18:19 +02:00
João Moreno 1268f86ac7 add common.platformDetail in telemetry (#121264) 2021-04-19 11:51:44 +02:00
Martin Aeschlimann 1f385f70e6 reduce usage of extensionDevelopmentLocationURI 2021-04-16 11:30:39 +02:00
Benjamin Pasero 1968bda7e6 platform#IProcessEnvironment is badly typed (fix #119046) 2021-03-30 19:05:44 +02:00
Benjamin Pasero 3a2a24e452 cli - set VSCODE_CLI earlier (#119660) 2021-03-29 14:20:45 +02:00
Sandeep Somavarapu d96f34c867 Fix #38607 2021-03-19 09:46:55 +01:00
Benjamin Pasero 68a252ea77 environment - depend on product service 2021-03-15 11:56:03 +01:00
Benjamin Pasero 1441ba91f0 environment - consistently handle VSCODE_CWD in all our node.js processes 2021-03-15 11:22:42 +01:00
Benjamin Pasero 640fa1af29 debt - use product service in more places 2021-03-15 09:49:11 +01:00
Benjamin Pasero 5a8936ae63 Lift native text file service to electron-sandbox (#118815)
* sandbox - lift native text file service to electron-sandbox

* polish docs and ensure tests actually run

* add write unlock capability

* do not use fs constants (fix tests)
2021-03-12 13:52:00 +01:00
Benjamin Pasero 0ef6619a3e services - use refineServiceDecorator for environment (#117881) 2021-03-04 17:12:44 +01:00
Benjamin Pasero f0d62c6ec2 💄 more main.ts cleanup 2021-02-12 08:30:21 +01:00
Benjamin Pasero f82462ba7c debt - move shellEnv to platform 2021-02-10 07:49:11 +01:00
Sandeep Somavarapu 2baf63ad00 use logger service for output appenders 2021-02-07 13:10:15 +01:00
Sandeep Somavarapu cdc8628d55 rename log service to logger 2021-02-05 11:38:39 +01:00
Benjamin Pasero a17c656c33 fs - some polish around file services 2021-02-03 10:32:30 +01:00
Benjamin Pasero a0d76bb983 fs - drop pfs.mkdirp in favor of node.js 2021-02-02 15:04:36 +01:00
Benjamin Pasero bf93e45b9c files - document file modes we use 2021-01-25 17:16:32 +01:00
Benjamin Pasero bd929b33de logging - put storage tracing behind a flag to reduce spam 2021-01-22 17:32:39 +01:00
Sandeep Somavarapu e7d3eb87cb 💄 2021-01-21 17:11:24 +01:00
Benjamin Pasero 6c4203f748 Modernize CLI main (#114623)
* code catchup

* state service - actually implement interface

* refactor cli main to follow our patterns

* 💄
2021-01-20 16:07:21 +01:00
Benjamin Pasero 9deba1b10a code catchup 2021-01-20 10:35:19 +01:00
Martin Aeschlimann bf90bd1518 cliProgressMain: add LocalizationsService to ServiceCollection 2021-01-18 15:09:10 +01:00
Martin Aeschlimann 84865c05ec Merge branch 'master' into aeschli/remoteCLIExtensionsManagement 2021-01-18 11:30:21 +01:00
Martin Aeschlimann 22e02e0080 use URI for VSIX paths 2021-01-18 11:16:53 +01:00
Benjamin Pasero ff9fbcb077 telemetry - lift some helpers to electron-sandbox 2021-01-18 08:48:10 +01:00