Commit Graph

1525 Commits

Author SHA1 Message Date
Matt Bierner
5d25f31b7e Re-register TS sort/remove unused commands (#210984)
Fixes #210728

Removed these as I thought they were unused
2024-04-22 20:16:38 -07:00
Matt Bierner
117c4419d6 Fix config file diag text (#210988)
Fixes #210966
2024-04-22 20:15:13 -07:00
Matt Bierner
9d2deb650d Use resolveCodeAction for organize imports (#210418)
For #210171
2024-04-15 15:19:28 -07:00
Matt Bierner
23915afd3b Exclude chat symbols from JS/TS workspace symbol results (#210095) 2024-04-10 12:27:52 -07:00
Sheetal Nandi
b2c4302323 Use vscode watches for tsserver (#193848) 2024-04-09 13:39:34 +02:00
Vladimir Piskarev
5bde174ef1 Fix incorrect typings in OpenJsDocLinkCommand_Args (#209872)
Fix incorrect typings in OpenJsDocLinkCommand_Args
2024-04-08 20:09:49 +00:00
Matt Bierner
125e308ea4 Bump @typescript-eslint versions (#209516)
6.x is the latest release that supports our current node target
2024-04-04 10:36:59 -07:00
Matt Bierner
b5f97ae0e1 Fix null access (#209449) 2024-04-03 17:37:38 +02:00
Matt Bierner
cb83e0b39b Don't use stateful regex (#209268)
Fixes #209254
2024-04-01 19:00:16 +02:00
Justin Chen
7637ca582e proper quick fix if recently edited document (#206490)
* if doc has been recently changed, wait before running code action

* checking needs delay in extension

* removed unused awaits

* removed unused checks

* remove whitespace

* remove needsDelay and adds delay in extension instead

* remove recentlyadded

* remove whitespace

* cleanup from comments

* adds back needs delay

* deal with cancellation state

* remove whitespace and needsDelay again

* clean up

* Update codeActionController.ts

* add review

* added position for extra check
2024-03-15 00:47:17 +01:00
Justin Chen
315ae79d96 ts server crash open issue reporter (#207526)
minor open reporter changes
2024-03-13 15:58:33 -07:00
Andrew Branch
d1498b3a48 [typescript-language-features] Fix autoImportFileExcludePatterns format to work on Windows (#202762)
* Do not prefix autoImportFileExcludePatterns with `/`

* Fix autoImportFileExcludePatterns format
2024-03-13 07:51:45 +00:00
Matt Bierner
c087be9705 Adopt module 'Preserve' for TS 5.4+ (#206478) 2024-03-07 13:35:56 -08:00
Matt Bierner
6403b4367b Pick up latest TS for building VS Code (#207096) 2024-03-07 12:59:59 -08:00
Matt Bierner
a5abe07cea Remove buffers that shouldn't be validated from geterr request (#206843)
Fixes #206644
2024-03-04 13:40:39 -08:00
Matt Bierner
2ad2a35cad Make sure we don't report errors in chat code blocks (#204779) 2024-02-21 08:53:05 -08:00
Ulugbek Abdullaev
b4e834f6fd Removed Copilot related code from TypeScript Refactor Provider 2024-02-21 12:44:54 +01:00
Justin Chen
7ff2572a3e remove leftover console log in quickfix (#205022)
removed leftover log
2024-02-12 19:45:06 +01:00
Matt Bierner
428dd56479 Try to observe TS usage of insert/replace (#204661)
Fixes #204037

- Replace span on item == use for both insert and replace
- Optional replacement span == use only for replace
2024-02-07 15:21:42 -08:00
Matt Bierner
a1fb0dcd2e Put all chat code blocks in same implicit JS/TS project (#204655) 2024-02-07 14:47:44 -08:00
Yves Daaboul
0786b4d2fb fix(193523): JSDoc optional parameters don't display in functions (#202963)
* Issue193523: Brought back optional params to autocompletion preview

* #193523: Hided end-of-list optional params

* #193523: Added unit tests

* #193523: Fixed integration tests

* Update extensions/typescript-language-features/src/languageFeatures/util/snippetForFunctionCall.ts

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-02-06 03:59:23 +00:00
Justin Chen
9f50c3dc2a groundwork for code action ranges for quick fix (#204191)
* added in config

* fix balance between diagnostic and range

* cleanup
2024-02-05 14:13:18 -08:00
Nathan Shively-Sanders
5e6ec068b2 Split TS' AI-backed code actions into separate entries (#201140)
* Split TS' AI-backed code actions into separate entries

Lets the user decide whether to add AI to their code action, which shows
intent, which is good for us to learn whether people actually want this.

Related: this should be unflagged for insiders. To do this, do I just
delete the flags?

* Stop appending a duplicate message in missingFunctionDeclaration

* Fix: quickfix was still showing Copilot-only

It's a workaround--I'm not sure of the right way to do this.

* Update to use `isAI`

* Put AI code actions after others.

* Add isAI to rest of code actions

* Remove flags for TS AI code actions

* Check for copilot-chat instead of copilot

It's possible to have copilot installed without copilot-chat.

* Fix file casing

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-01-31 22:46:39 +00:00
Matt Bierner
e9ce823bf1 Fix potential race creating JS/TS temp dir (#203367)
Fixes #203335
2024-01-29 09:24:41 -08:00
Matt Bierner
34b0301287 Fix insert range of ts entries with replacement spans (#202287)
Fix #202153
2024-01-11 23:27:22 +01:00
Ronak Jain
c1bc5415f8 Fix tsserver crashing when using custom node path (#201966)
* use quotes in spawned process name

* Use JSON stringify to handle quotes as well
2024-01-09 11:02:53 -08:00
Matt Bierner
ee91ce84bb Show TS Server commands in diff editors and notebook cells (#201847)
Fixes #201734

Switches to use tabs so that we can enable TS commands if you're in a JS/TS editor in a diff editor or notebook cell
2024-01-04 15:54:50 -08:00
Johnson Chu
40c0f939e5 Fix optionalReplacementSpan not being applied to completion entries (#200945)
* Fix optionalReplacementSpan not being applied to completion entries

* Format completions.ts
2024-01-03 14:40:11 -08:00
Andrew Branch
a1cfe91f9c Fix preferTypeOnlyAutoImports preference getter (#201376) 2024-01-03 18:55:21 +00:00
Matt Bierner
9621add460 Fix undefined getting printed (#201250)
Fixes #201244
2023-12-20 00:22:43 +01:00
Isabel Duan
948f6a1aaf fix typescript/54492: check if file rename changes extension (#200220)
check if file extension has been changed
2023-12-13 01:23:10 +00:00
Matt Bierner
a0d9408921 Use satisfies in a few more places (#200181)
Avoids casing issues
2023-12-06 12:27:47 -08:00
Matt Bierner
cd9b560777 Lowercase separator title (#200184)
Matches our other labels
2023-12-06 21:13:13 +01:00
Matt Bierner
673006e0e3 Fix copilot quick fix (#200162) 2023-12-06 18:15:48 +01:00
Aiday Marlen Kyzy
30ac9a452d Making move to code action appear less often (#198864)
taking code from other pr
2023-11-29 02:00:19 +01:00
Michael Lively
e33219dde3 Add multi-document highlight provider feature (#198467)
* multi-doc api + text provider editor feature + extHost hookup + typescript semantic multi-doc

* fix disposable leak, wasn't setting providers to the disposableMap

* filter unnecessary models to fix errors with typescript provider

* fix nits (todo - doc filter)

* fix typo from merge conflict

* expose LanguageSelector in multi-doc provider, filter out 0 score models
2023-11-22 10:07:20 -08:00
Aiday Marlen Kyzy
9524207999 Reverting changes in TypeScript language features extension (#198858)
Revert "Merge pull request #198775 from microsoft/aiday/typeScriptChanges"

This reverts commit 5d9d06611b, reversing
changes made to 823d54f86e.
2023-11-22 14:55:04 +01:00
Aiday Marlen Kyzy
edf26e4bae polishing the code with review 2023-11-22 11:08:47 +01:00
Aiday Marlen Kyzy
ddc7a1e51a tweaking the recursion, so that we do not do the recursion for a long time 2023-11-21 17:40:06 +01:00
Aiday Marlen Kyzy
5e89263580 polishing the code after review 2023-11-21 15:42:14 +01:00
Aiday Marlen Kyzy
e46541edaf removing export 2023-11-21 15:06:59 +01:00
Aiday Marlen Kyzy
5b297c488c Squashed commit of the following:
commit bc4dc881ba
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 13:07:39 2023 +0100

    adding one more possibility which is lightbulb sparkle and auto-fix

commit a5dfa1f620
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:55:44 2023 +0100

    removing one because should be using zero based ranges

commit 78b29c0b56
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:49:50 2023 +0100

    using the navTree request instead

commit ba1b8fef77
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:20:38 2023 +0100

    polishing the code

commit 5ae767f43a
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 12:14:35 2023 +0100

    polishing the code

commit fd347bb0e2
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 11:03:04 2023 +0100

    remembering the class array that was previously set, so not removing the whole class array

commit fd5fd11bfc
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 10:54:18 2023 +0100

    using the appropriate icon

commit df29259136
Merge: 5285e1d97e 633efd8c55
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Tue Nov 21 10:47:18 2023 +0100

    Merge branch 'main' into aiday/differentLightBulbDependingOnCodeAction

commit 5285e1d97e
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 18:24:45 2023 +0100

    making the filtering function synchronous

commit a86c36c6b0
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 17:42:11 2023 +0100

    adding code in order to also include move to a new file only when on the range of interest

commit 2cedc2ffb4
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 17:11:13 2023 +0100

    not showing move to file all the time

commit 8f4ade1d3d
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:50:56 2023 +0100

    removing the code which does the selection check

commit 2e0e6c534e
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:31:55 2023 +0100

    adding code in order to execute the AI code action when it is unique

commit a037c7e8e9
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Mon Nov 20 14:05:32 2023 +0100

    adding code in order to be able to detect when different code actions partitions appear

commit abd005b78b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 18:07:26 2023 +0100

    changing the heuristic of the move to code actions

commit e4886eab7a
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:25:57 2023 +0100

    removing model

commit 79102a983b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:25:48 2023 +0100

    making lightbub icon appear on empty lines

commit ee8bb3475b
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:09:15 2023 +0100

    directly resolving the code action when it is an ai code action

commit 4d4bcb9b34
Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Date:   Fri Nov 17 17:02:34 2023 +0100

    wip allow lightbulb menu to specify different icons depending on the code actions
2023-11-21 15:05:17 +01:00
Matt Bierner
620340c863 Bump hardcoded web TS version (#198713) 2023-11-21 00:25:20 +01:00
Matt Bierner
1d92f24bd8 Add telemetry for TS ai refactorings (#198708) 2023-11-20 15:01:33 -08:00
Matt Bierner
032109e5a7 Don't show references on anon function (#198711)
Fixes #198389
2023-11-20 23:08:00 +01:00
Matt Bierner
6805bb6d2b Hook up mapped code edits experiment for TS (#198478)
For https://github.com/microsoft/TypeScript/pull/55406
2023-11-17 02:07:09 +00:00
John Murray
77dc8793db Add typescript.implementationsCodeLens.showOnInterfaceMethods setting (#136282) (#198419)
* Add `typescript.implementationsCodeLens.showOnInterfaceMethods` setting (#136282)

* Update codelenses when `typescript.referencesCodeLens.showOnAllFunctions` changes

* Improve handling of disposables
2023-11-16 22:46:41 +00:00
Matt Bierner
d98713bad1 Always send CodeActionTriggerKind (#198364)
Makes us always send this along instead of sometimes sending undefined
2023-11-15 14:02:55 -08:00
Ronak Jain
d72005bfa7 Fix tsconfig resolution for navigation (#192851)
* Fix tsconfig resolution

* Resolve based on link type
2023-11-06 11:46:09 -08:00
Matt Bierner
c57992a973 Always run code lens implementations on semantic server (#197578)
Fixes #197286

Already fixed this for references code lens. Just porting it to impl code lens now too
2023-11-06 20:05:00 +01:00