See https://github.com/microsoft/vscode/issues/119899
Backwards compatible, initially. The implementation should be
pretty unsurprising. Some churn from data wiring.
This does the bulk of the work. The only remaining item is caching
the last renderer used for notebooks in the workspace to avoid running
selection again if the user reopens/reloads the window.
* notebookDocumentsAndEditors -> owns the truth of the notebooks and editor that extensions know about
* notebookEditor -> everything about editors
* notebookDocuments -> everything about documents
* Add an untitled document data property
* Dispose of the model passed back
* Fix layer problem
* Add untitledDocumentData to untitled notebooks
* Fix compilation errors
* Switch to using VS Buffer
* Fix threading the untitled document data back through
* Prevent save dialog on untitled reopen with
* Change ignore save setting
* Change setting name and abide by preserve focus
* Add unit test
* Switch to js doc comments
* Consolidate calculating the untitled value, and added test
* Move editorOpenWith to the editorService
* Remove custom editor input handling
* Fix open with API command
* adopt master properly
* Remove dnagling comment
* Address some feedback
* Cleanup region comment.
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* Cleanup region comment.
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
* Update override typings
* Fix missing picker
* Fix bug with reopen with
* Remove duplicate import
* First round of feedback via changes
- OverrideOptions => EditorOverride
- It is safe to destructure (...) undefined
- Ensure when destructuring, override is always winning
- Not a big fan of shared builtinProviderDisplayName import
* editorservice - static DEFAULT_EDITOR_OVERRIDE_ID
* editors - introduce a editor associations registry
This moves the relevant code out of the editor service.
* cleanup editor picking
* cleanup editor delegate
* final 💄
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
