Commit Graph

16 Commits

Author SHA1 Message Date
Matt Bierner
5b639e8b22 Also log viewType
This is needed for extensions that contribute multiple types of webviews
2021-06-11 16:22:43 -07:00
Matt Bierner
e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Matt Bierner
c4ceba7cb7 Add events for when the active webview changes
This attempts to move the custom code we have in `mainThreadWebviewPanels` to the normal webview services
2021-03-31 15:31:14 -07:00
Matt Bierner
3499f63dc1 Exploration: Better transferring of TypedArrays used in Webview.postMessage (#115664)
* Improve passing of ArrayBuffers to and from webviews

Fixes #115807

* Serialize and restore typed arrays too

This also makes it so that if you pass the same ArrayBuffer twice in an object, we use a single object on the receiver side too

* Fix spelling

* Require VS Code 1.56+
2021-03-30 06:49:34 +00:00
Benjamin Pasero
5e3df4ce30 debt - onDispose => onWillDispose 2021-03-29 08:21:09 +02:00
Matt Bierner
ea5f05a435 Trying to clairify how webview options are used and passed around
- Move protocol types into protocol
- Hold off on combining the options objects until serialization
- Add explicit converstions instead of using `...`
- Make a few methods take property bags to help avoid passing arguments in wrong order
2021-03-05 18:49:17 -08:00
Matt Bierner
5bff5459d1 Move webview icons from generic webview service to the webview workbench service
WebviewIcons are only used for webview panels
2021-03-04 18:42:55 -08:00
Matt Bierner
542670762f Make sure we dispose of webview revivers when the main thread extension host is disposed of 2020-12-15 16:26:07 -08:00
Matt Bierner
03c528450f Small formatting cleanup 2020-12-15 16:26:07 -08:00
Benjamin Pasero
630e706ad2 Add open context to certain commands (#110475)
* editor commands - move API commands to workbench core

* rename EditorViewColumn => EditorGroupColumn

* mixin context to open commands

* address some feedback

* add comment
2020-11-12 17:01:13 +01:00
Matt Bierner
a4a4cf5ace Re-resolve webview views when extension host restarts
Fixes #108555

Previously webviews were left hanging when the extension host died. With this change, we now try to re-create them once the extension host restarts
2020-10-19 19:00:16 -07:00
Matt Bierner
51dc3193d3 Move webview editor into own module
This splits the core `webview` element services from the `webview` editor services.
2020-09-14 16:08:29 -07:00
Matt Bierner
80b1a775d6 Enable webview commands for webview views
Fixes #105670

Previously our webview commands assumed that webviews were always going to be in an editor. This is no longer true with webview views.

To fix this, I've added an `activeWebview` to the `IWebviewService`. This  tracks the currently focused webview.
2020-09-09 14:44:46 -07:00
Matt Bierner
08be66406f Make context the first arugment to constructors 2020-08-27 13:51:11 -07:00
Matt Bierner
9b117bbb1d Move custom editor activation into mainThreadCustomEditors 2020-08-27 13:51:11 -07:00
Matt Bierner
72cbf699d8 Split out main thread webview panels into own class/file 2020-08-26 16:46:26 -07:00