Commit Graph

110 Commits

Author SHA1 Message Date
Megan Rogge
4ccad80121 fix #119322 (#120143) 2021-03-30 09:39:10 -07:00
Daniel Imms
02d3809824 Allow undefined in terminal env map, unify interfaces
Note that this adds undefined as an option to TerminalOptions.env which could end up
causing compile errors, but they will be more correct and could reveal a bug in an
extension since some key could return undefined.

Fixes #119046
2021-03-26 14:40:12 -07:00
Daniel Imms
d02a4aacba Remove quick launch terminology from code
Fixes #119815
2021-03-26 09:56:20 -07:00
Megan Rogge
7a9844238d terminal profile fixes (#119267)
This PR fixes #119200
fixes #119275
fixes #119277
fixes #119283
fixes #119141
2021-03-18 20:16:07 -07:00
Megan Rogge
e8e6d64105 Terminal profiles (#118790)
* get basics working in current dropdown

* filter profiles based on what we want in the dropdown and other info

* add copywright

* terminal.ts -> terminalProfile.ts

* seperate linux distro code

* improve terminalConfig setting description

* add passing tests and fix #79572

* add test for login args

* add wsl stuff

* fix #77652

* lengthen throttle time to 10s

* shell -> process and fire update profiles so dropdown is updated

* consolidate code in terminalProfile

* change profile selection logic

* change profile config structure

* use <ProfileName, IterminalProfileObject> and get wsl distro names to look normal

* provide terminalConfig to terminalProfiles

* move detection/validation to terminalProfiles

* isWorkspaceShellAllowed

* add quickPickOnly so Select Default Profiles returns all and otherwise filters based on config

* Add logs for errors within terminalProfiles

* change return type

* use sync

* fix bug, get custom generated to work

* workspace shell permissions

* add some comments and clean up

* when ext host ready update profiles

* improve terminalProfileObjectEqual check

* don't use windows powershell unless no other powershell
2021-03-16 17:02:59 -07:00
Daniel Imms
a5c28d0ca0 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control 2021-03-04 08:02:36 -08:00
meganrogge
ba117e60c2 fix #118043 2021-03-03 16:49:38 -08:00
Megan Rogge
cf3faa4046 Don't relaunch extension owned terminals (#117987)
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-02 13:55:38 -08:00
Daniel Imms
647773d7e6 Rename terminal id to instance id
Part of #117978
2021-03-02 11:08:12 -08:00
Daniel Imms
a418778243 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control 2021-02-26 13:08:09 -08:00
Daniel Imms
91a246998c Remove flow control setting
Flow control is enabled for all non-extension terminals

Fixes #117418
2021-02-26 05:59:58 -08:00
Daniel Imms
df5d7c257d Remove exthost terminal processes
Fixes #116864
2021-02-26 04:35:03 -08:00
Megan Rogge
68a47518f8 move things back to platform and delete duplicate code 2021-02-11 12:19:25 -08:00
Megan Rogge
a35338b250 move things back to the workbench and leave only necessary items in platform 2021-02-11 11:02:03 -08:00
Megan Rogge
da39b7af3e create PersistentTerminalProcess and move terminal and environmentVariable files from workbench -> platform 2021-02-10 15:26:05 -08:00
Daniel Imms
6132a763bc Get one way communication happening 2021-02-09 04:07:38 -08:00
Daniel Imms
456841a93b Create createProcess ipc interface 2021-02-08 12:37:10 -08:00
Megan Rogge
dac8d916d5 fix #110936 2021-01-25 11:21:57 -08:00
Daniel Imms
f8ec60aa06 Add flow control setting, remove fake latency 2021-01-14 06:04:03 -08:00
Daniel Imms
0a19f7702a Rename ackId to charCount 2021-01-12 11:36:21 -08:00
Daniel Imms
bf52d50a0a Remove ackId from data events going to client 2021-01-12 11:27:51 -08:00
Daniel Imms
6430ee1efc Basic flow control for ext host processes
Part of #113827
2021-01-12 09:39:45 -08:00
Daniel Imms
16452c54f3 Merge pull request #113938 from microsoft/alex/terminal-exthost-improvements
Avoid timeouts in mirroring terminals to the extension host
2021-01-07 09:29:17 -08:00
Alexandru Dima
3d8888779d Fixes #112446: Avoid timeouts in mirroring terminals to the extension host by assigning a temporary UUID to terminals created on the extension host side 2021-01-07 00:13:42 +01:00
Konstantin Solomatov
3136ecb1d3 Do not ignore errors from $spawnExtHostProcess 2020-12-07 09:22:25 -08:00
Rob Lourens
89540b65db Don't persist debug terminals
#109084
2020-10-22 17:02:18 -07:00
Alex Dima
1892ef16f3 Add Remote Terminals Restoring
Co-authored-by: Rob Lourens <roblourens@gmail.com>
2020-10-20 21:31:58 +02:00
Daniel Imms
aa6b2f163d Initial terminal welcome support 2020-08-27 12:38:33 -07:00
Daniel Imms
f542cd1f76 Queue initial term data events for ext host delayed init
Fixes #103697
2020-08-13 11:00:40 -07:00
Daniel Imms
2b353aac93 Remove terminal link handlers
Fixes #91606
2020-08-10 14:19:55 -07:00
Daniel Imms
4c145dbb40 Expose Terminal.hideFromUser on all ext hosts
Fixes #103288
2020-07-27 12:11:10 -07:00
Daniel Imms
e8c3ff351b Log ext host terminal process requests 2020-07-24 06:46:25 -07:00
Daniel Imms
a560acd1bd Remove test link provider 2020-06-21 18:01:33 -07:00
Daniel Imms
cb5ddcf44f Resolve todos, move process creation after xterm
Having _processManager.createProcess called before _createXterm was causing
some event listeners like onProcessReady to fire before they were registered
within _createXterm.
2020-06-21 08:12:13 -07:00
Daniel Imms
395b228387 Merge remote-tracking branch 'origin/master' into tyriar/link_providers 2020-06-19 05:26:26 -07:00
Daniel Imms
a0558707ec Handle link on exthost 2020-06-18 05:15:04 -07:00
Alex Dima
39e3340d04 Push not-null assertion further down to usage 2020-06-18 13:18:47 +02:00
Daniel Imms
2dbf1703b8 Get link providers passing all the way through to the renderer 2020-06-17 12:10:03 -07:00
Daniel Imms
d8a2d483da Remove unneeded async 2020-06-12 11:15:55 -07:00
Daniel Imms
1dd4c04384 Fix launching in ext host/pty terminals 2020-06-12 11:05:45 -07:00
Daniel Imms
000f8392b3 Only persist collections marked to do so 2020-03-27 09:03:53 -07:00
Daniel Imms
d91532afa8 Load in persisted collections from past sessions on ext host 2020-03-27 07:44:56 -07:00
Daniel Imms
edc7100114 Apply multiple extension mutators, share code with ext host 2020-03-26 15:40:03 -07:00
Daniel Imms
a4cc3c1fcd Add tests for EnvironmentVariableCollection 2020-03-26 11:48:41 -07:00
Daniel Imms
ed9e7241b7 Move single ext collection updates across 2020-03-25 11:57:12 -07:00
Daniel Imms
b41b85d224 Start building out env var service 2020-03-25 07:26:11 -07:00
Daniel Imms
a087c17b59 Remove logs 2020-03-13 07:05:53 -07:00
Daniel Imms
b66d56602f Implement terminal link handler API
Part of #91606
2020-03-12 18:17:18 -07:00
Daniel Imms
5fad95f544 Change getDefaultShellAndArgs to use promises
Part of #75793
2020-02-05 12:03:45 -08:00
Daniel Imms
1aefcce704 Change requestAvailableShells to use promises
Part of #75793
2020-02-05 11:55:14 -08:00