Rob Lourens
4a76f0b19a
registerNotebookCellStatusBarItemProvider should use viewType instead of NotebookSelector
...
Fix #122347
2021-05-07 15:23:19 -07:00
Johannes Rieken
fa378cd02a
move NotebookCellExecutionTask into extHostNotebookKernels, fyi @roblourens
2021-05-07 14:27:07 +02:00
Johannes Rieken
b177753668
check that a cell is still "alive" and only iff so start executing it, fixes https://github.com/microsoft/vscode/issues/123269
2021-05-07 14:14:14 +02:00
Johannes Rieken
6764639ce6
store extension identifier with NotebookProviderInfo
2021-05-07 09:48:40 +02:00
Johannes Rieken
f5b2c93911
Allow to pass NotebookRegistrationData when registering serializer or content provider, https://github.com/microsoft/vscode/issues/122733
2021-05-06 16:26:57 +02:00
Johannes Rieken
23a6935a25
slim-down NotebookProviderInfo
2021-05-05 11:55:30 +02:00
Rob Lourens
8e51485f45
Debounce cell output edits from EH
...
Fix #119832
2021-04-22 12:48:38 -07:00
Johannes Rieken
e2c9703995
prefix api object with api-prefix, like apiCell
2021-04-21 15:34:44 +02:00
Johannes Rieken
5c3383251a
unique working copy type id, stricter view types
2021-04-21 09:06:32 +02:00
Rob Lourens
64282aa6b7
Use new cell statusbar for execution items.
...
Support color and icon info on cell statusbar items.
2021-04-20 17:57:25 -07:00
Johannes Rieken
b2b45e1005
execute by cell-handle, kernel manager has only execute/cancel cells, also "fix" isNotebookCellData fyi @rebornix
2021-04-20 14:39:19 +02:00
Johannes Rieken
b06388f501
Merge branch 'joh/clean-kernel' into notebook/dev
2021-04-20 11:33:41 +02:00
rebornix
d415fc0d0e
adopt notebookSelector in status bar API.
2021-04-19 10:15:26 -07:00
Johannes Rieken
11c3ba58af
remove NotebookKernelProvider API and its implementation
2021-04-19 16:19:23 +02:00
Johannes Rieken
8877d8ca94
hook up execution task cancellation from controllers
2021-04-16 10:51:45 +02:00
rebornix
8629b48030
rename transientMetadata to transientCellMetadata.
2021-04-15 17:24:47 -07:00
rebornix
662ea12128
NotebookCellRange is now NotebookRange.
2021-04-15 13:09:37 -07:00
Johannes Rieken
bbf148b0c6
merge renderer IPC into notebook controller, remove global renderer IPC
2021-04-15 18:41:56 +02:00
Johannes Rieken
b6cee1ca22
add cancellation to NotebookSerializer, https://github.com/microsoft/vscode/issues/121329
2021-04-15 16:21:06 +02:00
Johannes Rieken
afa4a2df2c
rename to serializeNotebook and deserializeNotebook, https://github.com/microsoft/vscode/issues/121329
2021-04-15 16:19:06 +02:00
Rob Lourens
3e5c20b762
Change execution duration to startTime/endTime
2021-04-14 17:21:05 -07:00
Rob Lourens
3e40e14bc4
Cell statusbar API ( #121215 )
...
Implement provider-based notebook cell statusbar API
2021-04-14 11:26:23 -07:00
Johannes Rieken
9c0300872e
simpler storing of ExtHostNotebookEditor
2021-04-14 18:43:12 +02:00
Johannes Rieken
02f0f4a0c8
make createNotebookRendererCommunication independent of controller, make it renderer first
2021-04-14 18:33:14 +02:00
Johannes Rieken
d6ae97cf97
add Kernel2#createNotebookRendererCommunication
2021-04-14 15:09:06 +02:00
Johannes Rieken
fcd005ce8c
fix compile errors, evolve internal API about kernel selection
2021-04-13 14:29:46 +02:00
Connor Peet
60a7c6a925
notebooks: add initial kernel/renderer constraints
...
See https://github.com/microsoft/vscode/issues/119899
Backwards compatible, initially. The implementation should be
pretty unsurprising. Some churn from data wiring.
This does the bulk of the work. The only remaining item is caching
the last renderer used for notebooks in the workspace to avoid running
selection again if the user reopens/reloads the window.
2021-04-12 16:30:39 -07:00
rebornix
f7e5a67039
NotebookDocumentShowOptions#selections.
2021-04-12 16:05:34 -07:00
Johannes Rieken
e200749f88
remove NotebookEditor#onDidDispose
2021-04-09 13:27:29 +02:00
Matt Bierner
e1f0f8f513
Add override keyword in codebase ( #120755 )
...
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Johannes Rieken
fca1144d00
remove NotebookDocument#cells in favor of cellsAt, getCells, and cellCount
2021-04-06 11:50:48 +02:00
Johannes Rieken
ca980ecfac
update notebook editor view column when moving editors, https://github.com/microsoft/vscode/issues/115704
2021-03-31 18:09:39 +02:00
Johannes Rieken
fa48622fdf
split mainThreadNotebook up into logical pieces
...
* notebookDocumentsAndEditors -> owns the truth of the notebooks and editor that extensions know about
* notebookEditor -> everything about editors
* notebookDocuments -> everything about documents
2021-03-31 15:44:31 +02:00
Johannes Rieken
d13f3b4a2f
remove NotebookContentProvider#resolveNotebook
2021-03-29 12:21:45 +02:00
Rob Lourens
961935482f
Fix build
2021-03-25 20:25:40 -07:00
Rob Lourens
33c5dbf040
Force internal execution metadata to be transient
...
Fix #119853
2021-03-25 19:58:50 -07:00
Rob Lourens
c5a8eed033
Accept array or single item for output items methods
...
#119601
2021-03-25 09:39:09 -07:00
Rob Lourens
1a425eacb8
Accept single outputs or arrays in execution task output edit methods
...
Fix #119601
2021-03-24 17:48:26 -07:00
Rob Lourens
7b96cc4c8b
Implement Execution API ( #116416 )
...
Implement new execution task API
#106744
Fix #105847
2021-03-22 11:27:00 -07:00
Johannes Rieken
7d99c47b75
move notebook save event into notebook editor model service, remove resolve/save/backup from notebook service and let editor model use content provider directly
2021-03-19 13:13:40 +01:00
Johannes Rieken
232266aaf2
first cut of IFileWorkingCopy adoption, misses saveAs and backsnapshot are improper...
2021-03-18 15:26:18 +01:00
Johannes Rieken
31283f32b2
keep notebook serializer locally
2021-03-16 14:52:24 +01:00
Johannes Rieken
2de06d768b
add INotebookSerializer interfaces and wire up IPC calls
2021-03-16 13:19:33 +01:00
Johannes Rieken
fdd57917f3
don't mixin default metadata when "replacing" notebook metadata
2021-03-11 09:16:24 +01:00
Logan Ramos
c72d7612b4
Add an untitled document data property ( #115790 )
...
* Add an untitled document data property
* Dispose of the model passed back
* Fix layer problem
* Add untitledDocumentData to untitled notebooks
* Fix compilation errors
* Switch to using VS Buffer
* Fix threading the untitled document data back through
* Prevent save dialog on untitled reopen with
* Change ignore save setting
* Change setting name and abide by preserve focus
* Add unit test
* Switch to js doc comments
* Consolidate calculating the untitled value, and added test
2021-03-10 19:54:18 +00:00
Johannes Rieken
8fd2402570
:liptstick: deep freeze notebook events before emitting them
2021-03-10 15:48:30 +01:00
Johannes Rieken
637b659e4a
refine NotebookCell API
2021-03-10 14:49:05 +01:00
Johannes Rieken
a6d7d86e85
remove viewType from openNotebookDocument call
2021-03-10 14:30:40 +01:00
Johannes Rieken
0f64ef1b65
remove NotebookDocument#contentOptions
2021-03-09 17:44:22 +01:00
Johannes Rieken
9cc276648e
remove onDidChangeCellLanguage-event in favor of the existing document closed/opened event sequence
2021-03-09 15:14:30 +01:00
