Commit Graph

96 Commits

Author SHA1 Message Date
Johannes Rieken
5f406230c9 use keybinding instead of setting, show provider name (iff possible) 2019-07-01 09:43:41 +02:00
Johannes Rieken
c8843e3b0d final touch at heap service removal, #74846 2019-06-19 10:58:24 +02:00
Matt Bierner
580bd304c9 Don't use heap service for signature help
For #74846

Migrates from using the heap service to have an explicit lifecycle
2019-06-13 17:49:00 -07:00
Matt Bierner
592b91b5cb Use readonly for cache
This type never modifies the input arrays
2019-06-13 16:43:09 -07:00
Matt Bierner
1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
2019-06-07 18:26:19 -07:00
Matt Bierner
b4a00ca33f Replacing heapservice with lifecycle for code actions
Part of #74846

Code Actions can use commands internally, which must be disposed of. We were previously using the heap service for this but this will not work for the web. Add a custom lifecycle instead
2019-06-06 22:12:56 -07:00
Johannes Rieken
6a4467da59 for completions use CommandsConverter.toInternal2, #74846 2019-06-05 09:38:49 +02:00
Johannes Rieken
a73b4236b0 properly keep resolved code lens command, #74846 2019-06-05 09:38:49 +02:00
Johannes Rieken
35643d80e0 add lifecycle to code lens, #74846 2019-06-05 08:52:31 +02:00
Johannes Rieken
6f1da34c2e debt - decouple webviews from code insets, move things to /browser/-layer, change inset api proposal to push style, re #66418 2019-06-04 12:31:18 +02:00
Johannes Rieken
034165ac67 don't cache provider results when request was cancelled, #74446 2019-05-28 12:15:53 +02:00
Alex Dima
9fb9ca51a6 Add transformOutgoingScheme to IURITransformer 2019-05-24 12:46:48 +02:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00
Johannes Rieken
81456a7212 move api/common to api/browser 2016-01-11 14:44:13 +01:00
Johannes Rieken
2e95c110f4 use weak references to track TextDocument that were given out to consumers 2016-01-11 12:50:40 +01:00
Johannes Rieken
d78646888a refactor ExtHostDocumentModel to ready for node_module consumption 2016-01-11 10:50:25 +01:00
Johannes Rieken
f2bba12f8b 🔼 move thenable<->promise utility to async 2016-01-06 16:19:44 +01:00
Johannes Rieken
2e50c91b24 correct command argument caching for CodeLensProvider, fixes #1698 2016-01-05 10:38:02 +01:00
Johannes Rieken
fa1c52de3b towards code lens lifecycle, still #1698 2016-01-04 18:48:19 +01:00
Johannes Rieken
ff077c103e create dummy commands (and manage them) when code action or code lens commands have argument #1698 2016-01-04 16:22:28 +01:00
Benjamin Pasero
5906207073 workbench api linting 2015-12-21 18:51:51 +01:00
Johannes Rieken
8aadd81678 debt - rename PluginHostXYZ to ExtHostXYZ, do the same for filenames 2015-12-21 11:46:00 +01:00
Martin Aeschlimann
b1ea910757 Move overwriteBefore/overwriteAfter to ISuggestion 2015-12-11 11:18:43 +01:00
Johannes Rieken
bf6db83167 unused imports and other tslint findings 2015-12-10 15:25:06 +01:00
Johannes Rieken
cda49cc891 debt - no id property on ISuggestion 2015-12-03 18:22:02 +01:00
Johannes Rieken
2eebf162e6 debt - add ISuggestion.textEdit and fill it in when missing 2015-12-03 18:05:53 +01:00
Johannes Rieken
5148523b6d debt - rename ISuggestions to ISuggestResult 2015-12-03 18:05:52 +01:00
Johannes Rieken
797f9bf0ab make quick fix be a command and a score 2015-12-02 13:02:25 +01:00
Johannes Rieken
a7f719e46c command: executeCodeLensProvider 2015-12-01 16:02:16 +01:00
Johannes Rieken
1d7819f052 command: executeCompletionItemProvider 2015-12-01 11:54:48 +01:00
Johannes Rieken
893a78374d commands: executeDocumentSymbolProvider 2015-11-27 16:08:52 +01:00
Johannes Rieken
67084502b5 commands: executeSignatureHelpProvider, executeDocumentRenameProvider 2015-11-27 15:35:36 +01:00
Johannes Rieken
6497432d1c first steps in exposing language featues as command. done with: hover, definition, workspace symbols 2015-11-27 13:03:11 +01:00
Johannes Rieken
7d1de2c673 signature help provider as support 2015-11-26 12:34:48 +01:00
Johannes Rieken
253b92ed0b completion item provider as support 2015-11-26 12:09:57 +01:00
Johannes Rieken
9ce3f2cfda rename provider as support 2015-11-26 11:33:54 +01:00
Johannes Rieken
a7ff9cdb48 workspace symbol provider as support 2015-11-26 11:00:27 +01:00
Johannes Rieken
70988681fa formatting edit provider as support 2015-11-26 10:00:46 +01:00
Johannes Rieken
c9fd775ddd code action provider as support 2015-11-26 09:33:04 +01:00
Johannes Rieken
2ede316636 reference provider as support 2015-11-25 18:37:11 +01:00
Johannes Rieken
d3584c91a1 doc highlight provider as support, also use IModel 2015-11-25 17:51:58 +01:00
Johannes Rieken
1b1e583a68 hover provider as support 2015-11-25 16:59:52 +01:00
Johannes Rieken
31d872e081 definition provider as support 2015-11-25 16:08:40 +01:00
Johannes Rieken
770ede158a One code lens provider is one code lens support, fixes #360 2015-11-25 12:48:55 +01:00
Johannes Rieken
bd93ccb864 add tests for the document symbol provider 2015-11-25 12:02:15 +01:00
Johannes Rieken
b370792f68 fix document symbol duplication
each provider is represented as one support, have a provider to support adapter
2015-11-25 11:01:38 +01:00