Commit Graph
1382 Commits
Author SHA1 Message Date
Benjamin Pasero 4d0b3d025e debt week code cleanup
- avoid public modifier
- use Disposable where applicable
- fix some event handler leaks
- clean up some TODO@ben
2018-07-02 10:55:26 +02:00
SteVen Batten db2f851c8c fixes #53254 2018-06-29 17:39:08 -07:00
Daniel Imms 013a59dd32 Disable terminal menu
Part of #53158
2018-06-28 06:34:20 -07:00
Benjamin Pasero 368ab9c31b use systemPreferences.setUserDefault() to workaround #35361 2018-06-26 06:56:23 +02:00
Benjamin Pasero 9719d316ca Revert "Fix #35361: fix native tabs on macOS 10.13 (#52775)"
This reverts commit 8e03e03131.
2018-06-25 19:03:21 +02:00
zhuowei 8e03e03131 Fix #35361: fix native tabs on macOS 10.13 (#52775)
* Fix #35361: fix native tabs on macOS 10.13

macOS 10.13 mistakenly enables a compatibility option on VS Code
and VS Code Insiders because their bundle IDs begin with
"com.microsoft.". This breaks native tabs.

Explicitly disable the compatibility patch using NSUserDefaults.

Note that Code-OSS is not affected by the bug, since its bundle ID
is "com.visualstudio.code.oss". To test this behaviour, change
darwinBundleIdentifier in product.json.

* set NSUseImprovedLayoutPass only when window.nativeTabs: true
2018-06-25 18:30:59 +02:00
Sandeep Somavarapu 3669afe7e9 Fix #48656 2018-06-25 18:20:20 +02:00
Sandeep Somavarapu 4d93f9cc37 Fix #51145 2018-06-25 16:38:21 +02:00
Benjamin Pasero e47a9c9eef revert electron 2.0.x update 2018-06-25 09:28:34 +02:00
isidor 67e1e11845 remove centered editor layout from layout menu 2018-06-20 09:31:19 +02:00
Alex Dima 6e088a7162 Minor edits 2018-06-19 17:45:25 +02:00
Joao Moreno e43ab4e4c4 portable mode 2018-06-18 20:04:03 +02:00
Joao Moreno 19753e49e5 fix portable in linux 2018-06-18 17:03:48 +02:00
Benjamin Pasero cf88c4f0ae 💄 2018-06-18 16:53:25 +02:00
Joao Moreno 2e332cc894 fix portable env state propagation in linux 2018-06-18 16:07:10 +02:00
Benjamin Pasero b5ac96b5a9 Merge pull request #51422 from sbatten/titlebarplus
Custom Menubar Implementation
2018-06-18 11:01:10 +02:00
Benjamin Pasero aaff78b996 fix #52045 (#52160) 2018-06-18 09:59:51 +02:00
Benjamin Pasero 11c186f184 some cleanup and 💄 2018-06-17 12:14:35 +02:00
SteVen Batten 329d38e658 fallback to old menubar when using macOS or native title 2018-06-15 13:32:11 -07:00
SteVen Batten f4e55b76d3 move maximized into getUrl 2018-06-14 20:22:54 -07:00
Peng Lyu d94ae55ab6 replace experimental resizeobserver with mutation observer 2018-06-14 11:50:57 -07:00
rebornix f83a748a8e show comments in diff view sidebyside. 2018-06-13 15:48:25 -07:00
SteVen Batten 179eae8352 fix from merge and make titlebar position more reliable 2018-06-13 11:44:59 -07:00
SteVen Batten a83a51484c merge master 2018-06-13 11:25:46 -07:00
isidor edc16f0dc9 fix build 2018-06-13 12:30:41 +02:00
isidor 6683ba1574 getPathLabel clients pass contextService when possible unles you explicitly want an absolute path 2018-06-13 12:01:07 +02:00
Alex Dima 8810c8e74a Have ICommandAction use URIs for the icon location 2018-06-13 10:45:56 +02:00
SteVen Batten f08cdae1e4 maximize window in window configuration 2018-06-12 12:06:04 -07:00
SteVen Batten a68a9750fd add editor layout menu, localize top levels 2018-06-12 10:00:47 -07:00
isidor 9a7535c820 getPathLabel: make only rootProvider optional 2018-06-12 18:22:08 +02:00
Benjamin Pasero 2357b1ca1b fix #44969 2018-06-12 11:22:51 +02:00
SteVen Batten 8db6f8de2a window.ts move listeners 2018-06-11 14:20:00 -07:00
SteVen Batten e3276966a0 workbench.ts feedback 2018-06-11 14:03:04 -07:00
SteVen Batten f7dc69aa31 clean up custom title check 2018-06-11 12:59:01 -07:00
Ramya Rao f7cc895901 Dont do async work on process.on('exit') (#51411)
* Dont do async work on process.on('exit') Fixes #47180

* Refactoring
2018-06-11 08:15:26 -07:00
João Moreno c166a64dc7 Merge pull request #51224 from Microsoft/joao/delay-shared-process
Delay shared process to improve startup times
2018-06-11 15:54:05 +02:00
Benjamin Pasero d0d8929d37 fix #46818 2018-06-11 12:12:28 +02:00
Benjamin Pasero 5695c53f09 electron 2.0.x: disable experimentalFeatures 2018-06-11 10:33:30 +02:00
Daniel Imms b67f6034d2 Merge remote-tracking branch 'origin/master' into tyriar/49477_terminal_menu 2018-06-09 10:34:51 +02:00
SteVen Batten b99fad3a79 more fixes from merge 2018-06-08 15:53:12 -07:00
SteVen Batten 20d4bb7cf6 Merge branch 'master' into titlebarplus 2018-06-08 14:35:32 -07:00
rebornix 861816b325 Revert "remove experimental features flag."
This reverts commit 56a299f37e.
2018-06-08 11:59:29 -07:00
rebornix 56a299f37e remove experimental features flag. 2018-06-08 10:46:57 -07:00
Benjamin Pasero e7d29e9ccc Electron v2.0.0 (#48290)
* Update to Electron 2.0-beta.7

* back to exploration build

* fix compile errors

* workaround build issue (go back to 1.24.0)

* bump to 1.25.0

* use electron 2.0.2

* revert custom distro
2018-06-08 18:32:49 +02:00
Rachel Macfarlane 7408d69ce3 Fix button background color on focus in issue reporter 2018-06-07 16:56:55 -07:00
Rachel Macfarlane e0e11632a5 Lack of feedback when searching for similar issues in extensions when reporting an issue on an extension, fixes #50656 2018-06-07 16:40:56 -07:00
Joao Moreno 80278f8e8b delay shared process to improve startup times 2018-06-06 16:01:49 +02:00
Rachel Macfarlane 0d3288fa40 Make "Reload Window with Extensions Disabled" only disable extensions for that load 2018-06-05 10:30:01 -07:00
Peng Lyu ad635f2b4c Merge remote-tracking branch 'upstream/master' into rmacfarlane/review 2018-06-04 11:14:31 -07:00
Benjamin Pasero 06df95754d bring titlebarplus up to date
* Merge NPM Scripts: Added configuration option to change default click action #49282

* fix #50560

* Fix getmac test (#48804)

* Cleaning up some typos in vscode.d.ts and vscode.proposed.d.ts (#50533)

* yarn.lock changes

* grid - log serialized state if restoring failed

* Fixes #50382: Align .mtku with .detected-link

* debug issues back to isidorn

* Hide interactive playground commands from command palette (fixes #49706)

* grid - drop outline as focus indication and rely on dimmed state

* grid - allow to close empty group when closing all editors of a group

* grid - get preferredSize from grid

* Fixes #43003: Cannot specify a global problemMatcher in tasks.json

* cleanup integrated terminal support for debugging

* grid - action wording tweaks

* #45663 Use core translations asset

* grid - allow to close dirty diff editor if master is still opened in same group

* Support to run npm install from a package node

* grid - log previous UI state upon error

* grid - stronger border top color

otherwise when a tab is showing in a vertical split, the border collides with the sash border

* remove todo

* do not append logLevel

#47774

* Implement Go To Next/Previous Breakpoint editor actions

* Include enabledOnly in debug model interface

* remove from schema

#47774

* #45663 fix compilations

* change openBreakpointSource to use IBreakpoint

* return passed context if resourceOrContext is not useful

* fix off by one issue

* Simplify implementation

* return context if it has a groupId

* polish

* Fixes Microsoft/monaco-editor#891: Focus editor when returning from context menu

* go to next / previosu breakpoint minor polish

* Add Endgame for 1.24

* fix index computing for editor close case

* Fix #49145

- Enable/Disable viewlets by views when context
- Move viewlet enablement/disablement to views service
- Fix - adopt if a viewlet extension is disabled/removed

* Avoid command palette entry (#49340)

* [handlebars] code-folding algorithm is less useful than Indentation-based one. Fixes #48457

* use upper lang id

* Fixes #49378

* #49145 Store placeholder states for all viewlets

* Add `logicalLine` argument to `mutlicursor.insertBelow` and `mutlicursor.insertAbove`

* Removed duplicate loop

* eliminate code duplication; use resolveWorkspaceFolder()

* #45663 Get all asset types

* [css] update service

* [html] update services

* grid - fix compile

* add User-Id to marketplace build requests

* Improve rendererType description

Fixes #50617

* fix #50672

* Fixes #49173

* fix #50321

* fix #50670

* Install option not needed when we have Install and Restart Fixes #50669

* Fixes #50616, Showing/hiding details in Issue Reporter resets scroll position

* Fix #50642, fix #50673

* Issue reporter and process explorer windows should close when the parent window closes, fixes #50716

* Issue Reporter should clear the error state when selecting an extension, fixes #50702

* Extracting methods

* Make sure we update the webview's state on setState

* Avoid prompting for same file type in the same session #50537

* Use language name instead of locale in the prompt #50738

* Use correct failed error code for webview resource load error

* Mark unused parameter

* Restore restart

* Try serializing webviews even if they have not called setState

Fixes #50752

* Change parameter name to match interface name

Fixes #50745

* Fix non-serializable webviews being revived if they called setState

* Include recommended extensions in telemetry events to determine success

* Fix #49777 - Emmet balance In after balance out should go back to initial selection and not first child (#49996)

* Update Emmet - balance.ts

* Cover all cases

* Update prompt msg Fixes #50738

* Fix #50632

* search-rg has no icon

* EH search - replace search.enableSearchProviders with a search-rg specific setting

* fix #50742

* fix #50691

* part of #50760

* smoke: uncomment debug suite

* smoketest: use yarn

* grid - allow to close empty groups via middle click (#50733)

* careful with path comparisons on windows

related to #50760

* smoke: run yarn verbose

* fix #50710

* Improve description (#43208)

* fix #50722

* Fix #50663

* Fix #47586

* fixes #50609

* fixes #50026

* 💄

* fix  #50773

* improve perf of findId and getElementById, #50575

* don't show outline when there are more then 7500 symbols, #50575

* fix typos

* polish for #50667

* fix #50700

* grid keep sizing after branch node demotion

fixes #50564

* grid - for now remove editorGroup.activeEmptyBackground

* fix #50726

* grid: resize views when branch is demoted

fixes #50675

* fix #50727

* fix #50734

* remove preview rant from search.location

* splitview: dont propagate white-sapce property

fixes #50720

* fix #50774

* Fixes #50296

* fix  #50207

* Fixes #24670: Add API to determine if the task service supports parallel task execution.

* fix #50741

* Fixes  #49400: Cannot read property 'then' of undefined

* Fix #50717

* Fix #48901

* polish debug.toolBarLocation

fixes #50786

* Fix #50717

* missing compilation

* Fix #48225

* fix #50711

* Fix errors installing extension from Welcome page (fixes #50753)

* fixes #50794

* fixes #50787

* continuous build: use vsts npm feed

* Fix for #50792: empty pre post scripts not rendered properly

* Fix #50728

* continuous build: use vsts feed

* Fix for #50792 npm exclude doesn´t work for folder names

* Move previewOptions, #50788

* build: remove npm auth

* better fix for #50710

* Revert "Merge pull request #49790 from usernamehw/raw_settings"

This reverts commit f92a162b41, reversing
changes made to fc710af792.

* Remove unused variable

* Fix regression in C# TextMate grammar related to lambda parameters

This tweak fixes a regression recently introduced in the C# TextMate grammar around
implicitly-typed lambda parameters.

* https://github.com/dotnet/csharp-tmLanguage/issues/119
* https://github.com/dotnet/csharp-tmLanguage/issues/120

* Fix parameter not being escaped

Fixes #49057

* wip: grid.getNeighborViews

* Make sure we use normalized path for compare

Fixes #50760

(the path should already have been normalized at this point so I don't think there is any user impact)

* Clean up importModuleSpecifier wording

Fixes #50817

* Remove duplicate strings and small cleanup

* Spelling fix Ouoting -> Quoting

* Restore default settings editor keybinding

* Dont trigger emmet for # in selectors Fixes #49269

* Hide settings editor feedback button in stable

* Use better colors for markdown code blocks

* Moving webview api back to proposed for more polishing

#49022

* Shorten showUnused setting name

Fixes #50648

* fix #50678

* Don't include imports in js/ts document symbol results

Fixes #50829

* smoketest: remove verbose from yarn

* smoketest: clear state from failing search tests

* minor rename

* Fix markdown preview not setting context properly on first creation

Fixes #50558

* smoketest: update to package-lock.json

fixes #50857

* smoketest: bring back search tests

* #48901 Expand by default only in custom viewlets

* fixes #50812

* open editors: clear focus when group without editors is active

fixes #50563

* Fix MaxNumber incrementFileName bug

* Fixes #48758: Do not import standalone editor modules

* fixes #50864

* Use `MAX_SAFE_SMALL_INTEGER`

* Fixes #50858: Task api is still marked as proposed

* fixes #50737

* fix #50867

* Fix: showQuickPick keeps showing infinite progress (fixes #50863)

* Clarify for translation (fixes #50634)

* fixes #50870

* fix #50479

* grid - todo@grid => todo@ben

* grid - adopt new getNeighborViews() method

* grid - add workbench.action.closeEditorsAndGroup

* open editors: close group action

fixes #50625

* open editors: use actionRunner for contexts

fixes #50621

* [css][html] update service

* grid: getNeighborViews

* grid - adopt wrapping

* Some menu action clients (ActionBar) handle alternative actions on their own so the alternative actions should be ignored

fixes #50581

* fillInActionBarActions and fillInContextMenuActions for clarity

* Remove inconsistent use of active in terminal API

Related #48434

* Try using fixAllDescription for js/ts quick fixes

Fixes #42549

* Fixes #50828, code-insiders --status triggered exception in main process

* Pick up ts 2.9.1 final

* Fix for #50868 and #50884

* Still gray out vars even if user has disabled suggestions

Fixes #50890

* grid: fix neighbor npe issue

* grid: more getNeighborViews tests

* grid: use boundaries for neighbor finding

* grid: getNeighborViews perf

* grid: add todo

* 2018-05-31. Merged in translations from Transifex.

* Update GDPR annotation

* update message

* Add specific `refactor.move` scope for js/ts move to new file action

* Use localized language name when available

* Add proper contribution schema for ts server pluguins

#50682

* Fix extra word

* Fix #50909 - add link to new settings editor from old one

* Left-align settings editor preview prompt

* grid - fix issues with touchbar updating

* grid - use viewColumnToEditorGroup in more places

* grid - close all groups should preserve first group

* Reapply fix for #50790

* grid - assign some default keybindings for focus group

* Fixes #50763: All running Visual Studio code instances shutdown all at once

* grid - 💄

* fixes #50926

* show alternative actions when alt is pressed, not only on mouse over

* open editors: click on groups should activate them

* update description (for #50677)

* Fix #50835

* grid - tweak some groups access order

* one more time, fix #50321

* beware of keybinding command null arguments

fixes #50821

* grid - prevent multiple confirmation dialogs for the same editor to show up (for  #50539)

* smoketest: go-to-definition is flaky

fixes #50944
fixes #49107

* Fixes #50943: TSC version 2.9.x in watch mode prints different end compile message

* grid - fix bad === for editors

* 💄 grid, cleanup getViews()

* Update distro commit and third party notices

* Use localizedLanguageName instead of languageNameLocalized which doesnt exist

* Remove now unneeded any

* Make sure unused diags are still updated when suggestions are disabled

Fixes #50890

* Fix unused var

* Update version

* Update issue templates, #49380

* Fix #50893 - escape regex chars when copy search string from editor

* Fix #50985 - don't take editor text when toggling search details
2018-06-04 10:44:46 -07:00