Commit Graph
6479 Commits
Author SHA1 Message Date
Matt Bierner 9d2251469f Do not display errors in editor for cancelled js/ts code lenses
Fixes #63884

Resolving a code lenses may be cancelled if the document changes. This is normal and should not be displayed as an error in the editor
2018-11-27 17:11:07 -08:00
Matt Bierner 42145f1f0c Interupt TS references and implementations requests
Fixes #60213

These are low priority UI elements and should not block user ui requests that come in, such as completions
2018-11-27 16:48:11 -08:00
Matt Bierner 1a1987dee6 Revert "Delegate js/ts code lenses back to vs code"
This reverts commit dc47417f54.

We need finer control over how code lenses are resolved. This is required for #60213. Showing all references in the references code lense now requires using ts plugin instead
2018-11-27 16:48:11 -08:00
Matt Bierner 9e17c2c92c Pick up new TS insiders 2018-11-27 16:11:30 -08:00
Matt Bierner 9461f661f0 Interupt geterror requests for signature help requests
See 7eed623657 for more details
2018-11-27 15:12:10 -08:00
Matt Bierner 7eed623657 Interupt geterror requests for getting completion entry details
UI actions like this should interup potentially long running getError requests on the server. This is because the getErr request must be fully processed before the completion entries can be returned. Explicit user actions in the UI are more important and should be computed as soon as possible
2018-11-27 14:56:07 -08:00
Matt Bierner 2f9f0c35cc Added failing test for #63749
Add skipped test for #63749 so someone can pick this up
2018-11-27 12:02:39 -08:00
Matt Bierner f685215dd4 Adding version info for ts non-code dependencies
Fixes  #63577
2018-11-27 11:40:27 -08:00
Matt Bierner 336db91acb Use switch case 2018-11-27 11:40:27 -08:00
Matt Bierner 9531a7c380 💄 2018-11-27 11:40:27 -08:00
Matt Bierner 0c126b0608 Extract display part kinds to constants files 2018-11-27 11:40:27 -08:00
Matt Bierner bab1ea6c27 💄 2018-11-27 11:40:27 -08:00
Matt Bierner ca7f6c2cf2 Move snippetForFunctionCall to own file 2018-11-27 11:40:27 -08:00
Matt Bierner 77454b24bc Extract append joined placeholders 2018-11-27 11:40:27 -08:00
Matt Bierner 0aef227bbf Try splitting up parameter list extraction from snippet building 2018-11-27 11:40:27 -08:00
Matt Bierner 61ad185759 Make it clearer that insert text snippets override the rest snippet generation 2018-11-27 11:40:27 -08:00
Matt Bierner d5843e550f Fix bug for generating snippet if the object type contained a method signature 2018-11-27 11:40:27 -08:00
Matt Bierner 1755715a13 Fix bug where return type containing function type could be merged with normal parameters 2018-11-27 11:40:26 -08:00
Matt Bierner 86d7fd923a Adding pinning test for inline types 2018-11-27 11:40:26 -08:00
Matt Bierner af05b65331 Adding plnning test for rest paramters 2018-11-27 11:40:26 -08:00
Matt Bierner e8f00e763a Adding pinning test for getting parameters 2018-11-27 11:40:26 -08:00
Matt Bierner ece1bad312 Adding basic pinning tests for insert text 2018-11-27 11:40:26 -08:00
Matt Bierner ec3cba2661 Add test for using insert text 2018-11-27 11:40:26 -08:00
Matt Bierner ecce9249cb Extract snippetForFunctionCall so that it can be tested 2018-11-27 11:40:26 -08:00
isidor 1e3efda93c polish cgmanifest.json 2018-11-20 17:02:09 +01:00
isidor 085f4656ed add some commit hashes and versions to cgmanifest.json 2018-11-20 16:31:08 +01:00
Isidor Nikolic ec98c79d44 Merge pull request #63497 from Microsoft/isidorn/cgmanifest
Start using component governance for oss tracking
2018-11-20 12:54:47 +01:00
isidor 9edd984da8 delete OSSREADME.json 2018-11-20 12:54:22 +01:00
João Moreno 66f717cfa6 Merge pull request #60104 from mathiasvr/fix-60002
Fix #60002 Undo last commit: keep staged files
2018-11-20 09:59:42 +01:00
Joao Moreno 3af878c2d5 💄 2018-11-20 09:58:01 +01:00
Joao Moreno 6052fcf07f Merge commit 'refs/pull/59735/head' of github.com:Microsoft/vscode into pr/59735 2018-11-20 09:43:16 +01:00
Matt Bierner 02a59c3015 Make CachedResponse generic 2018-11-19 18:48:36 -08:00
Matt Bierner fabc627634 Move getSymbolRange out of class 2018-11-19 18:46:09 -08:00
Matt Bierner 1f1618d280 Remove extra conditional
This should always be true
2018-11-19 18:41:26 -08:00
Matt Bierner f953906c74 Remove un-needed any cast 2018-11-19 18:24:59 -08:00
Matt Bierner 26cd646618 Remove unnessisary conditional
The body of these specific events are always non-null
2018-11-19 16:34:15 -08:00
Matt Bierner 277b96327f Enable loading indicator for subsequent js/ts project loads
Fixes #62978
2018-11-19 16:34:15 -08:00
Matt Bierner b115d8860c Extract loadingIndicator to class 2018-11-19 16:34:15 -08:00
Matt Bierner 300f1b8d98 Extract lazy activation logic 2018-11-19 16:34:15 -08:00
Matt Bierner 575e1630d5 Add API so that extensions can configure TS Server plugins
Fixes #63181

This is a replacement for the `_typescript.configurePlugin` command. Using a command, it is easy to forget to check if the js-ts extension is active before executing it. Using an actual api prevents this  and also allows better typing
2018-11-19 14:59:19 -08:00
Matt Bierner 0bfb7fcb54 Add metadata on completions accepted api 2018-11-19 11:04:03 -08:00
Joao Moreno e5406b523e introduce git.openDiffOnClick
fixes #63005
2018-11-19 11:54:51 +01:00
Joao Moreno eb6025ec9b git.postCommitCommand
fixes #62058
2018-11-19 11:54:51 +01:00
Ramya Achutha Rao dcc243c992 Better readability for util.ts 2018-11-18 19:42:02 -08:00
Alex Dima 66f4c5be3a Adopt OSS tool 2018-11-16 23:21:02 +01:00
Alex Dima 976cfe3aa7 Merge branch 'master' into isidorn/cgmanifest 2018-11-16 17:52:27 +01:00
Johannes Rieken c507f6347b set outline label for TypeScript and launch.json, #62839 2018-11-16 16:08:55 +01:00
isidor 040ee51d72 cgmanifest: some commit hashes 2018-11-16 11:46:58 +01:00
João Moreno 850bbb275e Merge pull request #63069 from Microsoft/rmacfarlane/gitapi
Expose 'apply' and 'diff --cached' from git extension API
2018-11-16 09:40:04 +01:00
Matt Bierner a6b8074a19 Remove is 2018-11-15 18:10:35 -08:00