Commit Graph

145 Commits

Author SHA1 Message Date
Alex Dima
4e0de7ce57 web connection 2019-09-16 21:48:57 +02:00
Alex Dima
aa1e29286a Prevent back/forward gestures on macos 2019-09-16 15:55:04 +02:00
Matt Bierner
8678266580 Make Dimension immutable
This value should never be mutated by funtions it is passed to. This change makes it immutable. It also inlines the type in a few places in complex code in legacyLayout that were depending on `Dimension` being  mutable
2019-09-13 15:41:02 -07:00
Alex Dima
2afeba767c Add resourceUriProvider API 2019-09-11 18:02:54 +02:00
Alex Dima
d104c2c46d Fixes #79475: Protect against bad callers of asCSSUrl 2019-08-22 10:56:48 +02:00
Alex Dima
b58579c643 Use cookie for connection token, align fetching of remote resources 2019-08-21 16:11:35 +02:00
Benjamin Pasero
98467c3b7c web - storage/lifecycle 💄 2019-08-17 10:17:09 +02:00
Alex Dima
265dba5598 Fixes microsoft/vscode-remote-release#687:
- remove ipc message that passes over the resolved authority
- don't go through the protocol handler when hitting 127.0.0.1
2019-08-16 17:37:40 +02:00
Alex Dima
623855b7c4 Introduce and adopt asCSSUrl 2019-08-16 17:37:40 +02:00
Alex Dima
1ec1b9fe56 More fixes for #78168 2019-08-07 09:30:27 +02:00
Johannes Rieken
ea123f7547 web - make service worker optional 2019-08-05 15:13:45 +02:00
Johannes Rieken
e0b60266a2 force refetch of remote resources that have been added before the SW is ready, #75061 2019-07-24 12:22:12 +02:00
Johannes Rieken
18a1030852 Revert "update style.textContent instead of calling insertRule, #75061"
This reverts commit 5565ddd88c.
2019-07-22 14:57:25 +02:00
Alexandru Dima
b5bf2319cf Merge pull request #72313 from matpl/master
Add shadow root support for isInDOM function
2019-07-22 10:52:00 +02:00
Johannes Rieken
38aadec987 use structured data as query so that requests can be retriggered if needed, #75061 2019-07-11 14:48:00 +02:00
Johannes Rieken
7980cd2697 replace mutation observer with dom#asDomUri, #75061 2019-07-04 10:20:03 +02:00
Peng Lyu
41b3cbc1dc webkit fullscreen detection 2019-06-24 10:49:24 -07:00
Peng Lyu
3399d30c70 Fullscreen change event. 2019-06-19 18:54:54 -07:00
Johannes Rieken
5565ddd88c update style.textContent instead of calling insertRule, #75061
this change makes style changes visible to the mutation observer
2019-06-19 16:15:32 +02:00
Joao Moreno
3f3e0a53eb tree: active indent guides highlighting 2019-06-18 10:13:04 +02:00
Joao Moreno
3f6640e451 use DOM instead of innerHTML 2019-06-17 17:49:54 +02:00
Joao Moreno
5ece1f176f fixes #71142 2019-06-14 10:32:22 +02:00
Matt Bierner
d27fd54828 Have more inferface / classes that are disposable extend IDisposable
This makes it easier to track which objects are disposable, since we can use findAllReferences on them
2019-06-07 18:26:19 -07:00
Matt Bierner
0b4d3cd604 Remove use of IDisposable[] in a few more places 2019-06-05 15:41:45 -07:00
Mathieu Plourde
2432eb643d Add type assertion to prevent typescript error 2019-04-14 23:42:12 -04:00
Matt Bierner
4151e3e1bb Move convertToPixels into sizeUtils 2019-04-11 10:05:36 -07:00
Matt Bierner
e7e32aff37 Move getDimension into SizeUtils 2019-04-11 10:05:36 -07:00
Matt Bierner
64a37d601a Convert SizeUtils to a static class
This makes it easier to track references to these methods
2019-04-11 10:05:36 -07:00
Mathieu Plourde
39bbc129a0 Add shadow root support for isInDOM
By getting the "host" property when "parentNode" is undefined, the function can properly climb the DOM tree and allow monaco-editor to be used within a shadow root.
2019-04-11 09:45:26 -04:00
Matt Bierner
bb02817e2e Use as const instead of multiple assertions 2019-04-10 15:21:53 -07:00
Matt Bierner
0589591234 Strict null work in editorGroupView 2019-03-05 10:00:06 -08:00
Joao Moreno
f620b3df49 fixes #66878 2019-01-23 09:18:13 +01:00
Joao Moreno
fd3188fbb6 wip: basic list dnd with animation 2019-01-08 16:41:39 +01:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Matt Bierner
986f924ad5 Prefer using Array<T> for complex array types
Use `Array<T | U>` when dealing with union types instead of  `(T | U)[]`
2018-12-13 16:40:44 -08:00
Rob Lourens
fad775b747 Fix #64965 - replace toElement 2018-12-13 11:07:29 -08:00
Matt Bierner
0928a6d348 Prefer coalesce over filter
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Matt Bierner
4bb81b60df Fix event typings
These typing errors were hidden by us previously using `any`
2018-12-02 11:53:15 -08:00
Matt Bierner
2f3fc3f6bb Strongly type some event types in addDisposableListener 2018-11-30 17:15:28 -08:00
Alex Dima
5afd6bb79e Fixes Microsoft/monaco-editor#1191 2018-11-15 15:47:41 +01:00
Alex Dima
17454d4e88 Organize imports 2018-10-23 09:54:11 +02:00
Matt Bierner
891ff5f7f7 Strict null checks
fixing simple cases of any[]
2018-10-18 15:42:28 -07:00
Alex Dima
5bd13a8cee More strict null checks (#60565) 2018-10-12 17:53:47 +02:00
Alex Dima
46d1426b7e Strict null checks (#60565) 2018-10-12 08:49:08 +02:00
Matt Bierner
29d97683a1 Add null annotations for x: T[] = null
This code pattern indicates that the type should be nullable
2018-10-11 14:25:11 -07:00
Matt Bierner
0318e90c93 Add null type annotations for the common x: T = null pattern
In these cases, the programmer has explicitly indicated that the type should be nullable
2018-10-11 14:13:20 -07:00
Matt Bierner
f7456ebf90 Switch to use standard @types/node types instead of our customized version
Using a custom version of the node typings is causing a lot of pain while trying to upgrade our build to use `@types` instead of the `d.ts` files we have to maintain. I believe we primarily maintain our own version for two reason:

- Custom require function
- setTimeout and other timer functions return NodeJs.timer instead of a number

These can both be delt with, the first by using interface augmentation and the second by switching to use any types for timer. I believe that the pain of maintaining our own node `d.ts` outweighs the benefits here

This change switches us to use the standard @types/node package for our node typings
2018-10-03 14:18:36 -07:00
Johannes Rieken
9583bac188 dom - use measure/modify to prevent layout trash in breadcrumbs 2018-10-03 16:07:57 +02:00
Johannes Rieken
528da15df4 perf - avoid layout trashing in breadcrumbs 2018-10-03 14:37:31 +02:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00