Commit Graph

278 Commits

Author SHA1 Message Date
Greg Van Liew
4e70a0f5eb Edits to setting descriptions (#200408) 2023-12-08 22:26:39 +01:00
Benjamin Pasero
6c66a85df1 aux window - drop "detached" (#198889) 2023-11-22 21:19:30 +01:00
Benjamin Pasero
bb6d92668e Aux window: make findGroup work across multiple editor groups (fix #198651) (#198734) 2023-11-21 06:41:06 +00:00
Benjamin Simmonds
a6469cae57 Refactor Configuration Migration Logic (#198414)
* fix migration #198056
2023-11-16 14:27:18 +01:00
Benjamin Pasero
ab66bab0d8 aux window - support confirm on close (#198307) 2023-11-16 08:36:54 +01:00
Benjamin Pasero
e984f918dc Aux window - allow to drag tabs/groups out to open in windows (#197809) 2023-11-10 09:31:34 +01:00
Benjamin Simmonds
d576523abb Updated Editor Actions Location Settings and UI Changes (#197547)
* Updated editor actions location settings and related UI changes

* ShowEditorActions
2023-11-07 10:44:51 +01:00
Benjamin Pasero
e4a5c0948c Merge branch 'main' into benibenj/hideTabsActionBar 2023-11-01 16:48:16 +01:00
Sandeep Somavarapu
9732347d2c Merge pull request #197070 from microsoft/sandy081/floating-debug-toolbar
Support debug tool bar float on custom title bar
2023-10-31 16:54:54 +01:00
BeniBenj
44b0197182 showEditorActionsInTitleBar setting to enum 2023-10-31 14:29:50 +01:00
n-gist
5240f7230a Add pinned tab button (icon) control setting (#196896)
* add pinned tab button (icon) control setting - workbench.editor.pinnedTabButton

* Update editor tab unpin action

* Update editor tab action buttons location and visibility settings mechanics

* Mount tab action button visibility into intermediate TabAction class

* Refactor editor tab actions and settings

---------

Co-authored-by: BeniBenj <besimmonds@microsoft.com>
2023-10-31 08:09:53 +00:00
Sandeep Somavarapu
f5e777073e support debug toolbar on title bar 2023-10-31 08:14:29 +01:00
Benjamin Pasero
b7e5b09166 Merge branch 'main' into benibenj/hideTabsActionBar 2023-10-30 19:28:32 +01:00
Sandeep Somavarapu
c82bf84bf1 fix #196846 (#196847) 2023-10-27 20:01:14 +02:00
BeniBenj
fe571ec566 Add option to show editor actions in title bar 2023-10-25 18:07:43 +02:00
Sandeep Somavarapu
09a4a2f7ab fix migrating workbench.activityBar.visible (#196316) 2023-10-23 22:24:42 +02:00
Benjamin Simmonds
246abc0ecb Maximize editor group (#194894)
* Maximize editor

* unmaximze instead of exit maximize

* add tests

* 💄

* adopt changes

* 💄

* 💄

* 💄

* 💄

* 💄

* 💄

* move context key to WorkbenchContextKeysHandler

* 💄

* 💄

* bug fix

* 💄

* touch file to remove from diff

* test maximized group event

* Update editor group behavior

* 💄

* 💄

* 💄

* 💄

* 💄

* 💄

* setvisibility unmaximizes view if maximized

* Add visibility option to serialized branch node
and update gridview reconstruction behavior

* Fix arrangeGroups method signature

* Save maximized view by location

* Fix activeGroup check in EditorPart

* 💄

* 💄

* Add gridWidgetDisposables to prevent memory leaks.

* simplify GridView.setChildVisible

* Refactor Grid class to return IDisposable
from maximizeView method

* 💄

* move maximizing to gridview layer

* Fix trySet2x2 method to
exit maximized view before setting 2x2

* fix bug

* hasMaximizedGroup

* Refactor GridView for hasMaximizedView

* fix migrations

* Fix double click tab toggle
value in workbench editor

* 💄

* Fix editor group expansion test

* 💄

* 💄

* 💄

* Fix migration with new settings validation

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2023-10-23 12:37:17 +02:00
BeniBenj
e859dc6a99 💄 2023-10-15 18:39:33 +02:00
BeniBenj
2fdc60de8f zen mode show tabs 2023-10-15 17:36:44 +02:00
BeniBenj
2e04ce400a Migration support 2023-10-09 14:45:07 +02:00
BeniBenj
9bd59f6af0 Merge branch 'main' into benibenj/noTabBar 2023-10-09 12:21:01 +02:00
BeniBenj
b9dc1b6a96 turn setting into enum 2023-10-09 12:05:52 +02:00
Sandeep Somavarapu
02cff42b18 top position requires titlebar 2023-10-07 23:28:28 +02:00
Sandeep Somavarapu
3dea66b26d activity bar on top 2023-10-07 18:14:13 +02:00
Benjamin Simmonds
fb50e794eb tabHeight setting name change (#193977)
* setting name change

* 💄

* 💄
2023-09-25 15:34:36 +01:00
Benjamin Simmonds
e0e13e4ff8 pinned tabs separate row (#193081)
* pinned tabs separate row

* fix don't showTabs bugs

* cleanup

* import groupview not groupmodel

* cleanup

* add test cases

* support last editor of other bar drop effect

* get correct height

* Fix bugs

* cleanup, css solutions for hiding actions

* runtime editorindex lookup

* remove empty line

* fix actionbar visibility on startup

* fix tests

* fixes

* fix css

* comment

* fix tests

* remove need for `forceSticky`

* fix move to end of sticky tab

* 💄

* reuse options on drop

* 💄

* 💄

* 💄

* 💄

* tests and efficient contains(), indexOf() lookup

* rename filtered model file

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-09-21 11:56:27 +02:00
Tyler James Leonhardt
6fe1a14974 Have ChatView be default "Ask Chat" location (#192608)
and introduce a setting to change that behavior.
2023-09-08 17:18:25 -07:00
Joyce Er
e71d562fd8 Show inline chat hint in empty text editors (#192352) 2023-09-06 15:40:44 -07:00
BeniBenj
4509267f89 modify tabheight description 2023-09-05 10:56:53 +02:00
BeniBenj
280320786e support not tabs tabheight 2023-09-05 10:21:11 +02:00
BeniBenj
09a9c0140e Support different tab heights 2023-09-04 18:00:07 +02:00
Benjamin Pasero
204d0b3038 window.title setting feedback (fix #191579) (#191885) 2023-08-31 10:05:57 +02:00
Tyler James Leonhardt
ebd67244fb Turn on Command Center by default (#191550)
* Turn on Command Center by default

Fixes https://github.com/microsoft/vscode/issues/191549

* remove tag
2023-08-28 19:14:10 -07:00
Tyler James Leonhardt
aced05cf7c Remove Semantic Similarity Provider (#191039)
Now that RelatedInformationProvider has landed

ref https://github.com/microsoft/vscode/issues/190909
2023-08-25 09:35:31 -07:00
meganrogge
e5921ad238 add focusedView variable to window title 2023-08-16 13:25:07 -07:00
Hans
55b75c5504 Add setting to prevent closing the pinned tab when using middle click (fix #115734) (#188592)
* Fix: Add setting to prevent closing the pinned tab when using middle click (#115734)

* Revert "Fix: Add setting to prevent closing the pinned tab when using middle click (#115734)"

This reverts commit aac0052966.

* add setting for prevent closing the pinned tab when using middle click

* Adjust the description

* Adjust 'pinned' to 'sticky

* adjust prevent close pinned tab related code

* 💄

* some cleanup

* setting description

* fix logic

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-07-28 07:42:56 +00:00
João Moreno
fc450f0726 improve grid auto sizing algorithm (#188898)
* improve grid auto sizing algorithm

fixes #187431

* update description

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-07-26 09:45:14 +01:00
Benjamin Pasero
b0e5025ef5 [Remote-SSH Bug]: Settings missing in remote settings view (fix microsoft/vscode-remote-release#8627) (#186828) 2023-07-03 11:08:06 +02:00
Jacek Kopecký
b97d99f428 Add tabSizingFixedMinWidth setting (#185766) (#186058)
* Add tabSizingFixedMinWidth setting (#185766)

* Add forgotten case for wrapping tabs

* address feedback

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-06-26 14:58:37 +00:00
hsfzxjy
6f25393ada Fix #185858: Add option to enable/disable editor group maximization on double clicking tab title (#185966)
* Add option to enable/disable editor group maximization on double clicking tab title (#185858)

* update description

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-06-26 16:51:54 +02:00
João Moreno
01c7675df5 Editors: have a new auto option for workbench.editor.splitSizing (#185761)
* splitview, grid AutoSizing

* adjust editor setting for new `auto` option

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-06-22 18:18:58 +10:00
Benjamin Pasero
07faf5730d glob - use a generic aka.ms link for glob help (#185759) 2023-06-21 14:59:19 +02:00
Tyler James Leonhardt
e6de1b0822 Miscellaneous NL Command Palette improvements (#185382)
* Always show "Ask Copilot"
* Open Quick Question UX instead of Chat view
* If we have _any_ similar commands, show the "similar commands" separators even if there are no regular picks
* Have Semantic Similarity setting be on by default
* Remove QQ setting since it's not really useful
2023-06-16 18:01:30 -07:00
Tyler James Leonhardt
76ec379410 Mark command palette settings as experimental (#184356)
Mark command palette sessions as experimental

I didn't realize we needed to tag them as well. This adds the tags.
2023-06-05 11:55:52 -07:00
Benjamin Pasero
7ea5b91962 tabs - improve workbench.editor.tabSizingFixedMaxWidth settings description (#184158) 2023-06-02 15:12:36 +02:00
Jacek Kopecký
cbbd9220c2 Add settings for fixed-width tabs (#181729)
* Add settings for fixed-width tabs

This is meant at least partially to address #40290 and
is a continuation of the unfinished work from #40750.

* Only apply fixed width when the setting is on

* Implement chrome-like tab width behavior

Tabs shrink uniformly (down to a limit) but stay fixed-width
when the mouse is over the tab bar.

* Rename width setting to max width

* Make the ifs more readable

* Have event handlers only if the option is set

* 🎨

* Handle sizing artifacts present with wrapping tabs

To achieve this, it's best to remove the transition delay.

* Rename setting to apply only for fixed-sized tabs

* Set default fixed max tab width to 160px

* Minor code tweaks from review comments

* formatting

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Use disposable listeners

* Remove redundant check for last-in-row

* Apply fade gradient from shrink tabSizing to fixed

* Trying to make the code cleaner and understandable

* Remove transition

On advice of @bpasero, removed transition because
the editor doesn't really use transition that much.

* some cleanup

* fix typo

* Simplify workaround for the overflow issue

* 💄

* 💄

* Let the tabs fix their width before closing the editor

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2023-05-22 15:32:52 +00:00
John Murray
b930d45dfa Fix spelling in description of security.restrictUNCAccess setting (#182842) 2023-05-19 08:46:45 +00:00
Benjamin Pasero
b4a2a006a3 Allow to disable UNC access restrictions (fix #182055) (#182755) 2023-05-17 22:32:43 +09:00
Benjamin Pasero
363a88dbaa unc - implement validation (#182286) 2023-05-12 12:28:31 +02:00
Benjamin Pasero
5860847717 unc - update settings description (#182263) 2023-05-12 09:04:35 +02:00