Commit Graph

326 Commits

Author SHA1 Message Date
Daniel Imms
4fde14b9ef Use pascal case for term enums 2021-05-04 05:40:33 -07:00
Daniel Imms
c2f8abb4d2 Remove onRequestDefaultShellAndArgs 2021-05-03 23:01:16 -07:00
Daniel Imms
31cda6eb85 Update all usages of full setting to use const
Fixes #122034
2021-05-03 12:03:09 -07:00
meganrogge
e7c0af1137 Revert "Revert "Merge pull request #122540 from microsoft/tyriar/122104""
This reverts commit 28a1bc2f35.
2021-04-29 12:05:29 -07:00
Matt Bierner
28a1bc2f35 Revert "Merge pull request #122540 from microsoft/tyriar/122104"
This reverts commit 06694a8e57, reversing
changes made to 36fe84236d.
2021-04-28 18:11:32 -07:00
Daniel Imms
10a5077e0b Bring back workspace shells via setting
Fixes #122104
2021-04-28 06:23:30 -07:00
Daniel Imms
eaf3a5dcda Move off deprecated resolve function
Fixes #120328
2021-04-22 03:10:21 -07:00
Daniel Imms
328937e7b6 Use OperatingSystem over Platform in terminal
This prevents the invalid 'web' from possibly being used
2021-04-16 07:00:13 -07:00
Daniel Imms
3ae9ec0051 Adopt requireTrust in terminal 2021-04-16 05:29:28 -07:00
Daniel Imms
9a0441e9cb Inject last active workspace 2021-04-15 07:30:05 -07:00
Daniel Imms
89032503e3 wip 2021-04-13 04:29:38 -07:00
Daniel Imms
264ca56fe1 Rename initialText to message
Part of #120368
2021-04-07 09:20:18 -07:00
Daniel Imms
f8810116c6 Add terminal icon ext api
Part of #120538
2021-04-05 02:42:39 -07:00
Daniel Imms
75b9018255 Validate /etc/shells and findExecutable in unix tests 2021-04-02 05:49:53 -07:00
Daniel Imms
c8ccd07d0f Add initialText proposed API
Part of #120368
2021-04-01 12:27:13 -07:00
Daniel Imms
d02a4aacba Remove quick launch terminology from code
Fixes #119815
2021-03-26 09:56:20 -07:00
meganrogge
ddb7709cbf Fix #119700 fix #119731 fix #119701
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-24 11:02:05 -07:00
Megan Rogge
e8e6d64105 Terminal profiles (#118790)
* get basics working in current dropdown

* filter profiles based on what we want in the dropdown and other info

* add copywright

* terminal.ts -> terminalProfile.ts

* seperate linux distro code

* improve terminalConfig setting description

* add passing tests and fix #79572

* add test for login args

* add wsl stuff

* fix #77652

* lengthen throttle time to 10s

* shell -> process and fire update profiles so dropdown is updated

* consolidate code in terminalProfile

* change profile selection logic

* change profile config structure

* use <ProfileName, IterminalProfileObject> and get wsl distro names to look normal

* provide terminalConfig to terminalProfiles

* move detection/validation to terminalProfiles

* isWorkspaceShellAllowed

* add quickPickOnly so Select Default Profiles returns all and otherwise filters based on config

* Add logs for errors within terminalProfiles

* change return type

* use sync

* fix bug, get custom generated to work

* workspace shell permissions

* add some comments and clean up

* when ext host ready update profiles

* improve terminalProfileObjectEqual check

* don't use windows powershell unless no other powershell
2021-03-16 17:02:59 -07:00
Benjamin Pasero
1441ba91f0 environment - consistently handle VSCODE_CWD in all our node.js processes 2021-03-15 11:22:42 +01:00
Tyler James Leonhardt
27975dad4f move to IProcessEnvService where appropriate in default shell logic (#118271)
* move to IProcessEnvService where appropriate

* change distro
2021-03-08 19:46:34 -08:00
Megan Rogge
cf3faa4046 Don't relaunch extension owned terminals (#117987)
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-03-02 13:55:38 -08:00
Daniel Imms
df5d7c257d Remove exthost terminal processes
Fixes #116864
2021-02-26 04:35:03 -08:00
Megan Rogge
6d0ce95af4 fix #116713 2021-02-24 17:23:19 -08:00
Daniel Imms
6132a763bc Get one way communication happening 2021-02-09 04:07:38 -08:00
Daniel Imms
456841a93b Create createProcess ipc interface 2021-02-08 12:37:10 -08:00
Daniel Imms
9dbc765a38 Add appDirname variable
Part of #115053
2021-02-03 07:50:58 -08:00
Johannes Rieken
3d2ca29012 hide terminal proxy 2021-02-01 12:01:56 +01:00
Daniel Imms
f8ec60aa06 Add flow control setting, remove fake latency 2021-01-14 06:04:03 -08:00
Tyler James Leonhardt
732d4ff89e Make PowerShell 7 default if available and show in choose shell menu (#112768)
* make PowerShell 7 default if available and show in choose shell menu

* misc feedback

* better handle ARM and use pfs everywhere also update pfs to handle AppExecLinks

* fix test

* move to async

* add logging

* powershell global tool is in the image apparently

* have path test be the same

* try/catch the readlink

* await exists

* fix test

* check what arch node is

* fix indexes

* address daniel's feedback

* have getProgramFilesPath return null instead
2021-01-11 15:38:03 -08:00
Alexandru Dima
3d8888779d Fixes #112446: Avoid timeouts in mirroring terminals to the extension host by assigning a temporary UUID to terminals created on the extension host side 2021-01-07 00:13:42 +01:00
Rob Lourens
dce22cf74b Fall back on node API when $SHELL is not set, for
user shell and shell environment discovery
See github/codespaces#1639
2020-12-14 09:36:00 -08:00
Rob Lourens
af6843bacf Convert terminal ext api null args to undefined
Fix #110253
2020-11-15 12:49:42 -08:00
Alex Dima
f3b8f4f765 Do not use process.env directly in findExecutable 2020-10-26 16:00:15 +01:00
Rob Lourens
89540b65db Don't persist debug terminals
#109084
2020-10-22 17:02:18 -07:00
Alex Dima
44f8fcdd2f Avoid needing the entire IConfigurationResolverService for variable resolving & more explicit typing for fetchSetting 2020-10-13 21:10:23 +02:00
Benjamin Pasero
55f071a72f debt - more use of product service over product.ts 2020-09-17 10:08:28 +02:00
Daniel Imms
aa6b2f163d Initial terminal welcome support 2020-08-27 12:38:33 -07:00
Daniel Imms
e8c3ff351b Log ext host terminal process requests 2020-07-24 06:46:25 -07:00
Daniel Imms
b8b7e72473 Move env var collection impl into common
Part of #101857
2020-07-13 06:26:35 -07:00
Daniel Imms
1dd4c04384 Fix launching in ext host/pty terminals 2020-06-12 11:05:45 -07:00
Daniel Imms
af3c79edcb Move ExtensionContext.environmentVariableCollection to stable
Fixes #46696
2020-05-06 03:03:57 -07:00
Daniel Imms
d62c642e3f Don't use environment collections when using strictEnv
Fixes #96630
2020-04-30 14:09:52 -07:00
Daniel Imms
7f5bada046 Move EnvironmentVariableCollection API into ExtensionContext (#96061)
* Move env var collection to ext context

* Remove dispose, fix persistent passing

* Fire collection change on persistence change

* Fix tests by forcing activation and getting ctx

* chore: bump js-debug

Co-authored-by: Connor Peet <connor@peet.io>
2020-04-24 16:45:30 -07:00
Daniel Imms
ae21a79256 Apply the environment in remote 2020-03-27 15:48:07 -07:00
Daniel Imms
fc0712520f Add api tests for env var collections
This does not cover the persisted case
2020-03-27 09:30:32 -07:00
Daniel Imms
000f8392b3 Only persist collections marked to do so 2020-03-27 09:03:53 -07:00
Daniel Imms
d91532afa8 Load in persisted collections from past sessions on ext host 2020-03-27 07:44:56 -07:00
Daniel Imms
1235bd0a60 Support diffs of collections, extracting additions 2020-03-26 16:51:04 -07:00
Daniel Imms
edc7100114 Apply multiple extension mutators, share code with ext host 2020-03-26 15:40:03 -07:00
Daniel Imms
540232e38f Handle persisting and invalidating of collections 2020-03-26 11:20:23 -07:00