Commit Graph

264 Commits

Author SHA1 Message Date
Johannes Rieken
97ed8aba29 add developer command that prints available formatters to console, #41882 2019-01-21 18:19:02 -08:00
Matt Bierner
bcc2281e45 Rename CodeAction.canAutoApply -> CodeAction.preferred
Part of #62110

Use the more generic name as suggested in https://github.com/Dart-Code/Dart-Code/issues/1393. This makes the intent of the field more clear and also allows us to extend the concept of preferred code actions to refactorings and other classes of code actions

Experimentally also allows a `preferred` value for `apply` when configuring code aciton keyboard shortcuts. This applies the preferred code action returned from the list of code actions returned
2019-01-21 14:09:30 -08:00
rebornix
ee3a616601 Max code actions per file is 1000 2019-01-17 17:11:28 -08:00
Matt Bierner
1904cd8d84 Prototype auto fixable quick fixes
Part of #62110

- Adds a new field `canAutoApply` to code actions. This field indicates that a code action can be applied without additional user input. For quick fixes, this should be set if the fix properly addresses the error

- Enable auto fixes for TS spelling errors

- Added a `editor.action.autoFix` command to triggers auto fixes at the current cursor position
2019-01-16 17:56:22 -08:00
Johannes Rieken
14ce5183db renames, #58649 2019-01-11 16:18:56 +01:00
Matt Bierner
6ac9ea2af7 Revert "Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)""
This reverts commit 7b375fcb82.

Reapplies 4a38520d59 with a fix for #66202

Fixes #66202
2019-01-08 11:49:32 -08:00
Johannes Rieken
f9dac59254 add warning/'missing name'-message when symbol has no name, fixes #65545 2019-01-08 12:55:42 +01:00
Joao Moreno
7b375fcb82 Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)"
This reverts commit 4a38520d59.
2019-01-08 10:09:47 +01:00
Matt Bierner
4a38520d59 Add activeSignatureHelp to SignatureHelpContext (#65440)
For #33413

Adds the active `SignatureHelp` object (along with the active signature) to the `SignatureHelpContext`.
2019-01-07 13:55:58 -08:00
Alex Dima
9cf36cdf8f Rename CanonicalExtensionIdentifier to ExtensionIdentifier 2019-01-07 12:00:54 +01:00
Matt Bierner
c109d319fe Second pass converting for index based looping to for-of loops
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Alex Dima
25417553be Adopt case insensitive extension identifiers 2018-12-21 12:41:41 +01:00
Johannes Rieken
514ec620de add SelectionRange and SelectionRangeKind, #63935 2018-12-17 15:10:18 +01:00
Johannes Rieken
c6c7edaa9f debt - asThenable -> asPromise because it returns a promise 2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Johannes Rieken
48a452dcee towards strict null and completion model, #63454 2018-12-11 17:00:19 +01:00
Matt Bierner
100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Johannes Rieken
daae50ab21 ensure a range contains its previous range, #63935 2018-12-03 12:05:50 +01:00
Johannes Rieken
07be58bbad add proposed api for smart select, #63935 2018-12-03 11:29:12 +01:00
Johannes Rieken
253a4f6d17 log provider failure as errors, #63831 2018-12-03 08:47:39 +01:00
Johannes Rieken
58d5205e5a naming and doc tweak for #62839 2018-11-16 16:05:58 +01:00
Johannes Rieken
988f7683df Merge pull request #63150 from YisraelV/customNameForOutline
custom name when there are multiple outline providers - feature request #62839
2018-11-16 16:02:01 +01:00
Johannes Rieken
01d8ba6b8c add keepWhitespace-flag to completion item, #62057 2018-11-16 10:59:37 +01:00
Matt Bierner
30b2a5fd94 Replace !isFalsyOrEmpty with isNonEmptyArray
This new call works as a type guard and can help avoid writing double negations

Avoid either call in cases where we were iterating over the possibly undefined value. Use `|| []` for these
2018-11-14 16:06:13 -08:00
Yisrael
5a8087c60e custom name when there are multiple outline providers 2018-11-14 18:13:52 +02:00
Johannes Rieken
33c89529be fix #63062 2018-11-14 09:39:18 +01:00
Johannes Rieken
201b6dac6a add proposed api for declaration provider, add test, add ipc logic, #62483 2018-11-12 11:05:59 +01:00
Johannes Rieken
0b99867455 working on markdown string dto 2018-11-09 10:50:20 +01:00
Johannes Rieken
488fa952c0 add log messages for all language features (IntelliSense, formatting etc) fixes #43099 2018-11-06 11:56:24 +01:00
Matt Bierner
e377ec6ed2 Use to for converting to extension host
Fixes #61141
2018-10-17 16:25:57 -07:00
Johannes Rieken
078b1415e4 add proposed api for CompletionItemInsertTextRule, #57093 2018-10-17 15:10:15 +02:00
Johannes Rieken
349c18db22 add CompletionItemInsertTextRules on modes.ts so that we can have that in vscode.d.ts, #57093 2018-10-17 15:10:15 +02:00
Matt Bierner
2f51e97117 Add retrigger characters to SignatureHelpProvider
Introduces the concept of a re-trigger character to the signature help provider. This is a seperate set of characters that are registered with the provider. Typing a retrigger character fires a new signature help request if signature help is already showing.

#54972
2018-10-05 16:01:02 -07:00
Johannes Rieken
7d7c27cf3e less strict checking of rename locations, #58907 2018-10-03 16:49:09 +02:00
Matt Bierner
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
We compile using the alwaysStrict flag so these directives are not needed

This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
Johannes Rieken
e808161b9e perf - pre-compute and cache lower case variants for label, sortText, and filterText 2018-10-02 17:46:04 +02:00
Johannes Rieken
d00e5cb041 debt - replace CompletionItem#overwriteBefore/After with CompletionItem#range 2018-10-02 15:31:47 +02:00
Johannes Rieken
3f12ef35a8 debt - modes.ISuggestSupport becomes modes.CompletionItemProvider 2018-10-02 15:31:47 +02:00
Johannes Rieken
81b995a25d debt - less TPromise usage 2018-10-01 14:01:17 +02:00
Johannes Rieken
f79b59416b debt - SuggestionType -> SuggestionKind 2018-09-24 15:58:05 +02:00
Johannes Rieken
01e438743c debt - remove SnippetType 2018-09-17 12:57:34 +02:00
Alex Dima
f9d8addc07 Merge remote-tracking branch 'origin/master' into pr/limerickgds/51557 2018-09-11 15:30:40 +02:00
Johannes Rieken
01f615e016 better error handling when calling prep-rename, #58394 2018-09-11 11:39:21 +02:00
Matt Bierner
d33b1c3063 Initial work on signature help context (#58135)
* Initial work on signature help context

Fixes #54972

Adds `SignatureHelpContext`. This tells providers why signature help was requested

TODO:

- [ ] Better understand semantics of retrigger. Should `retrigger` be an flag instead of a `triggerReason`?
- [ ]  Fix skipped test
- [ ] Add more tests for trigger reasons / trigger characters

* Fix unit test

* Make sure we retrigger sig help if it is already showing

* Add test for dismiss and re-invoke

* Extract some constants

* Extract createMockEditor
2018-09-10 17:44:21 -07:00
Alex Dima
efd8f4a4b2 Adopt CancellationToken in ExtHostLanguageFeaturesShape 2018-09-04 15:33:40 +02:00
Alex Dima
a5ff3ce6c4 Add support for CancellationToken as last argument in RPC communication 2018-09-04 14:54:20 +02:00
Johannes Rieken
3c727a6d01 uri - replace usages of default export with named export (part 2) 2018-09-03 11:04:26 +02:00
Matt Bierner
bd1e8d40fd Fix unit test 2018-07-26 15:42:24 -07:00
Matt Bierner
341013c0ef Log warning when returned code action will be dropped (#55090)
* Add extension logging when returned code action will be dropped

Fixes #54803

Adds a loggin warning when a code action provider returns code actions that will be dropped. Warn in the the following cases:

- A provider returns code actions (not commands)
- And a specific code action type is requested.
- And the returned code actions either don't set kind or are of the wrong kind

* Use log service

* Include extension id in warning
2018-07-26 15:14:16 -07:00